[Bug 534576] New: gnuchess-5.07-144.8: missing call to fclose
http://bugzilla.novell.com/show_bug.cgi?id=534576 Summary: gnuchess-5.07-144.8: missing call to fclose Classification: openSUSE Product: openSUSE 11.2 Version: Factory Platform: All OS/Version: openSUSE 11.1 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Found By: --- I just had a look at factory package gnuchess-5.07-144.8 For source code file gnuchess-5.07/src/book.c around line 340, function BookBuilderOpen is the following code rfp = fopen(BOOKRUN, "rb"); but I fail to find any matching call to fclose This looks like a resource leak to me. Suggest add call to fclose. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=534576
Marcus Meissner
http://bugzilla.novell.com/show_bug.cgi?id=534576
Pavol Rusnak
http://bugzilla.novell.com/show_bug.cgi?id=534576
User marek.belisko@gmail.com added comment
http://bugzilla.novell.com/show_bug.cgi?id=534576#c1
Marek Belisko
http://bugzilla.novell.com/show_bug.cgi?id=534576
User dcb314@hotmail.com added comment
http://bugzilla.novell.com/show_bug.cgi?id=534576#c2
--- Comment #2 from David Binderman
should be changed to:
Good find. I agree the call to read_book should have rfp, not wfp. I think my original comment about adding a call to fclose for rfp still also applies. I checked function read_book, it doesn't call fclose. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=534576
User marek.belisko@open-nandra.com added comment
http://bugzilla.novell.com/show_bug.cgi?id=534576#c3
--- Comment #3 from Marek Belisko
http://bugzilla.novell.com/show_bug.cgi?id=534576
User prusnak@novell.com added comment
http://bugzilla.novell.com/show_bug.cgi?id=534576#c4
Pavol Rusnak
participants (1)
-
bugzilla_noreply@novell.com