[Bug 958314] New: osc install fails with traceback if osc-plugin-install is not installed
http://bugzilla.suse.com/show_bug.cgi?id=958314 Bug ID: 958314 Summary: osc install fails with traceback if osc-plugin-install is not installed Classification: openSUSE Product: openSUSE Distribution Version: Leap 42.1 Hardware: Other OS: Other Status: NEW Severity: Normal Priority: P5 - None Component: Development Assignee: bnc-team-screening@forge.provo.novell.com Reporter: mgriessmeier@suse.com QA Contact: qa-bugs@suse.de CC: okurz@suse.com Found By: --- Blocker: --- Traceback (most recent call last): File "/usr/bin/X11/osc", line 41, in <module> r = babysitter.run(osccli) File "/usr/lib/python2.7/site-packages/osc/babysitter.py", line 61, in run return prg.main(argv) File "/usr/lib/python2.7/site-packages/osc/cmdln.py", line 343, in main return self.cmd(args) File "/usr/lib/python2.7/site-packages/osc/cmdln.py", line 366, in cmd retval = self.onecmd(argv) File "/usr/lib/python2.7/site-packages/osc/cmdln.py", line 500, in onecmd return self._dispatch_cmd(handler, argv) File "/usr/lib/python2.7/site-packages/osc/cmdln.py", line 1230, in _dispatch_cmd return handler(argv[0], opts, *args) File "/usr/lib/python2.7/site-packages/osc/commandline.py", line 3958, in do_install (re.sub(':', ':/', args[0]), 'openSUSE_11.4', args[1]) IndexError: list index out of range -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=958314 http://bugzilla.suse.com/show_bug.cgi?id=958314#c1 --- Comment #1 from Oliver Kurz <okurz@suse.com> --- *if* osc-plugin-install is installed, the stack trace looks like this: -> r = babysitter.run(osccli) /usr/lib/python2.7/site-packages/osc/babysitter.py(61)run() -> return prg.main(argv) /usr/lib/python2.7/site-packages/osc/cmdln.py(343)main() -> return self.cmd(args) /usr/lib/python2.7/site-packages/osc/cmdln.py(366)cmd() -> retval = self.onecmd(argv) /usr/lib/python2.7/site-packages/osc/cmdln.py(500)onecmd() -> return self._dispatch_cmd(handler, argv) /usr/lib/python2.7/site-packages/osc/cmdln.py(1230)_dispatch_cmd() -> return handler(argv[0], opts, *args)
/var/lib/osc-plugins/osc-install.py(203)do_install()
so a method "do_install" within the plugin can be resolved whereas within osc only, if the plugin is not installed, it seems to resolve some probably outdated "do_install", which is incompatible. suggestion: - provide proper error message with hint to the plugin - delete the old stuff from osc itself - streamline the whole "osc install" stuff as it is *the way* to search and install packages in obs :-) -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=958314 Chenzi Cao <chcao@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|bnc-team-screening@forge.pr |adrian@suse.com |ovo.novell.com | -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=958314 http://bugzilla.suse.com/show_bug.cgi?id=958314#c2 Oliver Kurz <okurz@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|adrian@suse.com |marco.strigl@suse.com --- Comment #2 from Oliver Kurz <okurz@suse.com> --- As suggested by Adrian reassigning to Marco. Let's try this way :) I guess my suggestion from comment 1 still holds. FYI: I am currently working on https://bugzilla.opensuse.org/show_bug.cgi?id=1009432 to patch osc-plugin-install for newer versions of our distributions not having /etc/SuSE-release anymore but /etc/os-release. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=958314 Marco Strigl <marco.strigl@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CONFIRMED -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=958314 http://bugzilla.suse.com/show_bug.cgi?id=958314#c3 --- Comment #3 from Marco Strigl <marco.strigl@suse.com> --- This behavior has been changed with version 0.153.0 from 04.03.2016. So the original bug is not valid anymore. Anyway. If you do a 'osc install' osc just says: osc install osc: unknown command: 'install' Try 'osc help' for info. So we have two options: 1. Keep osc-plugin-install and print a hint on 'osc install' that this must be installed to work. - OR - 2. Move osc-plugin-install to osc to an own command 'osc install' I would prefer 1. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=958314 http://bugzilla.suse.com/show_bug.cgi?id=958314#c4 --- Comment #4 from Marcus Hüwe <suse-tux@gmx.de> --- (In reply to Oliver Kurz from comment #2)
As suggested by Adrian reassigning to Marco. Let's try this way :)
I guess my suggestion from comment 1 still holds.
(In reply to Marco Strigl from comment #3)
So we have two options:
1. Keep osc-plugin-install and print a hint on 'osc install' that this must be installed to work.
In general, I would say you are right, but in this particular case let's not resurrect dead commands: - yes, we had an "osc install" command for roughly 3 months (in 2009) - since nov 2009, "osc install" was no official command anymore (hidden from the UI) - in 2016, we removed the hidden + "broken" "osc install" command -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=958314 http://bugzilla.suse.com/show_bug.cgi?id=958314#c5 --- Comment #5 from Marco Strigl <marco.strigl@suse.com> --- (In reply to Marcus Hüwe from comment #4)
In general, I would say you are right, but in this particular case let's not resurrect dead commands: - yes, we had an "osc install" command for roughly 3 months (in 2009) - since nov 2009, "osc install" was no official command anymore (hidden from the UI) - in 2016, we removed the hidden + "broken" "osc install" command
Yes. That's why I would prefer solution 1. Keep the osc-plugin-install and just give a hint if someone issues 'osc install' and osc-plugin-install is not installed. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=958314 http://bugzilla.suse.com/show_bug.cgi?id=958314#c6 --- Comment #6 from Marco Strigl <marco.strigl@suse.com> --- solved in commit 8a78be684ea73ddb34e5f97827898ae534f740a1 from 05.02.2016 There is no install command anymore in osc core. It needs to be installed via plugin. So this bug can be closed. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=958314 http://bugzilla.suse.com/show_bug.cgi?id=958314#c7 Marco Strigl <marco.strigl@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #7 from Marco Strigl <marco.strigl@suse.com> --- Bug will be closed. See comment #6 -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com