[Bug 627818] New: Yast Date and Time configuration dialog does not remember NTP or Manual changes
http://bugzilla.novell.com/show_bug.cgi?id=627818 http://bugzilla.novell.com/show_bug.cgi?id=627818#c0 Summary: Yast Date and Time configuration dialog does not remember NTP or Manual changes Classification: openSUSE Product: openSUSE 11.4 Version: Factory Platform: Other OS/Version: Other Status: NEW Severity: Minor Priority: P5 - None Component: YaST2 AssignedTo: jsuchome@novell.com ReportedBy: trenn@novell.com QAContact: jsrain@novell.com Found By: Development Blocker: --- In Yast textmode do: System->Date and Time->chaNge There you can set "Manually" and "Synchronize with NTP Server". Switch it (doesn't matter which way around). ->Accept->Ok->Quit (Save everything and leave Yast). If you open Yast again and re-enter the dialog: System->Date and Time->chaNge The setting is gone again. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=627818 http://bugzilla.novell.com/show_bug.cgi?id=627818#c Jiří Suchomel <jsuchome@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=627818 http://bugzilla.novell.com/show_bug.cgi?id=627818#c1 --- Comment #1 from Jiří Suchomel <jsuchome@novell.com> 2010-08-09 11:59:17 UTC --- Created an attachment (id=381564) --> (http://bugzilla.novell.com/attachment.cgi?id=381564) patch for /usr/share/YaST2/include/timezone/dialogs.ycp OK, I think that this patch should be there, and they are actually 2 fixes: 1. Introducing ntp_first_time: so when expert dialog is opened for first time (in a running YaST) from main timezone dialog, real status should be read from the system. In later calls (= close expert dialog and open it again), internal variable should be used. 2. Calling "ui_try_save" without explicit $[ "ntpdate_only" : true]. Well, I do not know why this was there, looks like evident bug. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=627818 http://bugzilla.novell.com/show_bug.cgi?id=627818#c2 Jiří Suchomel <jsuchome@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO InfoProvider| |mvidner@novell.com --- Comment #2 from Jiří Suchomel <jsuchome@novell.com> 2010-08-09 12:08:05 UTC --- But the changes above still won't solve the reported problem, because of somewhat new (?) feature of "Run NTP as daemon". When this is not checked, NTP deamon won't be running after saving the settings. It is probably correct (if it means that some kind of regular synchronization is still in action), but the problem is during the read process: the initial status of radiobutton is determined by GetNTPEnabled function from ntp-client_proposal.ycp, which only checks the service status. Martin, could you explain why we have both "Run NTP as daemon" and "Save NTP Configuration" checkboxes? (IMHO we had only "Save NTP Config" before, which meant also starting the daemon) Could the state of "NTP saved, but daemnon not running" be reflected by GetNTPEnabled? (BTW, this bug is not related to text mode) -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=627818 http://bugzilla.novell.com/show_bug.cgi?id=627818#c3 --- Comment #3 from Jiří Suchomel <jsuchome@novell.com> 2010-08-10 09:41:53 UTC --- I'd expect the change in NTP client should be something like this: =================================================================== --- ntp-client_proposal.ycp (revision 62371) +++ ntp-client_proposal.ycp (working copy) @@ -77,7 +77,7 @@ } boolean GetNTPEnabled () { - return Service::Enabled (NtpClient::service_name); + return NtpClient::synchronize_time || Service::Enabled (NtpClient::service_name); } .. but NtpClient::synchronize_time is only initialized in NtpClient::Read which is not called in that parts of proposal -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=627818 https://bugzilla.novell.com/show_bug.cgi?id=627818#c4 --- Comment #4 from Jiří Suchomel <jsuchome@novell.com> 2010-09-02 08:06:01 UTC --- Created an attachment (id=387073) --> (http://bugzilla.novell.com/attachment.cgi?id=387073) patch for ntp-client/src This patch for yast2-ntp-client should solve the above issue. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=627818 https://bugzilla.novell.com/show_bug.cgi?id=627818#c5 Jiří Suchomel <jsuchome@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |RESOLVED CC| |varkoly@novell.com InfoProvider|mvidner@novell.com | Resolution| |FIXED --- Comment #5 from Jiří Suchomel <jsuchome@novell.com> 2010-09-02 09:23:57 UTC --- I've tested patch above with 11.3 and it seems to work. Included in yast2-ntp-client-2.20.0 package, and submitted to Factory. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=627818 https://bugzilla.novell.com/show_bug.cgi?id=627818#c6 Jiří Suchomel <jsuchome@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED CC| |jsuchome@novell.com Resolution|FIXED | AssignedTo|jsuchome@novell.com |varkoly@novell.com --- Comment #6 from Jiří Suchomel <jsuchome@novell.com> 2010-09-02 09:27:27 UTC --- (In reply to comment #5)
I've tested patch above with 11.3 and it seems to work. Included in yast2-ntp-client-2.20.0 package, and submitted to Factory.
Oh no, did not submit: "There are changes in OBS only not reflected in SVN. Merge them first." Peter, plese make svn version up-to date, so my changes could go to OBS. Do not forget we have 2.20.x versioning for Factory/11.4. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=627818 https://bugzilla.novell.com/show_bug.cgi?id=627818#c7 Peter Varkoly <varkoly@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |CLOSED Resolution| |FIXED --- Comment #7 from Peter Varkoly <varkoly@novell.com> 2010-11-30 11:11:39 UTC --- I've reviewed OSC YaST:Head/yast2-ntp-client and this contains your changes. I've created sr #54156, but only yast2-ntp-client.spec was transmitted. It means for me, that your changes alreade was in factory. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=627818 http://bugzilla.novell.com/show_bug.cgi?id=627818#c8 --- Comment #8 from Bernhard Wiedemann <bwiedemann@suse.com> --- This is an autogenerated message for OBS integration: This bug (627818) was mentioned in https://build.opensuse.org/request/show/45660 Factory / yast2-country https://build.opensuse.org/request/show/52894 Factory / yast2-ntp-client -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com