[Bug 423717] New: Wrong check in brp-check-suse
https://bugzilla.novell.com/show_bug.cgi?id=423717 Summary: Wrong check in brp-check-suse Product: openSUSE 11.1 Version: Factory Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: P5 - None Component: Basesystem AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: vuntz@novell.com QAContact: qa@suse.de Found By: --- If you look at the log of system-config-printer in home:vuntz:factory-playground, you can see this: ERROR: Icon file not installed: /var/tmp/system-config-printer-1.0.7-build//usr/share/applications/my-default-printer.desktop WARNING: Empty GenericName: /var/tmp/system-config-printer-1.0.7-build//usr/share/applications/my-default-printer.desktop ERROR: Icon file not installed: /var/tmp/system-config-printer-1.0.7-build//usr/share/applications/system-config-printer.desktop WARNING: Empty GenericName: /var/tmp/system-config-printer-1.0.7-build//usr/share/applications/system-config-printer.desktop Errors in installed desktop file detected. Please mail adrian@suse.de, if you think this is wrong. error: Bad exit status from /var/tmp/rpm-tmp.74720 (%install) The icon name that causes the error is printer, and it's a valid icon name. See http://specifications.freedesktop.org/icon-naming-spec/icon-naming-spec-late... Sure, it's not installed by the application, but it should still be possible to use it. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=423717
User stbinner@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=423717#c1
Stephan Binner
https://bugzilla.novell.com/show_bug.cgi?id=423717
User vuntz@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=423717#c2
Vincent Untz
https://bugzilla.novell.com/show_bug.cgi?id=423717
User adrian@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=423717#c3
Adrian Schröter
https://bugzilla.novell.com/show_bug.cgi?id=423717
User vuntz@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=423717#c4
Vincent Untz
https://bugzilla.novell.com/show_bug.cgi?id=423717
User vuntz@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=423717#c5
Vincent Untz
https://bugzilla.novell.com/show_bug.cgi?id=423717
User ro@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=423717#c6
Ruediger Oertel
https://bugzilla.novell.com/show_bug.cgi?id=423717
User vuntz@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=423717#c7
Vincent Untz
ad #1: yes, that's exactly the issue. someone needs to tell me if whitelisting other sorts of icons (device in this case) will be okay for all desktops as well.
GNOME and gtk+-based desktops (XFCE, eg) are fine with this. I've been told KDE doesn't support that, although I'm surprised. But I opened bug 426990 about this. But between packages failing to build and a missing icon for a GNOME program in KDE, I prefer the latter.
ad #2: I'd be happy about a patch (would save me looking too deep into that code)
Okay, not a real patch, but in brp-check-suse, open brp-desktop.data/xdg_menu. Look for {apps,stock} and add the missing directories from this list. Looking at the code, you have to take the directories that exist in crystalsvg, gnome and hicolor. So that's {actions,apps,devices,mimetypes,status}. There's no stock in crystalsvg. If you can ignore the find errors, then {actions,animations,apps,categories,devices,emblems,emotes,filesystems,intl,mimetypes,places,status,stock} -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=423717
User ro@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=423717#c8
Ruediger Oertel
https://bugzilla.novell.com/show_bug.cgi?id=423717
User coolo@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=423717#c9
Stephan Kulow
https://bugzilla.novell.com/show_bug.cgi?id=423717
User vuntz@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=423717#c10
Vincent Untz
printer: "The icon used for a printer device." - this is not to be used for applications, so the check is right.
Where in the icon theme spec is this mentioned? AFAIK, it is valid to do that. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=423717
User coolo@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=423717#c11
Stephan Kulow
https://bugzilla.novell.com/show_bug.cgi?id=423717
User vuntz@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=423717#c12
Vincent Untz
wher in the icon theme spec is it mentioned that it's valid?
See http://specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-latest... which described how an icon is looked up. The context of the icon is not taken into account and we look in all of them.
Sorry, this check is there to avoid missing icons.
Sure, I understand that. And I'm fine with it if it also checks if the icon exists in the device context. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=423717
User coolo@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=423717#c13
Stephan Kulow
https://bugzilla.novell.com/show_bug.cgi?id=423717
User ro@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=423717#c14
Ruediger Oertel
https://bugzilla.novell.com/show_bug.cgi?id=423717
User vuntz@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=423717#c15
Vincent Untz
participants (1)
-
bugzilla_noreply@novell.com