[Bug 508078] New: submitting packages to Factory removes my copyright notice
http://bugzilla.novell.com/show_bug.cgi?id=508078 Summary: submitting packages to Factory removes my copyright notice Classification: openSUSE Product: openSUSE 11.2 Version: Factory Platform: All OS/Version: All Status: NEW Severity: Critical Priority: P5 - None Component: Other AssignedTo: jw@novell.com ReportedBy: wolfgang@rosenauer.org QAContact: qa@suse.de Found By: Third Party Developer/Partner Once a package is accepted and submitted to openSUSE:Factory in the buildservice individual copyright messages are removed! Here the difference: --- mozilla-xulrunner191.spec.backup 2009-05-29 09:35:25.000000000 +0200 +++ mozilla-xulrunner191.spec 2009-05-28 02:03:22.000000000 +0200 @@ -2,7 +2,6 @@ # spec file for package mozilla-xulrunner191 (Version 1.9.1b4) # # Copyright (c) 2009 SUSE LINUX Products GmbH, Nuernberg, Germany. -# 2006-2009 Wolfgang Rosenauer # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=508078 User jw@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=508078#c1 Juergen Weigert <jw@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO Info Provider| |ro@novell.com Severity|Critical |Major --- Comment #1 from Juergen Weigert <jw@novell.com> 2009-05-29 10:05:25 MDT --- Rudi, this must not happen. We need to be able to honor external contributors' copyright. I'd like to work with your team, to locate the guilty script and find a solution. Reducing from Critical to Major, as Wolfgangs involvement with our mozilla packages is very well known. Wolfgang, please increase again, if your reputation is suffering due to this unfortunate misrepresentation on our side. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=508078 User lrupp@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=508078#c3 Lars Vogdt <lrupp@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW Info Provider|ro@novell.com | --- Comment #3 from Lars Vogdt <lrupp@novell.com> 2009-05-30 02:11:50 MDT --- Wolgang: as far as I see, our script searches for lines starting with: # Copyright For details - the perl code: .. if ( /^#\s*Copyright\s*/ ) { push(@copyrights, $_) .. So please try again just by using this line in your specfile: # Copyright (c) 2006-2009 Wolfgang Rosenauer This should fix the problem. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=508078 User jw@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=508078#c4 --- Comment #4 from Juergen Weigert <jw@novell.com> 2009-06-02 07:22:49 MDT --- We should collect Copyright lines, and all lines following a copyright line until we run into a very short line, or into the subsequent text. Suggested patch for prepare_spec: if ( /^#\s*Copyright\s*/ ) { for (;;) { # check if line is ONLY a standard copyright line, if so, ignore. my $c = $_; $c =~ s{\s*(\d+|copyrights?|\(c\)|suse|linux|products|gmbh|nuremberg|n..?rnberg|germany|\W+)\s*}{}gi; push(@copyrights, $_) if length $c > 5; last if length $readspec[0] < 10 or $readspec[0] =~ m{modifications and additions}i; $_ = shift @readspec; } next; } -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=508078 Juergen Weigert <jw@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|jw@novell.com |lrupp@novell.com -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=508078 User jw@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=508078#c5 Juergen Weigert <jw@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jw@novell.com --- Comment #5 from Juergen Weigert <jw@novell.com> 2009-06-02 07:24:16 MDT --- Lars, can you add the above patch, please? -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=508078 User wolfgang@rosenauer.org added comment http://bugzilla.novell.com/show_bug.cgi?id=508078#c6 --- Comment #6 from Wolfgang Rosenauer <wolfgang@rosenauer.org> 2009-06-02 07:29:12 MDT --- FWIW, I can confirm that Lars is right with comment 3. That works but as it isn't documented it's not a final solution. Jürgen's approach is a bit more bullet proof I think. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=508078 User lrupp@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=508078#c7 Lars Vogdt <lrupp@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution| |FIXED --- Comment #7 from Lars Vogdt <lrupp@novell.com> 2009-06-02 08:56:44 MDT --- Added patch from comment #4 - thanks Jürgen! Closing now. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com