[Bug 928542] New: Evolution v3.16 no longer honors "Preformatted" inlined plain text
http://bugzilla.opensuse.org/show_bug.cgi?id=928542 Bug ID: 928542 Summary: Evolution v3.16 no longer honors "Preformatted" inlined plain text Classification: openSUSE Product: openSUSE Factory Version: 201503* Hardware: x86-64 OS: Other Status: NEW Severity: Major Priority: P5 - None Component: Evolution Assignee: bnc-team-evolution@forge.provo.novell.com Reporter: mgalbraith@suse.com QA Contact: lakhil@novell.com Found By: --- Blocker: --- User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:37.0) Gecko/20100101 Firefox/37.0 Build Identifier: Kernel developers, and likely others, frequently insert patches inline in message body after setting "Plain text" and "Preformatted", to prevent the patch from being whitespace damaged. This is a very important capability which worked fine through v3.12, but no longer works in v3.16 in Tumbleweed. This is a serious regression for those impacted. I've reverted to v3.12 built from openSUSE-13.2 source, but that's obviously not a good long term solution :) Reproducible: Always Steps to Reproduce: 1. insert patch 2. send to someone 3. recipient sees tabs converted to spaces, ie patch is busted upon receipt Actual Results: recipient receives inline broken patch which can't be applied Expected Results: recipient receives the unmodified preformatted plain text we asked for when poking "Plain text" and "Preformatted". I also noticed that when I save a message as mbox, the resulting file contains trailing carriage returns as well. This was previously not the case, and is an annoyance, but one that can be worked around by feeding the output file to fromdos to strip out the windows/dos crud and turn it into a unix text file. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=928542
Mike Galbraith
http://bugzilla.opensuse.org/show_bug.cgi?id=928542
http://bugzilla.opensuse.org/show_bug.cgi?id=928542#c1
Bjørn Lie
http://bugzilla.opensuse.org/show_bug.cgi?id=928542
Bjørn Lie
http://bugzilla.opensuse.org/show_bug.cgi?id=928542
http://bugzilla.opensuse.org/show_bug.cgi?id=928542#c2
--- Comment #2 from Mike Galbraith
Moving to gnome since there is nobody on the other side of bnc-team-evolution.
Is this still an issue?
I had to switch to 42.1 meanwhile, so have no idea wrt the current state of Evolution in Tumbleweed. 42.1 is currently at Evolution 3.16.5 though, and with this OS/Evolution combination at least, preformatted text does work, as far as being able to send a patch goes. It's useless for patch review though, see below. Note how it inserts '>' characters all over the place the instant you use preformatted to restore the displayed patch to the state it was sent in, ie to undo the line wrapping that 'normal' does. --- a/kernel/sched/fair.c
* This cpu is idle. If the busiest group is not overloaded * and there is no imbalance between this and busiest group * wrt idle cpus, it is balanced. The imbalance becomes -> > > * significant if the diff is greater than 1 otherwise we -> > > * might end up to just move the imbalance on another group +> > > * significant if the diff is greater than 1 for most CPUs, +> > > * or 2 for older CPUs having multiple groups of 2 cores +> > > * sharing an L2, otherwise we may end up uselessly moving +> > > * the imbalance to another group, or starting a tug of war +> > > * with idle L2 groups constantly ripping communicating +> > > * tasks apart, and no L3 to mitigate the cache miss pain. */ -> > > if ((busiest->group_type != group_overloaded) && -> > > > > (local->idle_cpus <= (busiest->idle_cpus + 1))) -> > > > goto out_balanced; +> > > if (busiest->group_type != group_overloaded) { +> > > > int imbalance = __this_cpu_read(sd_llc_size) == 2 ? 2 : 1;
+++ b/kernel/sched/fair.c @@ -7249,12 +7249,19 @@ static struct sched_group *find_busiest_ + +> > > > if (local->idle_cpus <= busiest->idle_cpus + imbalance) +> > > > > goto out_balanced; +> > > }
} else {
/* * In the CPU_NEWLY_IDLE, CPU_NOT_IDLE cases, use
-- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=928542
http://bugzilla.opensuse.org/show_bug.cgi?id=928542#c3
Bjørn Lie
It's useless for patch review though, see below. Note how it inserts '>' characters all over the place the instant you use preformatted to restore the displayed patch to the state it was sent in, ie to undo the line wrapping that 'normal' does.
Not sure to be honest, I just package the thing, the internals of evolution is unexplored territory for me. I've very recently made this change +- Add highlight BuildRequires: Build highlight source-code in + mailbody support, we now have the needed package. Following + this: Stop passing --disable-text-highlight to configure. That may or may not fix your issue. The buildrequires is unfortunately not available on Leap. ========= So I guess in a sense, the original bug is solved, will update title. SLE people: hightlight is available in upcoming Leap 42.2, but the required change to use highlight feature is not currently enabled in evolution. Is this something you would consider enabling? -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=928542
http://bugzilla.opensuse.org/show_bug.cgi?id=928542#c4
--- Comment #4 from Mike Galbraith
(In reply to Mike Galbraith from comment #2)
It's useless for patch review though, see below. Note how it inserts '>' characters all over the place the instant you use preformatted to restore the displayed patch to the state it was sent in, ie to undo the line wrapping that 'normal' does.
Not sure to be honest, I just package the thing, the internals of evolution is unexplored territory for me.
I've very recently made this change
+- Add highlight BuildRequires: Build highlight source-code in + mailbody support, we now have the needed package. Following + this: Stop passing --disable-text-highlight to configure.
That may or may not fix your issue.
Dunno. When doing patch review, you don't want the text munged in any way, that is done by the reviewer. Guess I'll find out eventually.
So I guess in a sense, the original bug is solved, will update title.
Yeah, my originally reported issue went away. Hopefully it crawled into a hole and buried itself, is not just hiding around the corner ;-) -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=928542
http://bugzilla.opensuse.org/show_bug.cgi?id=928542#c5
--- Comment #5 from Bjørn Lie
Dunno. When doing patch review, you don't want the text munged in any way, that is done by the reviewer. Guess I'll find out eventually.
So I guess in a sense, the original bug is solved, will update title.
Yeah, my originally reported issue went away. Hopefully it crawled into a hole and buried itself, is not just hiding around the corner ;-)
Btw, you have tried to change your "reply/quoting" style settings? (Edit -> Preferences -> composer prefs - replies and forwards) This however have an effect on "all emails". -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=928542
http://bugzilla.opensuse.org/show_bug.cgi?id=928542#c6
--- Comment #6 from Mike Galbraith
(In reply to Mike Galbraith from comment #4)
Dunno. When doing patch review, you don't want the text munged in any way, that is done by the reviewer. Guess I'll find out eventually.
So I guess in a sense, the original bug is solved, will update title.
Yeah, my originally reported issue went away. Hopefully it crawled into a hole and buried itself, is not just hiding around the corner ;-)
Btw, you have tried to change your "reply/quoting" style settings?
(Edit -> Preferences -> composer prefs - replies and forwards)
This however have an effect on "all emails".
Just did that. Nope, there's no really usable substitute. While 'inline' doesn't insert crud when you use preformatted to restore the line wrapped default to again be 'C' as 'quoted' started doing, to use 'inline' during review, you'd have to manually make it look like the quoted style that people have become accustomed to over decades. I'll have a look at that --disable-text-highlight thingy. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=928542
http://bugzilla.opensuse.org/show_bug.cgi?id=928542#c7
--- Comment #7 from Bjørn Lie
Just did that. Nope, there's no really usable substitute. While 'inline' doesn't insert crud when you use preformatted to restore the line wrapped default to again be 'C' as 'quoted' started doing, to use 'inline' during review, you'd have to manually make it look like the quoted style that people have become accustomed to over decades.
I'll have a look at that --disable-text-highlight thingy.
It's quite possible that your use case is not covered by evolution. I'd file a bug upstream if I were you, as you then could get a definitive answer if what you want to achieve is even possible with the current feature set. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=928542
http://bugzilla.opensuse.org/show_bug.cgi?id=928542#c8
--- Comment #8 from Mike Galbraith
(In reply to Mike Galbraith from comment #6)
Just did that. Nope, there's no really usable substitute. While 'inline' doesn't insert crud when you use preformatted to restore the line wrapped default to again be 'C' as 'quoted' started doing, to use 'inline' during review, you'd have to manually make it look like the quoted style that people have become accustomed to over decades.
I'll have a look at that --disable-text-highlight thingy.
It's quite possible that your use case is not covered by evolution. I'd file a bug upstream if I were you, as you then could get a definitive answer if what you want to achieve is even possible with the current feature set.
Yeah, I can try that. Go ahead and close this bug, as it's not a distro issue. I thought I'd try to bisect it, given 3.12 in opensuse-13.2 works fine, but alas, you have to build data-server in lockstep, so even though git said it would only take 9 builds to bisect, the data-server dependency killed that idea. Hohum. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=928542
http://bugzilla.opensuse.org/show_bug.cgi?id=928542#c9
Bjørn Lie
participants (1)
-
bugzilla_noreply＠novell.com