[Bug 543470] New: firmwarekit-3-45.39: missing call to pclose
http://bugzilla.novell.com/show_bug.cgi?id=543470 Summary: firmwarekit-3-45.39: missing call to pclose Classification: openSUSE Product: openSUSE 11.2 Version: Factory Platform: All OS/Version: openSUSE 11.1 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Found By: --- I just had a look at factory package firmwarekit-3-45.39 source code file linuxfirmwarekit/pciresource/pciinfo.c function gather_pci_info local variable file. I notice the following code file = popen(lspci_cmd, "r"); but I fail to notice any matching call to pclose. This looks like a resource leak to me. Suggest add a call to pclose near the end of the block to plug the leak. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=543470 Marcus Meissner <meissner@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team-screening@forge.pr |trenn@novell.com |ovo.novell.com | -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=543470 User rguenther@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=543470#c1 --- Comment #1 from Richard Guenther <rguenther@novell.com> 2009-10-17 08:56:02 MDT --- David, in case the issues are not introduced by a patch local to openSUSE please report the issues upstream. Packagers, please do not add openSUSE-local patches to fix this kind of errors but forward the bugs upstream and close the bugs as RESOLVED UPSTREAM. Note that it is perfectly fine to have "resource leaks" at the end of a program as the kernel will clean up for you. Manually freeing them only increases binary size and runtime. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
Note that it is perfectly fine to have "resource leaks" at the end of a program IMO it's always worth freeing memory and file descriptors, also at the end of a
http://bugzilla.novell.com/show_bug.cgi?id=543470 User trenn@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=543470#c2 Thomas Renninger <trenn@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |UPSTREAM --- Comment #2 from Thomas Renninger <trenn@novell.com> 2009-10-17 13:27:48 MDT --- Thanks Richard. program, but everyone can decide this for himself. But Richard is right, we cannot take the overhead and forward every little bug fix to mainline projects. We should have or be near to the latest linuxfirmwarekit version, you may want to submit a fix to: <firmwarekit-discuss@bughost.org> If you want to register for the list or get the very latest sources, the project is hosted here: http://linuxfirmwarekit.org -> closing that RESOLVED UPSTREAM. It's not a sever bug as linuxfirmwarekit is a debug tool, running for some minutes only. If you add me to CC, I can give you a Reviewed-by: Thanks for finding this one! -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com