https://bugzilla.novell.com/show_bug.cgi?id=660700 https://bugzilla.novell.com/show_bug.cgi?id=660700#c1 Andreas Hanke changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andreas.hanke@gmx-topmail.d | |e --- Comment #1 from Andreas Hanke 2010-12-21 01:14:27 UTC --- The problem is caused by %fdupes replacing directories with symlinks. It should never ever do that (and instead only replace the individual files with symlinks, even if entire directories are duplicates) because rpm cannot handle the case where a symlink is replaced by a directory. If now the old version of a package had duplicate directories and they are no longer exact duplicates in the new version, the symlink becomes a directory again, and rpm breaks. For packages where this already happened, the only solution is to add %pre scriptlets which remove the symlinks. The real fix is in %fdupes, of course. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=660700 https://bugzilla.novell.com/show_bug.cgi?id=660700#c2 Pavol Rusnak changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|prusnak@novell.com |mvyskocil@novell.com Summary|Packaging Bugs in |do not allow to use fdupes |thunar-doc-1.1.5-36.1 |-s --- Comment #2 from Pavol Rusnak 2011-01-05 17:19:53 CET --- Thunar is fixed. Michal: could we please modify the macro to die with error message when -s parameter is used? While I understand that running fdupes on the whole buildroot is a bad idea, fdupes creating symlinks are causing even more trouble in practise. We should educate packagers to never use -s and to call fdupes on respective subdirectories - in 99% of cases it is %fdupes %{buildroot}%{_datadir} anyway. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=660700 https://bugzilla.novell.com/show_bug.cgi?id=660700#c4 Michal Vyskocil changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO InfoProvider| |andreas.hanke@gmx-topmail.d | |e --- Comment #4 from Michal Vyskocil 2011-01-06 12:56:56 UTC --- Pavol: aren't you requesting break a build of major part of Factory, don't you? I'm sure that every user will be rude from that change, which is for nothing. The problem is not in fdupes nor %fdupes. At least fdupes newer prints the name of directory - it does not work with them at all and it skips the S_ISDIR items from readdir() results. And I was never been able to create example when it symlinks directories. $ tree dir1 dir1 ├── bar-file ├── baz-file ├── not-a-duplicate-file ├── with-subdir │   ├── foo-file │   └── one-file └── yet └── another └── subdir ├── bar-file ├── baz-file └── not-a-duplicate-file 4 directories, 8 files Plain fdupes call $ fdupes -q -n -r dir1/ dir1/not-a-duplicate-file dir1/yet/another/subdir/not-a-duplicate-file dir1/baz-file dir1/with-subdir/one-file dir1/yet/another/subdir/baz-file dir1/bar-file dir1/with-subdir/foo-file dir1/yet/another/subdir/bar-file Script stripped from %fdupes macro prints the $ sh fdupes.sh dir1/ ln -sf dir1/not-a-duplicate-file dir1/yet/another/subdir/not-a-duplicate-file ln -sf dir1/baz-file dir1/with-subdir/one-file ln -sf dir1/baz-file dir1/yet/another/subdir/baz-file ln -sf dir1/bar-file dir1/with-subdir/foo-file ln -sf dir1/bar-file dir1/yet/another/subdir/bar-file Andreas: if you're sure the problem is in fdupes, then please provide a test case. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=660700 https://bugzilla.novell.com/show_bug.cgi?id=660700#c6 Michal Vyskocil changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |RESOLVED InfoProvider|andreas.hanke@gmx-topmail.d | |e | Resolution| |INVALID --- Comment #6 from Michal Vyskocil 2011-01-13 10:38:35 UTC --- Closed as INVALID - feel free to reopen, if you will have a test case for fdupes. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.