[Bug 677236] Buffer overflow in fsck.vfat
https://bugzilla.novell.com/show_bug.cgi?id=677236 https://bugzilla.novell.com/show_bug.cgi?id=677236#c5 Petr Gajdos <pgajdos@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO InfoProvider| |lnussel@novell.com --- Comment #5 from Petr Gajdos <pgajdos@novell.com> 2011-03-08 16:52:37 UTC --- (In reply to comment #4)
Already fixed upstream: http://git.debian-maintainers.org/?p=daniel/dosfstools.git;a=commitdiff;h=a9...
How this change correspond with comment 3? I think only '\0' make the problem here. I would vote for another solution: char expanded[12]; sprintf(expanded, pattern, curr_num); memcpy(de->name, expanded, 8); memcpy(de->ext, expanded+8, 3); like in the preceding part of if (or maybe use snprintf()). alloc_rootdir_entry() could be used in the future for another tasks (as we do it in label.patch yet). There could be the extension necessary. What do you think? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply@novell.com