[Bug 210297] New: hal-device-manager does not start up because of unexpanded variable.
https://bugzilla.novell.com/show_bug.cgi?id=210297 Summary: hal-device-manager does not start up because of unexpanded variable. Product: openSUSE 10.2 Version: Alpha 5 Platform: All OS/Version: All Status: NEW Severity: Normal Priority: P5 - None Component: Basesystem AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: andreas.hanke@gmx-topmail.de QAContact: qa@suse.de Trying to launch hal-device-manager, I get: % hal-device-manager Traceback (most recent call last): File "/usr/bin/hal-device-manager", line 13, in <module> import Const ImportError: No module named Const The reason is in /usr/bin/hal-device-manager: sys.path.append('${prefix}/share/hal/device-manager') ${prefix} needs to be expanded here: sys.path.append('/usr/share/hal/device-manager') Second instance of the same problem in the same file: gtk.glade.bindtextdomain('hal', '${prefix}/share/locale') -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=210297 ------- Comment #1 from andreas.hanke@gmx-topmail.de 2006-10-05 11:14 MST ------- Another instance of the same problem is in /usr/share/hal/device-manager/Const.py. The line DATADIR = "${prefix}/share/hal/device-manager" must be DATADIR = "/usr/share/hal/device-manager" -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=210297 cthiel@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team- |dkukawka@novell.com |screening@forge.provo.novell| |.com | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=210297 dkukawka@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|Normal |Minor -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=210297 dkukawka@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO Info Provider| |ro@novell.com ------- Comment #2 from dkukawka@novell.com 2006-10-10 10:40 MST ------- For some reasons datadir is not expanded correctly. This line from configure: AS_AC_EXPAND(DATADIR, $datadir) results in autobuild in: datadir: ${prefix}/share if I run configure without --datadir=/usr/share. I'm not sure if this is normal, but this work local without the option. It's maybe a problem in autobuild? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=210297 ro@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED Info Provider|ro@novell.com | ------- Comment #3 from ro@novell.com 2006-10-10 16:28 MST ------- no that's nothing in autobuild. It's a question of using the most recent versions of autoconf/automake. AFAIR there was a change in that area for autoconf. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=210297 dkukawka@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED ------- Comment #4 from dkukawka@novell.com 2006-10-30 08:07 MST ------- fixed spec file for 10.2beta2 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=210297 andreas.hanke@gmx-topmail.de changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mgoppold@web.de ------- Comment #5 from andreas.hanke@gmx-topmail.de 2006-11-03 14:59 MST ------- *** Bug 217925 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=210297 andreas.hanke@gmx-topmail.de changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|Minor |Enhancement Status|RESOLVED |REOPENED Component|Basesystem |Basesystem Product|openSUSE 10.2 |openSUSE 10.3 Resolution|FIXED | Version|Alpha 5 |unspecified ------- Comment #6 from andreas.hanke@gmx-topmail.de 2006-11-16 13:46 MST ------- I found the reason of this together with a nicer fix. Therefore I re-open this bug as an enhancement for 10.3 (it is not necessary for 10.2 because the --datadir workaround in the spec file works). hal uses old version 0.1.0 of the AS_AC_EXPAND macro. This is not compatible with the new autoconf 2.60 because of stricter quoting rules. An update to version 0.2.0 of AS_AC_EXPAND fixes the problem, so that it works even without adding --datadir. IMHO this should be fixed for upstream hal as well because the problem is not SUSE specific. The latest AS_AC_EXPAND upstream is http://autostars.cvs.sourceforge.net/autostars/autostars/ac-expand/ I will attach a diff that updates hal to AS_AC_EXPAND version 0.2.0. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=210297 ------- Comment #7 from andreas.hanke@gmx-topmail.de 2006-11-16 13:47 MST ------- Created an attachment (id=105866) --> (https://bugzilla.novell.com/attachment.cgi?id=105866&action=view) update AS_AC_EXPAND to 0.2.0 Only whitespace and quoting changes, but these make a difference. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=210297 ------- Comment #8 from andreas.hanke@gmx-topmail.de 2006-11-17 10:10 MST ------- There are actually two reasons why the current code doesn't work with autoconf 2.60, and only the combination of both makes the failure visible. (1) autoconf 2.59 had only one expansion level for ${datadir}, autoconf 2.60 has two of them. autoconf 2.59: ${datadir}=${prefix}/share autoconf 2.60: ${datadir}=${datarootdir} ${datarootdir}=${prefix}/share This means that with autoconf 2.60, the eval has to be done twice. AS_AC_EXPAND does it even more radically, it uses a "while" loop that evals the variable repeatedly and does a "break" when it doesn't change any more. (2) There is a bug in the "while" loop that causes it to do the "break" earlier as intended, caused by a whitespace-related syntax error. This code is supposed to compare the left value to the right one and return 0 only if they are equal: if test "x$new_full_var"="x$full_var"; then break; fi But this does not work, "test" needs whitespaces around the equation sign. To reproduce: # test x=y ; echo $? 0 # test x = y ; echo $? 1 Therefore, the missing whitespaces cause the expansion to be aborted too early, the variable is effectively expanded just once. And this becomes visible with autoconf 2.60 because autoconf 2.60 needs the repeated expansions as a consequence of the introduction of ${datarootdir}. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=210297 dkukawka@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution| |WONTFIX ------- Comment #9 from dkukawka@novell.com 2006-12-19 10:22 MST ------- This is a WONTFIX for 10.3 because this python stuff get removed upstream in next hal realease -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
participants (1)
-
bugzilla_noreply@novell.com