[Bug 299685] New: yast2 disk expects real directories in /sys/ block while there could be symlinks
https://bugzilla.novell.com/show_bug.cgi?id=299685 Summary: yast2 disk expects real directories in /sys/block while there could be symlinks Product: openSUSE 10.3 Version: Alpha 6 Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: P5 - None Component: YaST2 AssignedTo: kasievers@novell.com ReportedBy: kasievers@novell.com QAContact: jsrain@novell.com Found By: --- /sys/block can be full of symlinks instead of directories. Everything in /sys can be validly replaced by a symlink, as long as the path is correct. Example here: /sys/block/ |-- loop0 -> ../devices/virtual/block/loop0 |-- loop1 -> ../devices/virtual/block/loop1 |-- loop2 -> ../devices/virtual/block/loop2 |-- loop3 -> ../devices/virtual/block/loop3 |-- loop4 -> ../devices/virtual/block/loop4 |-- loop5 -> ../devices/virtual/block/loop5 |-- loop6 -> ../devices/virtual/block/loop6 |-- loop7 -> ../devices/virtual/block/loop7 |-- md0 -> ../devices/virtual/block/md0 |-- sda -> ./devices/pci0000:00/0000:00:1f.2/host0/target0:0:0/0:0:0:0/block/sda |-- sdb -> ./devices/pci0000:00/0000:00:1d.7/usb1/1-2/1-2:1.0/host6/target6:0:0/6:0:0:0/block/sdb |-- sdc -> ./devices/pci0000:00/0000:00:1d.7/usb1/1-2/1-2:1.0/host6/target6:0:0/6:0:0:1/block/sdc |-- sdd -> ./devices/pci0000:00/0000:00:1d.7/usb1/1-2/1-2:1.0/host6/target6:0:0/6:0:0:2/block/sdd |-- sde -> ./devices/pci0000:00/0000:00:1d.7/usb1/1-2/1-2:1.0/host6/target6:0:0/6:0:0:3/block/sde `-- sr0 -> ./devices/pci0000:00/0000:00:1f.1/host4/target4:0:0/4:0:0:0/block/sr0 This must be fixed for upcoming changes. Please point me to the source code that does this and I will fix it and provide a patch. Thanks! -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=299685#c1 Kay Sievers <kasievers@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO Info Provider| |fehr@novell.com --- Comment #1 from Kay Sievers <kasievers@novell.com> 2007-08-12 17:39:14 MST --- I need to fix yast's /sys/block/ interaction (see description). Please point me to the source. Thanks! -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=299685#c2 Thomas Fehr <fehr@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW Info Provider|fehr@novell.com | --- Comment #2 from Thomas Fehr <fehr@novell.com> 2007-08-13 03:32:12 MST --- The sysfs access is mostly in Storage::autodetectDisks in Storage.cc and in Disk::getSysfsInfo in Disk.cc. If you point me to a kernel that has these changes included in think I can fix this easily myself. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=299685#c3 Kay Sievers <kasievers@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gregkh@novell.com Status|NEW |NEEDINFO Info Provider| |kasievers@novell.com --- Comment #3 from Kay Sievers <kasievers@novell.com> 2007-08-13 12:19:24 MST --- Thomas, it is only a patch in Greg's patch tree now, we hope to get that out into mainline soon. Let's see how we can get such a kernel to your box. :) Greg, is there an easy way to provide a kernel package that includes the stuff from your patch tree? I tried, but the current block patch doesn't apply our current kernel. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=299685 Kay Sievers <kasievers@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Info Provider|kasievers@novell.com |gregkh@novell.com -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=299685#c4 Kay Sievers <kasievers@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fehr@novell.com Status|NEEDINFO |ASSIGNED Info Provider|gregkh@novell.com | --- Comment #4 from Kay Sievers <kasievers@novell.com> 2007-08-17 11:20:09 MST --- Thomas, here: /work/built/mbuild/esk-kasievers-20 is a x86_64 kernel with the patch. Let me know if you need some other arch. Thanks! -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=299685#c5 --- Comment #5 from Thomas Fehr <fehr@novell.com> 2007-08-20 04:25:36 MST --- My test machine is not 64 bit capable, I need an i586 kernel. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=299685#c6 --- Comment #6 from Kay Sievers <kasievers@novell.com> 2007-08-20 05:09:25 MST --- Does: /work/built/mbuild/esk-kasievers-22/i386/kernel-default-2.6.23_rc3_g28e8351a-1.i586.rpm work on your box? I sent a similar change for LVM to the list: http://www.redhat.com/archives/linux-lvm/2007-August/msg00054.html Thanks! -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=299685#c7 Thomas Fehr <fehr@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |snwint@novell.com --- Comment #7 from Thomas Fehr <fehr@novell.com> 2007-08-20 06:29:08 MST --- I tried this kernel with a SL 103 installation and found that libstorage still works as before. So there are no changes needed here to support kernel 2.6.23. The fact that you do not see any disk in YaST2 is caused by hwinfo not detecting any disks (hwinfo --disk is empty). YaST2 only uses disk provided by hwinfo even if libstorage detects additional disks, since hwinfo is our central and general tool for hardware detection. So to make YaST2 see disks on such a kernel, you need to adapt hwinfo, not yast2-storage. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=299685#c8 Kay Sievers <kasievers@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO Info Provider| |kasievers@novell.com Summary|yast2 disk expects real directories in |hwinfo expects real directories in /sys/block |/sys/block while there could be symlinks |while there could be symlinks --- Comment #8 from Kay Sievers <kasievers@novell.com> 2007-08-20 06:47:41 MST --- Ah, great. Thanks Thomas. Steffen, with upcoming future changes of the kernel block subsystem moving to "struct device", hwinfo will need to handle symlinks to directories in /sys/block/ instead of expecting real directories, like most of the current sysfs already looks like. Is the involved code that needs to be changed all contained in hwinfo/src/block.c? Thanks! -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=299685#c9 --- Comment #9 from Steffen Winterfeldt <snwint@novell.com> 2007-08-20 07:17:24 MST --- Yes; read_dir(..., 'd') needs to be replaced similar to net.c::hd_scan_net(). -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=299685#c10 Kay Sievers <kasievers@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED Info Provider|kasievers@novell.com | --- Comment #10 from Kay Sievers <kasievers@novell.com> 2007-08-20 10:02:10 MST --- Created an attachment (id=158503) --> (https://bugzilla.novell.com/attachment.cgi?id=158503) try /sys/subsystem/block/ /sys/class/block/ before /sys/block/ Steffen, does this look ok to you? Seems to work here. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=299685 Kay Sievers <kasievers@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO Info Provider| |snwint@novell.com -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=299685#c11 Steffen Winterfeldt <snwint@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED Info Provider|snwint@novell.com | --- Comment #11 from Steffen Winterfeldt <snwint@novell.com> 2007-08-21 03:39:39 MST --- Looks fine; thanks. Applied patch to hwinfo. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=299685#c12 Kay Sievers <kasievers@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #12 from Kay Sievers <kasievers@novell.com> 2007-08-30 07:32:05 MST --- Looks fine. Thanks! -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com