[Bug 228523] New: ati-packager.sh doesn't work with non-English locales
https://bugzilla.novell.com/show_bug.cgi?id=228523 Summary: ati-packager.sh doesn't work with non-English locales Product: openSUSE 10.2 Version: Final Platform: All OS/Version: All Status: NEW Severity: Normal Priority: P5 - None Component: X11 3rd Party AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: andreas.hanke@gmx-topmail.de QAContact: sndirsch@novell.com CC: jarl@softace.dk ati-packager.sh does: #Retrieve the absolute path to the built package if [ $? -eq 0 ]; then PACKAGE_STR=`grep "Wrote: .*\.rpm" ${TmpPkgBuildOut}` #String containing info where the package was created PACKAGE_FILE=`expr "${PACKAGE_STR}" : 'Wrote: \(.*\)'` #Absolute path to the create package file else EXIT_CODE=1 fi But rpmbuild is translated to many languages: /usr/share/locale/cs/LC_MESSAGES/rpm.mo /usr/share/locale/da/LC_MESSAGES/rpm.mo /usr/share/locale/fi/LC_MESSAGES/rpm.mo /usr/share/locale/fr/LC_MESSAGES/rpm.mo /usr/share/locale/gl/LC_MESSAGES/rpm.mo /usr/share/locale/is/LC_MESSAGES/rpm.mo /usr/share/locale/ja/LC_MESSAGES/rpm.mo /usr/share/locale/ko/LC_MESSAGES/rpm.mo /usr/share/locale/nb/LC_MESSAGES/rpm.mo /usr/share/locale/pl/LC_MESSAGES/rpm.mo /usr/share/locale/pt/LC_MESSAGES/rpm.mo /usr/share/locale/pt_BR/LC_MESSAGES/rpm.mo /usr/share/locale/ro/LC_MESSAGES/rpm.mo /usr/share/locale/ru/LC_MESSAGES/rpm.mo /usr/share/locale/sk/LC_MESSAGES/rpm.mo /usr/share/locale/sl/LC_MESSAGES/rpm.mo /usr/share/locale/sr/LC_MESSAGES/rpm.mo /usr/share/locale/sv/LC_MESSAGES/rpm.mo /usr/share/locale/tr/LC_MESSAGES/rpm.mo Therefore, the grep regex based on the English word "Wrote" won't match if the user environment is set so that rpmbuild prints messages in a non-English language. This causes the build to fail and can be fixed by either changing the regex or by setting the locale environment to English (LC_ALL=C or similar) within the script. Bug 198125 has a proposed patch in attachment 109676, although I think that setting the locale to English within the script would be more robust. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=228523 sndirsch@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team- |atilinuxnovellbugs@ati.com |screening@forge.provo.novell| |.com | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=228523 ------- Comment #1 from andreas.hanke@gmx-topmail.de 2006-12-14 02:46 MST ------- Some scripts do actually already do this, e.g. packages/Fedora/ati-packager.sh: # Locales export LANG=C export LC_ALL=C This should be done in packages/SuSE/ati-packager.sh as well. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=228523 ------- Comment #2 from jarl@softace.dk 2006-12-14 02:52 MST ------- (In reply to comment #0)
This causes the build to fail and can be fixed by either changing the regex or by setting the locale environment to English (LC_ALL=C or similar) within the script.
Bug 198125 has a proposed patch in attachment 109676 [edit], although I think that setting the locale to English within the script would be more robust.
I completely agree that setting these env vars is a better approach. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=228523 ------- Comment #3 from jarl@softace.dk 2006-12-14 02:54 MST ------- (In reply to comment #1)
Some scripts do actually already do this, e.g. packages/Fedora/ati-packager.sh:
# Locales export LANG=C export LC_ALL=C
This should be done in packages/SuSE/ati-packager.sh as well.
Maybe to prevent future bugs poping up, just set these environment vars in all scripts... not just ati-packager.sh -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=228523 sndirsch@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED ------- Comment #4 from sndirsch@novell.com 2006-12-14 03:28 MST ------- Fixed in SUSE build scripts (ati-packager.sh) for 8.33. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=228523
Jarl Friis
participants (1)
-
bugzilla_noreply@novell.com