[Bug 848935] New: udevd complains about comments
https://bugzilla.novell.com/show_bug.cgi?id=848935 https://bugzilla.novell.com/show_bug.cgi?id=848935#c0 Summary: udevd complains about comments Classification: openSUSE Product: openSUSE 13.1 Version: RC 2 Platform: x86-64 OS/Version: Other Status: NEW Severity: Minor Priority: P5 - None Component: Basesystem AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: koenig@linux.de QAContact: qa-bugs@suse.de Found By: --- Blocker: --- udevd complain about comments at end of rules: Oct 19 09:54:01 hl systemd-udevd[28475]: invalid key/value pair in file /etc/udev/rules.d/98-avrdude.rules on line 4,starting at character 64 (' ') Oct 19 09:54:01 hl systemd-udevd[28475]: invalid key/value pair in file /etc/udev/rules.d/98-avrdude.rules on line 5,starting at character 64 (' ') Oct 19 09:54:01 hl systemd-udevd[28475]: invalid key/value pair in file /etc/udev/rules.d/98-avrdude.rules on line 6,starting at character 64 (' ') # head /etc/udev/rules.d/98-avrdude.rules KERNEL=="parport*", MODE="0666" ATTRS{idVendor}=="03eb", ATTRS{idProduct}=="2104", MODE="0666" # AVRISP mkII ATTRS{idVendor}=="03eb", ATTRS{idProduct}=="2107", MODE="0666" # AVR-Dragon ATTRS{idVendor}=="03eb", ATTRS{idProduct}=="2103", MODE="0666" # JTAG ICE mkII ATTRS{idVendor}=="03eb", ATTRS{idProduct}=="2106", MODE="0666" # STK600 ATTRS{idVendor}=="16c0", ATTRS{idProduct}=="05dc", MODE="0666" # USBASP (www.fischl.de) ATTRS{idVendor}=="03eb", ATTRS{idProduct}=="c7b4", MODE="0666" # USBASP old VID/PID ATTRS{idVendor}=="03eb", ATTRS{idProduct}=="2ffa", MODE="0666" # AT90USB I see those messages first at October 19, after installing udev 208-2.1: # grep 'install|udev|208' /var/log/zypp/history 2013-10-12 07:05:46|install|udev|208-1.1|x86_64||repo-oss|87424774c55c3991dddb14df4575ef156742d1782bfcf682428d3c43c37aa2e2| 2013-10-19 10:05:09|install|udev|208-2.1|x86_64||gwdg-oss|240977df9712f6a4886b6f0a98a9a8c58d2df2f4aff822fc3bab498e5ff6c7cf| 2013-10-22 09:30:50|install|udev|208-3.1|x86_64||repo-oss|031e93901f2fa906e099d4077dd5c5af12633e9eb38755405813d7cb9938f7f1| 2013-10-23 17:36:06|install|udev|208-4.7.1|x86_64||repo-update|bf02f6213573acfa8dfd1ae3e81b4c977e87dccefaffab21304f07b25b7375a7| 2013-10-25 15:40:44|install|udev|208-3.1|x86_64||gwdg-oss|031e93901f2fa906e099d4077dd5c5af12633e9eb38755405813d7cb9938f7f1| 2013-10-26 11:52:00|install|udev|208-4.1|x86_64||repo-oss|4368b53ca26e959a771cb0dc82e0bdae5a1eb03887db22a2ea63d5c1d5746f73| looks like udev version 208-1.1 did not show those messages. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=848935
https://bugzilla.novell.com/show_bug.cgi?id=848935#c
zhang jiajun
https://bugzilla.novell.com/show_bug.cgi?id=848935
https://bugzilla.novell.com/show_bug.cgi?id=848935#c1
Dr. Werner Fink
https://bugzilla.novell.com/show_bug.cgi?id=848935
https://bugzilla.novell.com/show_bug.cgi?id=848935#c2
--- Comment #2 from Frederic Crozat
https://bugzilla.novell.com/show_bug.cgi?id=848935
https://bugzilla.novell.com/show_bug.cgi?id=848935#c3
Harald Koenig
A few patches for udev have been added since version update to v208 ... maybe one had caused this or in the meanwhile one if the patches fix this.
Please try out latest systemd from openSUSE:Factory to see if this one is alrady fixed.
udev update from last night still shows those warnings rpm -q udev udev-208-5.1.x86_64 Nov 5 21:35:20 hl systemd[1]: Started udev Kernel Device Manager. Nov 5 22:35:54 hl systemd-udevd[7405]: invalid key/value pair in file /etc/udev/rules.d/98-avrdude.rules on line 4,starting at character 64 (' ') Nov 5 22:35:54 hl systemd-udevd[7405]: invalid key/value pair in file /etc/udev/rules.d/98-avrdude.rules on line 5,starting at character 64 (' ') Nov 5 22:35:54 hl systemd-udevd[7405]: invalid key/value pair in file /etc/udev/rules.d/98-avrdude.rules on line 6,starting at character 64 (' ') BTW, those new messages are *good* because they also showed a real typo in the udev rules from gpsd -- see bug #848936 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=848935
https://bugzilla.novell.com/show_bug.cgi?id=848935#c4
Dr. Werner Fink
https://bugzilla.novell.com/show_bug.cgi?id=848935
https://bugzilla.novell.com/show_bug.cgi?id=848935#c5
Stefan Dirsch
https://bugzilla.novell.com/show_bug.cgi?id=848935
https://bugzilla.novell.com/show_bug.cgi?id=848935#c6
Reinhard Max
https://bugzilla.novell.com/show_bug.cgi?id=848935
https://bugzilla.novell.com/show_bug.cgi?id=848935#c7
Reinhard Max
https://bugzilla.novell.com/show_bug.cgi?id=848935
https://bugzilla.novell.com/show_bug.cgi?id=848935#c8
Stefan Dirsch
https://bugzilla.novell.com/show_bug.cgi?id=848935
https://bugzilla.novell.com/show_bug.cgi?id=848935#c9
--- Comment #9 from Reinhard Max
https://bugzilla.novell.com/show_bug.cgi?id=848935
https://bugzilla.novell.com/show_bug.cgi?id=848935#c
Dr. Werner Fink
https://bugzilla.novell.com/show_bug.cgi?id=848935
https://bugzilla.novell.com/show_bug.cgi?id=848935#c13
Robert Milasan
https://bugzilla.novell.com/show_bug.cgi?id=848935
https://bugzilla.novell.com/show_bug.cgi?id=848935#c14
Reinhard Max
https://bugzilla.novell.com/show_bug.cgi?id=848935
https://bugzilla.novell.com/show_bug.cgi?id=848935#c15
--- Comment #15 from Robert Milasan
https://bugzilla.novell.com/show_bug.cgi?id=848935
https://bugzilla.novell.com/show_bug.cgi?id=848935#c16
--- Comment #16 from Reinhard Max
I do not know when it was removed or if ever was supported.
It definitely was supported, or at least udev didn't complain about it. See the initial description for Harald's analysis of when the udev package started producing these complaints.
Will try to check git for this, but wont promise anything.
Thanks. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=848935
https://bugzilla.novell.com/show_bug.cgi?id=848935#c17
--- Comment #17 from Robert Milasan
https://bugzilla.novell.com/show_bug.cgi?id=848935
https://bugzilla.novell.com/show_bug.cgi?id=848935#c18
--- Comment #18 from Frederic Crozat
Seems that this 'error' or 'warning' was added with commit e736cf3582c03273f95bc6f97245b04783fd626b (systemd git).
Not sure if I should revert this or not :)
We should keep it, before it, the lines were silently ignored.. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=848935
https://bugzilla.novell.com/show_bug.cgi?id=848935#c19
Robert Milasan
https://bugzilla.novell.com/show_bug.cgi?id=848935
https://bugzilla.novell.com/show_bug.cgi?id=848935#c20
--- Comment #20 from Dr. Werner Fink
https://bugzilla.novell.com/show_bug.cgi?id=848935
https://bugzilla.novell.com/show_bug.cgi?id=848935#c21
--- Comment #21 from Reinhard Max
We should keep it, before it, the lines were silently ignored..
I am pretty sure they weren't ignored before. (In reply to comment #20)
Hmmm ... I'd like to suggest that this may introduce other problems as such a rule is not portable anyomore [...]
Portable to what? Of course I don't mean to change this only for our systemd/udev, but also upstream. What's wrong with allowing rule writers to place their comments where they see fit? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=848935
https://bugzilla.novell.com/show_bug.cgi?id=848935#c22
--- Comment #22 from Robert Milasan
https://bugzilla.novell.com/show_bug.cgi?id=848935
https://bugzilla.novell.com/show_bug.cgi?id=848935#c23
--- Comment #23 from Reinhard Max
https://bugzilla.novell.com/show_bug.cgi?id=848935
https://bugzilla.novell.com/show_bug.cgi?id=848935#c24
--- Comment #24 from Robert Milasan
http://bugzilla.novell.com/show_bug.cgi?id=848935
http://bugzilla.novell.com/show_bug.cgi?id=848935#c25
Reinhard Max
participants (1)
-
bugzilla_noreply@novell.com