[Bug 524202] New: dmraid-1.0.0.rc15-4.32: possible missing call to closedir - openSUSE Bugs - openSUSE Mailing Lists

newer
[Bug 540638] New: Time is...

[Bug 524202] New: dmraid-1.0.0.rc15-4.32: possible missing call to closedir

older
[Bug 430906] dmraid installation...

bugzilla_noreply＠novell.com

22 Jul 2009 22 Jul '09

10:12

http://bugzilla.novell.com/show_bug.cgi?id=524202 Summary: dmraid-1.0.0.rc15-4.32: possible missing call to closedir Classification: openSUSE Product: openSUSE 11.2 Version: Factory Platform: All OS/Version: openSUSE 11.1 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Found By: --- I just had a look at factory package dmraid-1.0.0.rc15-4.32 For source code file dmraid/1.0.0.rc15/libdmraid-events/libdmraid-events.c, around line 141 is the source code for the function _repopulate. I notice the following code if((dir = opendir(test_path))) but no matching call to closedir. This looks like a resource leak to me. Suggest code rework. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Reply

Sign in to reply online Use email software

Show replies by date

bugzilla_noreply＠novell.com

22 Jul 22 Jul

11:46

New subject: [Bug 524202] dmraid-1.0.0.rc15-4.32: possible missing call to closedir

http://bugzilla.novell.com/show_bug.cgi?id=524202 Marcus Meissner changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team-screening@forge.pr |hvogel@novell.com |ovo.novell.com | -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Reply

Sign in to reply online Use email software

bugzilla_noreply＠novell.com

24 Aug 24 Aug

22:21

New subject: [Bug 524202] dmraid-1.0.0.rc15-4.32: possible missing call to closedir

http://bugzilla.novell.com/show_bug.cgi?id=524202 User dcb314@hotmail.com added comment http://bugzilla.novell.com/show_bug.cgi?id=524202#c1 David Binderman changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - None |P3 - Medium --- Comment #1 from David Binderman 2009-08-24 16:21:50 MDT --- 2. Same package, same source code file, function register_device, same problem, same local variable name "dir". 3. Also, in the same file, function _get_dev_names is a dodgy looking call to snprintf snprintf(dm_num, sizeof(num), "%d", num); but char dm_num[2]; and int num = 0; so writing up to 4 or 8 characters into a 2 byte slot looks dodgy. Any chance of any progress on this bug report ? It's been sitting idle for over a month. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Reply

Sign in to reply online Use email software

bugzilla_noreply＠novell.com

17 Oct 17 Oct

14:54

New subject: [Bug 524202] dmraid-1.0.0.rc15-4.32: possible missing call to closedir

http://bugzilla.novell.com/show_bug.cgi?id=524202 User rguenther@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=524202#c2 --- Comment #2 from Richard Guenther 2009-10-17 08:54:37 MDT --- David, in case the issues are not introduced by a patch local to openSUSE please report the issues upstream. Packagers, please do not add openSUSE-local patches to fix this kind of errors but forward the bugs upstream and close the bugs as RESOLVED UPSTREAM. Note that it is perfectly fine to have "resource leaks" at the end of a program as the kernel will clean up for you. Manually freeing them only increases binary size and runtime. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Reply

Sign in to reply online Use email software

bugzilla_noreply＠novell.com

20 Nov 20 Nov

10:10

New subject: [Bug 524202] dmraid-1.0.0.rc15-4.32: possible missing call to closedir

http://bugzilla.novell.com/show_bug.cgi?id=524202 http://bugzilla.novell.com/show_bug.cgi?id=524202#c Hendrik Vogelsang changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|hvogel@novell.com |vojtech@novell.com -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Reply

Sign in to reply online Use email software

bugzilla_noreply＠novell.com

4 Dec 4 Dec

13:59

New subject: [Bug 524202] dmraid-1.0.0.rc15-4.32: possible missing call to closedir

http://bugzilla.novell.com/show_bug.cgi?id=524202 http://bugzilla.novell.com/show_bug.cgi?id=524202#c Jiri Kosina changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|vojtech@novell.com |nfbrown@novell.com -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Reply

Sign in to reply online Use email software

bugzilla_noreply＠novell.com

10 Dec 10 Dec

01:46

New subject: [Bug 524202] dmraid-1.0.0.rc15-4.32: possible missing call to closedir

http://bugzilla.novell.com/show_bug.cgi?id=524202 http://bugzilla.novell.com/show_bug.cgi?id=524202#c3 Neil Brown changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #3 from Neil Brown 2009-12-10 01:46:11 UTC --- Thanks for the report Richard. Did you manage to find an 'upstream' to report this too? I couldn't find anywhere obvious. I'll ask around and see what I can find out. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Reply

Sign in to reply online Use email software

bugzilla_noreply＠novell.com

11 Dec 11 Dec

04:50

New subject: [Bug 524202] dmraid-1.0.0.rc15-4.32: possible missing call to closedir

http://bugzilla.novell.com/show_bug.cgi?id=524202 http://bugzilla.novell.com/show_bug.cgi?id=524202#c4 Neil Brown changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |UPSTREAM --- Comment #4 from Neil Brown 2009-12-11 04:50:26 UTC --- I have sent patches for these bugs (plus a memory leak) upstream to dm-devel@redhat.com. https://www.redhat.com/archives/dm-devel/2009-December/msg00080.html and following. As they are non-critical bugs I will now resolve this patch as 'UPSTREAM'. Thanks for the report. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Reply

Sign in to reply online Use email software

5261

Age (days ago)

5403

Last active (days ago)

Download

7 comments

1 participants

tags

participants (1)

bugzilla_noreply＠novell.com