[Bug 1177175] New: createrepo_c skips rpms without failing
http://bugzilla.opensuse.org/show_bug.cgi?id=1177175 Bug ID: 1177175 Summary: createrepo_c skips rpms without failing Classification: openSUSE Product: openSUSE Tumbleweed Version: Current Hardware: Other OS: Other Status: NEW Severity: Critical Priority: P5 - None Component: Development Assignee: screening-team-bugs@suse.de Reporter: adrian.schroeter@suse.com QA Contact: qa-bugs@suse.de Found By: --- Blocker: --- We have since createrepo_c update to 0.16 many broken repositories in OBS, because createrepo_c may skip rpms and is not failing. This leads to inconsistent repostiories which basically break installations. This is not visible to OBS and neither to the users. example lines of createrepo_c: C_CREATEREPOLIB: Critical: Cannot dump XML for rubygem-parser-2_3 (997508f2146125fd1ad896ec7cb6fe94d27fef3ceccb74c339c415e2d76f72e8): Forbidden control chars found (ASCII values <32 except 9, 10 and 13). -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1177175 Guillaume GARDET <guillaume.gardet@arm.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |guillaume.gardet@arm.com -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1177175 Ismail Dönmez <idonmez@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |idonmez@suse.com -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1177175 http://bugzilla.opensuse.org/show_bug.cgi?id=1177175#c2 --- Comment #2 from Adrian Schröter <adrian.schroeter@suse.com> --- still many non factory repos are affected. We get more and more reports, and the log files from last hours had 400 hits here inconsistent repos went out. just not publishing at all without being able to show an error is also not a good idea (so far all createrepo errors were admin errors, not user errors). Will discuss if we need to fork createrepo_c or how to handle it... -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1177175 http://bugzilla.opensuse.org/show_bug.cgi?id=1177175#c3 Frank Schreiner <FSchreiner@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |FSchreiner@suse.com --- Comment #3 from Frank Schreiner <FSchreiner@suse.com> --- As Fabian already explained - this is not a bug - its a feature. I would also not recommend to turn "--error-exit-val" on globally in OBS - this would put all the pressure to fix broken packages on the release managers. I already wrote some patches for the upstream rpmlint: https://github.com/rpm-software-management/rpmlint/pull/355 but it seems that these patches are not in the opensuse version. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1177175 http://bugzilla.opensuse.org/show_bug.cgi?id=1177175#c4 --- Comment #4 from Adrian Schröter <adrian.schroeter@suse.com> --- For tumbleweed we use --error-exit-val already indeed. So the ftp tree is not affected, just repositories build on build.opensuse.org. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1177175 http://bugzilla.opensuse.org/show_bug.cgi?id=1177175#c5 --- Comment #5 from Adrian Schröter <adrian.schroeter@suse.com> --- after some more investigation, the problem is not really new, just multiple bugreports reach us atm. Given the amount publisher errors in last hours we need to let publishing fail, but we need to transport this information also back to the user. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1177175 http://bugzilla.opensuse.org/show_bug.cgi?id=1177175#c6 Neal Gompa <ngompa13@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ngompa13@gmail.com --- Comment #6 from Neal Gompa <ngompa13@gmail.com> --- One thing you might want to consider for the future is having createrepo_c create the repodata per package, and use mergerepo_c to pull them together in the end for the repository. This is how Koji does it and that allows you to have "publish logs" on a per-package basis. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1177175 http://bugzilla.opensuse.org/show_bug.cgi?id=1177175#c7 Frank Schreiner <FSchreiner@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #7 from Frank Schreiner <FSchreiner@suse.com> --- (In reply to Neal Gompa from comment #6)
One thing you might want to consider for the future is having createrepo_c create the repodata per package, and use mergerepo_c to pull them together in the end for the repository. This is how Koji does it and that allows you to have "publish logs" on a per-package basis.
I think we could also achieve this with a log-file from createrepo_c's output - but we have no channel to display it to the user. The messages end up in a logfile on the server where only the admin see's it. The user gets no feedback what went wrong. But this is a different story that needs to be fixed on OBS side. Will close the bug as this is no bug in createrepo_c. -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠suse.com