http://bugzilla.suse.com/show_bug.cgi?id=1119674 http://bugzilla.suse.com/show_bug.cgi?id=1119674#c1 --- Comment #1 from Dr. Werner Fink --- The last change was from Fri Dec 16 12:40:20 UTC 2016 - psimons@suse.com and there are more packages with spaces in their names, e.g. cmake ... the only difference I see is: endless-sky.spec uses the option -s whereas cmake.spec does not. Also the macro seems to be correct %fdupes(s) \ _target=""; \ _symlinks=0; \ %{-s:_symlinks=1;} \ fdupes -q -p -n -H -o name -r %1 | \ while read _file; do \ if test -z "$_target" ; then \ _target="$_file"; \ else \ if test -z "$_file" ; then \ _target=""; \ continue ; \ fi ; \ if test "$_symlinks" = 1; then \ ln -sf "${_target#%{buildroot}}" "$_file"; \ else \ ln -f "$_target" "$_file"; \ fi ;\ fi ; \ done \ %{nil} that is it read line by line from fdupes output and does double quote this lines aka file names for both symbolic and hard links. -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=1119674 http://bugzilla.suse.com/show_bug.cgi?id=1119674#c3 Sebastian Parschauer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|%fdupes macro breaks on |"%fdupes -s" breaks if |spaces in file names |space in target file name | |without space in link file | |name --- Comment #3 from Sebastian Parschauer --- It is strange that it works if both, target and link, have spaces in their file names and it works if both have no spaces in file names. The bug seems to be limited to the case that the target file name has a space but the link doesn't have one. -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=1119674 http://bugzilla.suse.com/show_bug.cgi?id=1119674#c5 --- Comment #5 from Sebastian Parschauer --- From

https://build.opensuse.org/build/openSUSE:Leap:15.0/standard/x86_64/endless-...

[ 237s] calling /usr/lib/rpm/brp-suse.d/brp-25-symlink [ 237s] INFO: relinking /usr/share/endless-sky/images/star/g0.png -> ../_menu/g0.png (was /usr/share/endless-sky/images/_menu/g0.png) [ 237s] /usr/lib/rpm/brp-suse.d/brp-25-symlink: line 163: test: .//usr/share/endless-sky/images/projectile/finisher: binary operator expected [ 237s] INFO: relinking /usr/share/endless-sky/images/projectile/finisher-0.png -> finisher (was /usr/share/endless-sky/images/projectile/finisher activating-1.png) [ 237s] /usr/lib/rpm/brp-suse.d/brp-25-symlink: line 163: test: .//usr/share/endless-sky/images/effect/antimatter: binary operator expected [ 237s] INFO: relinking /usr/share/endless-sky/images/effect/antimatter spark+2.png -> antimatter (was /usr/share/endless-sky/images/effect/antimatter spark+0.png) [ 237s] rm: cannot remove './/usr/share/endless-sky/images/effect/antimatter': No such file or directory [ 237s] rm: cannot remove 'spark+2.png': No such file or directory ...

-- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=1119674 http://bugzilla.suse.com/show_bug.cgi?id=1119674#c7 --- Comment #7 from Sebastian Parschauer --- Created attachment 792888 --> http://bugzilla.suse.com/attachment.cgi?id=792888&action=edit Patch to fix the spaces by adding missing quotes I've put brp-check-suse and endless-sky into the same branch project and added this patch to brp-check-suse. It adds the missing quoting. Now all symlinks are correct. @Rüdiger: Please consider including. TIA -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=1119674 http://bugzilla.suse.com/show_bug.cgi?id=1119674#c8 --- Comment #8 from Sebastian Parschauer --- I see, only Leap 15 is affected. Stefan Brüns fixed Factory and Tumbleweed already. -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=1119674 http://bugzilla.suse.com/show_bug.cgi?id=1119674#c9 --- Comment #9 from Sebastian Parschauer --- Same issue for Leap 15.1. -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=1119674 Swamp Workflow Management changed: What |Removed |Added ---------------------------------------------------------------------------- Whiteboard| |obs:running:9374:moderate -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=1119674 Swamp Workflow Management changed: What |Removed |Added ---------------------------------------------------------------------------- Whiteboard|obs:running:9374:moderate | -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=1119674 http://bugzilla.suse.com/show_bug.cgi?id=1119674#c13 --- Comment #13 from Ludwig Nussel --- mind filing a pull request at https://github.com/openSUSE/brp-check-suse ? -- You are receiving this mail because: You are on the CC list for the bug.