[Bug 716718] New: kiwi: set the flags instead of the partition types while using parted in kiwi.
https://bugzilla.novell.com/show_bug.cgi?id=716718 https://bugzilla.novell.com/show_bug.cgi?id=716718#c0 Summary: kiwi: set the flags instead of the partition types while using parted in kiwi. Classification: openSUSE Product: openSUSE.org Version: unspecified Platform: Other OS/Version: RHEL 5 Status: NEW Severity: Normal Priority: P5 - None Component: System Imaging AssignedTo: ms@suse.com ReportedBy: praveen_paladugu@dell.com QAContact: adrian@suse.com Found By: --- Blocker: --- Created an attachment (id=449844) --> (http://bugzilla.novell.com/attachment.cgi?id=449844) Complete build log with failure User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:2.0.1) Gecko/20100101 Firefox/4.0.1 While creating partitions with lvm support, kiwi uses "set xx type 0x83". This way to setting the partition properties seems to be SUSE distribution specific. The vanilla version of parted doesn't support such features. So, it would better to set the flags instead of setting the partition types with Hex IDs. For example, to enable lvm capabilities "set xx lvm on" will work. Building RHEL/CentOS based VMX images fails because of this. Reproducible: Always Steps to Reproduce: 1. Create a vmx image using the JeOS template and vmxboot/rhel-05.4 boot config. 2. Enable lvm support with <systemdisk> element in the system image configuration. 3. Initiate a kiwi build. Actual Results: the build fails with the following messages: Sep-07 00:38:03 <3> : Expected a directory at /tmp/kiwiboot.HX9283/image. Specify a directory as the configuration base. failed Expected Results: the build to pass and create a bootable VMX image. Please note this failure is only seen while using the lvm configuration in the VMX images. The base vmx configuration works just fine. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=716718 https://bugzilla.novell.com/show_bug.cgi?id=716718#c1 Marcus Schaefer <ms@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #1 from Marcus Schaefer <ms@suse.com> 2011-09-08 15:58:49 UTC --- will take care of this asap -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=716718 https://bugzilla.novell.com/show_bug.cgi?id=716718#c2 --- Comment #2 from Marcus Schaefer <ms@suse.com> 2011-09-08 16:00:52 UTC --- JFI The settings in createPartedInput will come into picture during boot. The failure I am noticing is during build time. At the very least setStorageParition function should also be updated. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=716718 https://bugzilla.novell.com/show_bug.cgi?id=716718#c3 Marcus Schaefer <ms@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO InfoProvider| |praveen_paladugu@dell.com --- Comment #3 from Marcus Schaefer <ms@suse.com> 2011-09-09 14:50:57 UTC --- I added the type patch to parted, maybe this solves the issue and we don't have to touch the kiwi code: http://download.opensuse.org/repositories/home:/sax2:/kiwi-rhel/ Would you mind to test this ? Thanks -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=716718 https://bugzilla.novell.com/show_bug.cgi?id=716718#c4 --- Comment #4 from praveen paladugu <praveen_paladugu@dell.com> 2011-09-09 17:43:31 UTC --- This version of parted works. I had to add the following fix to get the build going: diff -up kiwi/modules/KIWIBoot.pm.old kiwi/modules/KIWIBoot.pm --- kiwi/modules/KIWIBoot.pm.old 2011-09-09 12:11:58.836264636 -0500 +++ kiwi/modules/KIWIBoot.pm 2011-09-09 12:12:17.418032332 -0500 @@ -5270,7 +5270,7 @@ sub __getPartID { my $fd = new FileHandle; if ($fd -> open ("parted -m $disk print | cut -f1,7 -d:|")) { while (my $line = <$fd>) { - if ($line =~ /^(\d):$flag/) { + if ($line =~ /^(\d):[ ,]*$flag/) { return $1; } } With the value of line = "2:, , , , , lvm, , , , type=8e, , ;" the pattern missed out the spaces and commas, while searching a partition with "lvm" flag. No other fixes to kiwi are necessary. Also it would be better to push the type patch upstream, so that other distributions can pick it up eventually. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=716718 https://bugzilla.novell.com/show_bug.cgi?id=716718#c5 Marcus Schaefer <ms@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |RESOLVED InfoProvider|praveen_paladugu@dell.com | Resolution| |FIXED --- Comment #5 from Marcus Schaefer <ms@suse.com> 2011-09-12 14:42:40 UTC --- I added that patch and moved the rhel packages to this repo http://download.opensuse.org/repositories/Virtualization:/Appliances:/rhel-0... -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply@novell.com