https://bugzilla.novell.com/show_bug.cgi?id=664941 https://bugzilla.novell.com/show_bug.cgi?id=664941#c Vitezslav Cizek changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - None |P4 - Low Status|NEW |ASSIGNED CC| |vcizek@novell.com -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=664941 https://bugzilla.novell.com/show_bug.cgi?id=664941#c3 --- Comment #3 from Michal Kubeček 2011-03-02 13:28:08 UTC --- Created an attachment (id=417066) --> (http://bugzilla.novell.com/attachment.cgi?id=417066) proposed fix The problem is caused by script /etc/X11/xdm/sys.xsession which tests whether ssh-agent is running using checkproc command (line 66). However, in this script checkproc is overriden by a function which in fact runs /sbin/checkproc -k so that it attempts to kill ssh-agent rather than check for it. The same happens for gpg-agent on lines 106 and 132. Proposed fix is attached (but easier way would be to simply remove definition of checkproc function). -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=664941 https://bugzilla.novell.com/show_bug.cgi?id=664941#c Stefan Dirsch changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Security |X.Org QAContact|qa@suse.de |xorg-maintainer-bugs@forge. | |provo.novell.com -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=664941 https://bugzilla.novell.com/show_bug.cgi?id=664941#c6 Dr. Werner Fink changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED CC| |werner@novell.com InfoProvider|werner@novell.com | --- Comment #6 from Dr. Werner Fink 2011-03-03 08:18:13 UTC --- The option -k of checkproc does *not* kill anything, it only use an other approach for searching for a process as well as using other exit codes, see manual page of checkproc(8): -k This option makes checkproc work like killproc(8) which changes the operation mode, e.g. the exit status of the program will be that of killproc(8). Without this option, checkproc works like startproc (8) and finds all processes with an executable that matches the specified pathname, even if a given pid file (see option -p) isn't up-to-date. Nevertheless it uses its own exit status (see section EXIT CODES). Just checked this: /suse/werner> sudo checkproc -v /usr/bin/ssh-agent 11819 /suse/werner> echo $? 0 /suse/werner> sudo checkproc -kv /usr/bin/ssh-agent 11819 /suse/werner> echo $? 0 /suse/werner> sudo checkproc -v /bin/true /suse/werner> echo $? 3 /suse/werner> sudo checkproc -kv /bin/true /suse/werner> echo $? 7 There I do not see how the supposed fix does change the behaviour. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=664941 https://bugzilla.novell.com/show_bug.cgi?id=664941#c8 --- Comment #8 from Michal Kubeček 2011-03-03 11:22:11 UTC --- I have found two problems: (1) When called from sys.xsession, checkproc's calls to stat() and readlinkat() on /proc/.../exe fail with EACCES. (2) When checkproc is called with -p option and PID (number) instead of a filename, it first fills the "remember" list and discards pid_file variable. But if -k option was given, the else branch in block after "Do main work" comment (lines 223-229) acts as if no PID was given. In such case it calls pidof() which discards "remember" list and fails if readlinkat() on "/proc/.../exe" fails with EACCES. Combination of (1) and (2) is the reason why '/sbin/checkproc -p $SSH_AGENT_PID' finds the process and '/sbin/checkproc -k -p $SSH_AGENT_PID' does not. I don't know neither the reason of (1) nor whether it is a bug or not but (2) is IMHO a bug in checkproc: with -k option, numeric argument of -p is ignored. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=664941 https://bugzilla.novell.com/show_bug.cgi?id=664941#c10 --- Comment #10 from Michal Kubeček 2011-03-03 13:29:28 UTC --- Created an attachment (id=417337) --> (http://bugzilla.novell.com/attachment.cgi?id=417337) /proc subdir contents Well, this is quite strange: even if ssh-agents runs with id of normal user (UID, EUID and FSUID), most of its /proc subdirectory is still owned by root and links cwd, exe root cannot be read. However, the same is true on 11.3. The only difference seems to be in pidof() where on 11.3 (killproc-2.16) pidof() can succeed even if exe link is unreadable while on 11.4 (killproc-2.19) it fails. Anyway, I still think that the main problem here is what I mentioned in comment #8: checkproc ignores numeric parameter of -p if -k is given so that it tries to go through all processes (which is in fact against the sense of -k option). -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=664941 https://bugzilla.novell.com/show_bug.cgi?id=664941#c12 --- Comment #12 from Dr. Werner Fink 2011-03-03 13:53:58 UTC --- Created an attachment (id=417345) --> (http://bugzilla.novell.com/attachment.cgi?id=417345) sysvinit-tools-2.88-37.3.x86_64.rpm .. now please give the fixed version a try. With this checkproc should find the users processes even with -k. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=664941 https://bugzilla.novell.com/show_bug.cgi?id=664941#c13 --- Comment #13 from Michal Kubeček 2011-03-03 14:18:36 UTC --- It works for me. According to strace, checkproc still goes through all /proc/* (unlike without -k) but it identifies the process correctly (and does not identify it if different PID is given). -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=664941 https://bugzilla.novell.com/show_bug.cgi?id=664941#c14 Dr. Werner Fink changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO InfoProvider| |maintenance@opensuse.org --- Comment #14 from Dr. Werner Fink 2011-03-10 14:29:25 UTC --- submitted a fixed version of sysvinit for this bug #664941 and bug #677435 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=664941 https://bugzilla.novell.com/show_bug.cgi?id=664941#c16 Swamp Workflow Management changed: What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard| |maint:running:39348:low --- Comment #16 from Swamp Workflow Management 2011-03-14 15:32:31 UTC --- The SWAMPID for this issue is 39348. This issue was rated as low. Please submit fixed packages until 2011-04-11. Also create a patchinfo file using this link: https://swamp.suse.de/webswamp/wf/39348 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=664941 https://bugzilla.novell.com/show_bug.cgi?id=664941#c18 Dr. Werner Fink changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #18 from Dr. Werner Fink 2011-03-15 09:29:48 UTC --- fixed -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=664941 https://bugzilla.novell.com/show_bug.cgi?id=664941#c20 Swamp Workflow Management changed: What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard|maint:running:39348:low |maint:running:39348:low | |maint:released:11.4:39351 --- Comment #20 from Swamp Workflow Management 2011-03-22 13:25:05 UTC --- Update released for: sysvinit, sysvinit-debuginfo, sysvinit-debugsource, sysvinit-tools, sysvinit-tools-debuginfo Products: openSUSE 11.4 (debug, i586, x86_64) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.