[Bug 658509] New: _FORTIFY_SOURCE wrappers for memmove and bcopy are wrong

newer
[Bug 465005] BuildService: build...

bugzilla_noreply＠novell.com

9 Dec 2010 9 Dec '10

12:18

https://bugzilla.novell.com/show_bug.cgi?id=658509 https://bugzilla.novell.com/show_bug.cgi?id=658509#c0 Summary: _FORTIFY_SOURCE wrappers for memmove and bcopy are wrong Classification: openSUSE Product: openSUSE 11.4 Version: Factory Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: P5 - None Component: Basesystem AssignedTo: rguenther@novell.com ReportedBy: rguenther@novell.com QAContact: qa@suse.de CC: pbaudis@novell.com Found By: Development Blocker: --- extern __inline __attribute__ ((__always_inline__)) __attribute__ ((__artificial__)) void * __attribute__ ((__nothrow__)) memmove (void *__restrict __dest, __const void *__restrict __src, size_t __len) { return __builtin___memmove_chk (__dest, __src, __len, __builtin_object_size (__dest, 0)); } and the bcopy variant wrongly use restrict qualified arguments. This leads the optimizer in newer GCC to the conclusion that the memory regions pointed to by dest and src do not overlap. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Show replies by date

bugzilla_noreply＠novell.com

9 Dec 9 Dec

13:32

New subject: [Bug 658509] _FORTIFY_SOURCE wrappers for memmove and bcopy are wrong

https://bugzilla.novell.com/show_bug.cgi?id=658509 https://bugzilla.novell.com/show_bug.cgi?id=658509#c1 Cristian Rodríguez changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |crrodriguez@opensuse.org --- Comment #1 from Cristian Rodríguez 2010-12-09 13:32:11 UTC --- Just wondering, from which GCC version this happends ? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

13:33

New subject: [Bug 658509] _FORTIFY_SOURCE wrappers for memmove and bcopy are wrong

https://bugzilla.novell.com/show_bug.cgi?id=658509 https://bugzilla.novell.com/show_bug.cgi?id=658509#c2 --- Comment #2 from Richard Guenther 2010-12-09 13:33:31 UTC --- It happens for GCC 4.6. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

31 Dec 31 Dec

10:24

New subject: [Bug 658509] _FORTIFY_SOURCE wrappers for memmove and bcopy are wrong

https://bugzilla.novell.com/show_bug.cgi?id=658509 https://bugzilla.novell.com/show_bug.cgi?id=658509#c3 Stefan Krah changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stefan-usenet@bytereef.org --- Comment #3 from Stefan Krah 2010-12-31 10:24:46 UTC --- My Python cdecimal module is affected by this bug on openSUSE 11.3 with gcc-4.6. C-extensions use the same flags that Python has been compiled with, and in this case that includes -D_FORTIFY_SOURCE=2. For printing a result, cdecimal wraps the result string with "Decimal('...')". In the process, memmove() is used. Here are the incorrect results with the buggy -D_FORTIFY_SOURCE=2:

...

...
...
from cdecimal import * Decimal(111111111222222222333333333) Decimal('111111111111111111111111111')

I can work around this by specifying -U_FORTIFY_SOURCE in setup.py:

...

...
...
from cdecimal import * Decimal(111111111222222222333333333) Decimal('111111111222222222333333333')

-- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

12:06

New subject: [Bug 658509] _FORTIFY_SOURCE wrappers for memmove and bcopy are wrong

https://bugzilla.novell.com/show_bug.cgi?id=658509 https://bugzilla.novell.com/show_bug.cgi?id=658509#c4 --- Comment #4 from Marcus Meissner 2010-12-31 12:06:49 UTC --- better way is of course to patch the glibc headers. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

13:01

New subject: [Bug 658509] _FORTIFY_SOURCE wrappers for memmove and bcopy are wrong

https://bugzilla.novell.com/show_bug.cgi?id=658509 https://bugzilla.novell.com/show_bug.cgi?id=658509#c5 --- Comment #5 from Stefan Krah 2010-12-31 13:01:29 UTC ---

...

better way is of course to patch the glibc headers.

Well yes, but until those patches are widely in use, I'm going to play it safe and make -U_FORTIFY_SOURCE the default for cdecimal. The problem is that users will blame the application and not their toolchain. Will the glibc patches be backported to 11.3? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

13:32

New subject: [Bug 658509] _FORTIFY_SOURCE wrappers for memmove and bcopy are wrong

https://bugzilla.novell.com/show_bug.cgi?id=658509 https://bugzilla.novell.com/show_bug.cgi?id=658509#c6 --- Comment #6 from Marcus Meissner 2010-12-31 13:32:25 UTC --- as this seems only gcc 4.6, whihc is not yet released, please put pressure on people to fix their glibcs. I also think we should release a fixed glibc to 11.3 at least, yes. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

13:33

New subject: [Bug 658509] _FORTIFY_SOURCE wrappers for memmove and bcopy are wrong

https://bugzilla.novell.com/show_bug.cgi?id=658509 https://bugzilla.novell.com/show_bug.cgi?id=658509#c7 --- Comment #7 from Marcus Meissner 2010-12-31 13:33:14 UTC --- .. and add a testcase to your python code that triggers on your code example above (aka bad compiles) with big fat warning :) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

7 Jan 7 Jan

22:46

New subject: [Bug 658509] _FORTIFY_SOURCE wrappers for memmove and bcopy are wrong

https://bugzilla.novell.com/show_bug.cgi?id=658509 https://bugzilla.novell.com/show_bug.cgi?id=658509#c8 --- Comment #8 from Stefan Krah 2011-01-07 22:46:58 UTC ---

...

as this seems only gcc 4.6, whihc is not yet released, please put pressure on people to fix their glibcs.

Right. I decided to detect this in ./configure, using a variation of the the code that Richard Guenther posted elsewhere. In case someone finds this thread searching for a solution, this works for me: AC_MSG_CHECKING(for glibc _FORTIFY_SOURCE/memmove bug) saved_cflags="$CFLAGS" CFLAGS="-O2 -D_FORTIFY_SOURCE=2" AC_RUN_IFELSE([AC_LANG_SOURCE([[ #include #include #include void foo(void *p, void *q) { memmove(p, q, 19); } int main() { char a[32] = "123456789000000000"; foo(&a[9], a); if (strcmp(a, "123456789123456789000000000") != 0) return 1; foo(a, &a[9]); if (strcmp(a, "123456789000000000") != 0) return 1; return 0; } ]])], [have_glibc_memmove_bug=no], [have_glibc_memmove_bug=yes], [have_glibc_memmove_bug=undefined]) CFLAGS="$saved_cflags" AC_MSG_RESULT($have_glibc_memmove_bug) if test "$have_glibc_memmove_bug" = yes; then AC_DEFINE(HAVE_GLIBC_MEMMOVE_BUG, 1, [Define if glibc has incorrect _FORTIFY_SOURCE wrappers for memmove and bcopy.]) fi -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

10 Jan 10 Jan

12:04

New subject: [Bug 658509] _FORTIFY_SOURCE wrappers for memmove and bcopy are wrong

https://bugzilla.novell.com/show_bug.cgi?id=658509 https://bugzilla.novell.com/show_bug.cgi?id=658509#c9 Richard Guenther changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED Target Milestone|--- |Factory --- Comment #9 from Richard Guenther 2011-01-10 12:04:05 UTC --- There is already a fixed glibc in Base:System which just needs to be pushed to factory which I have done now. -> Fixed. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

4862

Age (days ago)

4894

Last active (days ago)

List overview

Download

9 comments

1 participants

participants (1)

bugzilla_noreply＠novell.com

[Bug 658509] New: _FORTIFY_SOURCE wrappers for memmove and bcopy are wrong

tags

participants (1)