[Bug 1205577] New: makedepend: error: out of space: increase MAXFILES
http://bugzilla.opensuse.org/show_bug.cgi?id=1205577 Bug ID: 1205577 Summary: makedepend: error: out of space: increase MAXFILES Classification: openSUSE Product: openSUSE Tumbleweed Version: Current Hardware: Other OS: openSUSE Tumbleweed Status: NEW Severity: Normal Priority: P5 - None Component: Development Assignee: screening-team-bugs@suse.de Reporter: daniel.zorychta@gmail.com QA Contact: qa-bugs@suse.de Found By: --- Blocker: --- After last update (16 Nov 2022) the makedepend program is not working with more than 256 files in the path. The source code of makedepend has set 2048 files but current compiled version in opensuse has about 256. I have tested this with 292 files. I have downloaded older version from opensuse repositiory (makedepend version 1.0.5) and is working correctly with 292 files. The update that a made in 16 Nov 2022 add this regression. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1205577 http://bugzilla.opensuse.org/show_bug.cgi?id=1205577#c1 Daniel Zorychta <daniel.zorychta@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |build, Code Priority|P5 - None |P2 - High Blocker|--- |Yes Hardware|Other |x86-64 Found By|--- |Customer Severity|Normal |Major --- Comment #1 from Daniel Zorychta <daniel.zorychta@gmail.com> --- Error in terminal: makedepend: error: out of space: increase MAXFILES -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1205577 Daniel Zorychta <daniel.zorychta@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |daniel.zorychta@gmail.com -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1205577 Andreas Stieger <Andreas.Stieger@gmx.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P2 - High |P5 - None CC|daniel.zorychta@gmail.com |joan.torres@suse.com, | |sndirsch@suse.com Assignee|screening-team-bugs@suse.de |sndirsch@suse.com -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1205577 http://bugzilla.opensuse.org/show_bug.cgi?id=1205577#c2 Stefan Dirsch <sndirsch@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - None |P3 - Medium Status|NEW |IN_PROGRESS Component|Development |X.Org Assignee|sndirsch@suse.com |gfx-bugs@suse.de QA Contact|qa-bugs@suse.de |gfx-bugs@suse.de --- Comment #2 from Stefan Dirsch <sndirsch@suse.com> --- No idea why MAXFILES would be set to 256 in our build. Indeed in source code it's set to 2048. Best would be to bisect the issue. Possible candidates in git changes After 1.0.5 and before 1.0.6 From 0860822bb2a1bbc6e40758e2e6413181b26b6b04 Mon Sep 17 00:00:00 2001 From: Dirk <doj@cubic.org> Date: Thu, 11 Feb 2016 18:48:13 +0000 Subject: [PATCH 06/14] missing bounds check in makedepend for file arguments When assigning source code files from the command line to the fp pointer, no bounds check is done and if more than MAXFILES file names are specified on the command line, memory will be overridden out of bounds. https://bugs.freedesktop.org/show_bug.cgi?id=94099 After 1.0.6 From 3dc64b0b0a7d4e14ccea6b9d1d11bf871c47a7e0 Mon Sep 17 00:00:00 2001 From: Thibault DUPONCHELLE <thibault.duponchelle@gmail.com> Date: Wed, 20 Mar 2019 09:26:47 +0100 Subject: [PATCH 5/7] Add test case for bug #1 + proposed fix. Fixes: https://gitlab.freedesktop.org/xorg/util/makedepend/issues/1 -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1205577 http://bugzilla.opensuse.org/show_bug.cgi?id=1205577#c3 --- Comment #3 from Stefan Dirsch <sndirsch@suse.com> --- Hmm. I can't really reproduce this issue. My results # rm *.c; for i in $(seq 1 2046); do echo "incluce <stdio.h>" > hello${i}.c; done; makedepend *.c # rm *.c; for i in $(seq 1 2047); do echo "incluce <stdio.h>" > hello${i}.c; done; makedepend *.c makedepend: error: out of space: increase MAXFILES So failing with 2047 and higher. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1205577 http://bugzilla.opensuse.org/show_bug.cgi?id=1205577#c4 --- Comment #4 from Stefan Dirsch <sndirsch@suse.com> --- And I see the same results with makedepend 1.0.5. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1205577 http://bugzilla.opensuse.org/show_bug.cgi?id=1205577#c5 Stefan Dirsch <sndirsch@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |daniel.zorychta@gmail.com Flags| |needinfo?(daniel.zorychta@g | |mail.com) --- Comment #5 from Stefan Dirsch <sndirsch@suse.com> --- Could you please tell me how to reproduce that issue? Thanks! -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1205577 http://bugzilla.opensuse.org/show_bug.cgi?id=1205577#c6 --- Comment #6 from Daniel Zorychta <daniel.zorychta@gmail.com> --- Created attachment 862984 --> http://bugzilla.opensuse.org/attachment.cgi?id=862984&action=edit The test source code (project) for makedepend test. Hello. In the attachment there is part of my project (very simplified). To run test you need to extract archive. In the project's root directory just enter: "make". Makefile runs only dependencies application (makedepend). In version 1.0.6 the makedepend program does not return any error, in version 1.0.7 does. The result of command is a file with argument list passed to the makedepend - makedepend.args. In both versions of makedepend file is the same. The strange is that the number of files does not exceed 4096 or even 256 files. This code I have tested on two computers with openSUSE. Before update everything was working ok, after update not. Working version of makdepend: 1.0.6 (1.0.6-2.26) Not working version of makedepend: 1.07 (1.0.7-1.1). Error visible in terminal: /usr/bin/makedepend: error: out of space: increase MAXFILES Best Regards, Daniel -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1205577 http://bugzilla.opensuse.org/show_bug.cgi?id=1205577#c7 Stefan Dirsch <sndirsch@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(daniel.zorychta@g | |mail.com) | --- Comment #7 from Stefan Dirsch <sndirsch@suse.com> --- Ok. I could reproduce the issue and git bisected it. 3dc64b0b0a7d4e14ccea6b9d1d11bf871c47a7e0 is the first bad commit commit 3dc64b0b0a7d4e14ccea6b9d1d11bf871c47a7e0 Author: Thibault DUPONCHELLE <thibault.duponchelle@gmail.com> Date: Wed Mar 20 09:26:47 2019 +0100 Add test case for bug #1 + proposed fix. Fixes: https://gitlab.freedesktop.org/xorg/util/makedepend/issues/1 Makefile.am | 4 ++++ def.h | 1 + include.c | 34 ++++++++++++++++++++++++++++++++-- tests/1/makedep.sh | 39 +++++++++++++++++++++++++++++++++++++++ tests/1/one.cpp | 1 + tests/1/two.cpp | 1 + 6 files changed, 78 insertions(+), 2 deletions(-) create mode 100755 tests/1/makedep.sh create mode 100644 tests/1/one.cpp create mode 100644 tests/1/two.cpp -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1205577 http://bugzilla.opensuse.org/show_bug.cgi?id=1205577#c8 --- Comment #8 from Stefan Dirsch <sndirsch@suse.com> --- I suggest to open an issue on https://gitlab.freedesktop.org/xorg/util/makedepend/-/issues -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1205577 http://bugzilla.opensuse.org/show_bug.cgi?id=1205577#c9 --- Comment #9 from Daniel Zorychta <daniel.zorychta@gmail.com> --- I have created new issue in gitlab.freedesktop.org: https://gitlab.freedesktop.org/xorg/util/makedepend/-/issues/2 -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠suse.com