[Bug 874109] New: git uses SSH_ASKPASS and starts Ksshaskpass and kwallet gui
https://bugzilla.novell.com/show_bug.cgi?id=874109
https://bugzilla.novell.com/show_bug.cgi?id=874109#c0
Summary: git uses SSH_ASKPASS and starts Ksshaskpass and
kwallet gui
Classification: openSUSE
Product: openSUSE 13.1
Version: Final
Platform: Other
OS/Version: Other
Status: NEW
Severity: Normal
Priority: P5 - None
Component: Basesystem
AssignedTo: bnc-team-screening@forge.provo.novell.com
ReportedBy: sweet_f_a@gmx.de
QAContact: qa-bugs@suse.de
Found By: ---
Blocker: ---
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:28.0) Gecko/20100101
Firefox/28.0
"git fetch
https://bugzilla.novell.com/show_bug.cgi?id=874109
https://bugzilla.novell.com/show_bug.cgi?id=874109#c
zhang jiajun
https://bugzilla.novell.com/show_bug.cgi?id=874109
https://bugzilla.novell.com/show_bug.cgi?id=874109#c1
Takashi Iwai
https://bugzilla.novell.com/show_bug.cgi?id=874109
https://bugzilla.novell.com/show_bug.cgi?id=874109#c2
--- Comment #2 from Ruediger Meier
https://bugzilla.novell.com/show_bug.cgi?id=874109
https://bugzilla.novell.com/show_bug.cgi?id=874109#c3
Ilya Chernykh
https://bugzilla.novell.com/show_bug.cgi?id=874109
https://bugzilla.novell.com/show_bug.cgi?id=874109#c4
Ruediger Meier
https://bugzilla.novell.com/show_bug.cgi?id=874109
https://bugzilla.novell.com/show_bug.cgi?id=874109#c5
--- Comment #5 from Ilya Chernykh
https://bugzilla.novell.com/show_bug.cgi?id=874109
https://bugzilla.novell.com/show_bug.cgi?id=874109#c
Ilya Chernykh
https://bugzilla.novell.com/show_bug.cgi?id=874109
https://bugzilla.novell.com/show_bug.cgi?id=874109#c6
Bernhard Wiedemann
https://bugzilla.novell.com/show_bug.cgi?id=874109
https://bugzilla.novell.com/show_bug.cgi?id=874109#c7
--- Comment #7 from Ruediger Meier
So question is if we want to add a terminal-detection logic to ssh-askpass or git
I guess in git. If you explicitly want to run ssh-askpass then it should even work from terminal. Maybe it's just openSUSE's env which breaks git's terminal-detection. Have you checked other distros? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=874109
https://bugzilla.novell.com/show_bug.cgi?id=874109#c
Bernhard Wiedemann
https://bugzilla.novell.com/show_bug.cgi?id=874109
https://bugzilla.novell.com/show_bug.cgi?id=874109#c8
Takashi Iwai
(In reply to comment #6)
So question is if we want to add a terminal-detection logic to ssh-askpass or git
I guess in git.
No, why at all? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=874109
https://bugzilla.novell.com/show_bug.cgi?id=874109#c9
--- Comment #9 from Ruediger Meier
(In reply to comment #7)
(In reply to comment #6)
So question is if we want to add a terminal-detection logic to ssh-askpass or git
I guess in git.
No, why at all?
Because the client who is seeing SSH_ASKPASS in it's env has to decide whether to use it or not. Like the ssh client himself does it correctly, see man ssh: "SSH_ASKPASS If ssh needs a passphrase, it will read the passphrase from the current terminal if it was run from a terminal. If ssh does not have a terminal associated with it but DISPLAY and SSH_ASKPASS are set, it will execute the program specified by SSH_ASKPASS and open an X11 window to read the passphrase. This is particularly useful when calling ssh from a .xsession or related script. (Note that on some machines it may be necessary to redirect the input from /dev/null to make this work.)" Since git is just using ssh client (or lib?) maybe just the "terminal info" gets lost when git calls ssh!? BUT I really wonder why SSH_ASKPASS is started at all although I do https and not ssh. Looks like it's really misused. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=874109
https://bugzilla.novell.com/show_bug.cgi?id=874109#c10
--- Comment #10 from Takashi Iwai
https://bugzilla.novell.com/show_bug.cgi?id=874109
https://bugzilla.novell.com/show_bug.cgi?id=874109#c11
--- Comment #11 from Ruediger Meier
https://bugzilla.novell.com/show_bug.cgi?id=874109
https://bugzilla.novell.com/show_bug.cgi?id=874109#c12
--- Comment #12 from Takashi Iwai
But unsetting SSH_ASKPASS avoids the problem for git. So if it's set then git is doing wrong.
No, please read the man page again. Git simply invokes what's defined in $SSH_ASKPASS. If not defined, it tries its own prompt.
However if you work in console then there should NEVER pop up any stupid gui stuff. At least not per default.
How can you know that? Did you get statistics? So far, it's nothing more than your subjective feeling and taste. That said, as this is currently a designed feature, if you need to "fix" your problem, please try convincing upstream first, or please give a patch so that we can submit to the upstream and include to our package. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=874109
https://bugzilla.novell.com/show_bug.cgi?id=874109#c13
--- Comment #13 from Ruediger Meier
However if you work in console then there should NEVER pop up any stupid gui stuff. At least not per default.
How can you know that? Did you get statistics? So far, it's nothing more than your subjective feeling and taste.
I don't know what to say ... can you not see that it's absolutely stupid to pop up GUI when calling ssh, ftp, wget, git or whatever from terminal or scripts?
That said, as this is currently a designed feature, if you need to "fix" your problem, please try convincing upstream first, or please give a patch so that we can submit to the upstream and include to our package.
I agree now that this may be an upstream bug. The example below is surely an unwanted discrepancy when typing these commands in terminal: $ export SSH_ASKPASS=/usr/lib/ssh/ssh-askpass $ git clone ssh://unknown@ssh-server/blubba < asks for password in terminal as it should > $ git clone https://unknown@https-server/blubba < popup gui ...> 1. Since SSH_ASKPASS was introduced for being used in ssh client it should never pop up gui when you are in terminal ... as you can read in ssh man page. Any non-ssh client (e.g. git) should respect that too! 2. Misusage! SSH_ASKPASS was invented for ssh and not https. This is a similar to the recently discussed misuse of kernel "debug" parameter by systemd. I'm going to report this upstream. On the other hand ... if there is existing software which misuses certain env vars then openSUSE should either fix that shipped software or don't export that env per default. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=874109
https://bugzilla.novell.com/show_bug.cgi?id=874109#c14
--- Comment #14 from Takashi Iwai
I'm going to report this upstream.
Yes, please. This is the very thing to be fixed in the upstream at first.
On the other hand ... if there is existing software which misuses certain env vars then openSUSE should either fix that shipped software or don't export that env per default.
That's why I asked for KDE guys at first... Even if it's a misusage, this is a design issue in the end. As long as the software is working as designed, it's no "bug" per se. It's just a design mistake. So, I'm pretty much for improving the behavior, but let's fix this in the upstream and backport the patch if needed for the released openSUSE products. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=874109
Takashi Iwai
participants (1)
-
bugzilla_noreply@novell.com