https://bugzilla.novell.com/show_bug.cgi?id=655483 https://bugzilla.novell.com/show_bug.cgi?id=655483#c1 --- Comment #1 from Duncan Mac-Vicar <dmacvicar@novell.com> 2010-11-23 12:24:14 UTC --- Created an attachment (id=401780) --> (http://bugzilla.novell.com/attachment.cgi?id=401780) libproxy sysconfig support This patchs adds support to sysconfig for libproxy. There are two points that need review: Right now, the module implements virtual bool operator<(const base_extension&) const { if (getuid == 0) return true; return false; } which means the plugin will be put first, if we run as root. Also in the module loading macro: MM_MODULE_INIT_EZ(sysconfig_config_extension, true, NULL, NULL); It seems the true parameter needs to be replaced by a conditional for this module to be used, something if_exists?(/etc/sysconfig) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=655483 https://bugzilla.novell.com/show_bug.cgi?id=655483#c2 --- Comment #2 from Dominique Leuenberger <dimstar@opensuse.org> 2010-11-23 12:43:51 UTC ---

MM_MODULE_INIT_EZ(sysconfig_config_extension, true, NULL, NULL);

i'd suggest replacing true with getuid() == 0; thus not going through the whole init if you're not root and invalidate the module completely for other users (which would have their own session normally). -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=655483 https://bugzilla.novell.com/show_bug.cgi?id=655483#c4 Duncan Mac-Vicar <dmacvicar@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vuntz@novell.com --- Comment #4 from Duncan Mac-Vicar <dmacvicar@novell.com> 2010-11-23 15:04:12 UTC --- Nathaniel, I sent it upstream ( http://code.google.com/p/libproxy/issues/detail?id=150 ) I will post the updated version there. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=655483 https://bugzilla.novell.com/show_bug.cgi?id=655483#c6 --- Comment #6 from Vincent Untz <vuntz@novell.com> 2010-11-26 12:34:01 UTC --- Dominique: do we want to include it in our package now? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=655483 https://bugzilla.novell.com/show_bug.cgi?id=655483#c8 --- Comment #8 from Vincent Untz <vuntz@novell.com> 2010-12-06 18:57:35 UTC --- Submitted to G:F (sr#54906). Duncan: I don't know if there's anything else you want to track in this bug, or if your patch covers everything you needed. If the latter, then we can close the bug, I guess. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.