https://bugzilla.novell.com/show_bug.cgi?id=383573 Summary: linux-2.6-scsi-mpt-vmware-fix.patch still necessary ? Product: openSUSE 11.0 Version: Factory Platform: 32bit OS/Version: openSUSE 11.0 Status: NEW Severity: Normal Priority: P5 - None Component: Kernel AssignedTo: kernel-maintainers@forge.provo.novell.com ReportedBy: roland.kletzing@materna.de QAContact: qa@suse.de Found By: --- this is not really a bug, but i don`t know a better place to discuss. i found this patch in kotd sources. question: hasn`t this been fixed in recent vmware releases/minor updates ? e.g. readme for server 1.0.4 tells: This release fixes a problem that prevented virtual machines running Fedora Core 7 from properly recognizing LSILogic SCSI devices. so - is this patch still necessary? i`m asking because i think it`s better if people are forced to update their vmware installation (which fixes security issues, too) than just silently running a kernel which contains workarounds for bugs. regards roland linux-2.6-scsi-mpt-vmware-fix.patch The attached patch is a workaround for a bug in VMWare's emulated LSI Fusion SCSI HBA. The emulated firmware returns zero for the maximum number of attached devices; the real firmware returns a positive number. Therefore, the kernel that boots and works fine on bare metal will fail on VMWare because this firmware value is handed to the SCSI midlayer, which then skips the entire bus scan. F7 bz 241935 The patch below was submitted by Eric Moore of LSI to the linux-scsi mailing list: http://marc.info/?l=linux-scsi&m=117432237404247 then immediately rejected by Christoph Hellwig, who prefers that VMWare fix their emulation instead. diff --git a/drivers/message/fusion/mptbase.c b/drivers/message/fusion/mptbase.c index eddb933..21fadf2 100644 --- a/drivers/message/fusion/mptbase.c +++ b/drivers/message/fusion/mptbase.c @@ -2571,8 +2571,19 @@ GetPortFacts(MPT_ADAPTER *ioc, int portnum, int sleepFlag) pfacts->MaxPersistentIDs = le16_to_cpu(pfacts->MaxPersistentIDs); pfacts->MaxLanBuckets = le16_to_cpu(pfacts->MaxLanBuckets); - max_id = (ioc->bus_type == SAS) ? pfacts->PortSCSIID : - pfacts->MaxDevices; + switch (ioc->bus_type) { + case SAS: + max_id = pfacts->PortSCSIID; + break; + case FC: + max_id = pfacts->MaxDevices; + break; + case SPI: + default: + max_id = MPT_MAX_SCSI_DEVICES; + break; + } + ioc->devices_per_bus = (max_id > 255) ? 256 : max_id; ioc->number_of_buses = (ioc->devices_per_bus < 256) ? 1 : max_id/256; -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.