[Bug 538765] New: finger-1.3-143.8: missing call to free or pointless local array
http://bugzilla.novell.com/show_bug.cgi?id=538765 Summary: finger-1.3-143.8: missing call to free or pointless local array Classification: openSUSE Product: openSUSE 11.2 Version: Factory Platform: All OS/Version: openSUSE 11.1 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Found By: --- I just had a look at factory package finger-1.3-143.8 For source code file finger-bsd-1.3/finger/util.c around line 430, function vs, is the following code if ((wdst = calloc (sizeof (wchar_t), wcslen (wstr) + 1)) == NULL) but I fail to find the matching call to free. Further, local array wdst is written to, but never read from. Suggest either add call to free, or remove local array wdst. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=538765 Marcus Meissner <meissner@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team-screening@forge.pr |hvogel@novell.com |ovo.novell.com | -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=538765 User rguenther@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=538765#c1 --- Comment #1 from Richard Guenther <rguenther@novell.com> 2009-10-17 08:55:30 MDT --- David, in case the issues are not introduced by a patch local to openSUSE please report the issues upstream. Packagers, please do not add openSUSE-local patches to fix this kind of errors but forward the bugs upstream and close the bugs as RESOLVED UPSTREAM. Note that it is perfectly fine to have "resource leaks" at the end of a program as the kernel will clean up for you. Manually freeing them only increases binary size and runtime. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=538765 http://bugzilla.novell.com/show_bug.cgi?id=538765#c Hendrik Vogelsang <hvogel@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|hvogel@novell.com |mike@novell.com -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=538765 http://bugzilla.novell.com/show_bug.cgi?id=538765#c Michal Seben <mseben@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|finger-1.3-143.8: missing |JJ:finger-1.3-143.8: |call to free or pointless |missing call to free or |local array |pointless local array -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=538765 http://bugzilla.novell.com/show_bug.cgi?id=538765#c Michal Seben <mseben@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - None |P4 - Low Severity|Normal |Minor -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=538765 http://bugzilla.novell.com/show_bug.cgi?id=538765#c4 Petr Gajdos <pgajdos@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #4 from Petr Gajdos <pgajdos@novell.com> 2010-07-30 08:14:25 UTC --- Closing as fixed. Request #44251: submit: network:utilities/finger(r3) -> openSUSE:Factory/finger Message: - fixed memory leak and wrong return [bnc#538765] State: new 2010-07-30T10:13:41 pgajdos Comment: None -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=538765 http://bugzilla.novell.com/show_bug.cgi?id=538765#c5 --- Comment #5 from Bernhard Wiedemann <bwiedemann@suse.com> --- This is an autogenerated message for OBS integration: This bug (538765) was mentioned in https://build.opensuse.org/request/show/44340 Factory / finger -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com