[Bug 707703] New: pulseaudio: setup-pulseaudio should be called in %post
https://bugzilla.novell.com/show_bug.cgi?id=707703 https://bugzilla.novell.com/show_bug.cgi?id=707703#c0 Summary: pulseaudio: setup-pulseaudio should be called in %post Classification: openSUSE Product: openSUSE 12.1 Version: Factory Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: P5 - None Component: GNOME AssignedTo: bnc-team-gnome@forge.provo.novell.com ReportedBy: vuntz@novell.com QAContact: qa@suse.de Found By: --- Blocker: --- Pulseaudio is enabled in my config (/etc/sysconfig/sound) but I do not have the /etc/profile.d/ files. It really looks like setup-pulseaudio should be called from %post, in such a way that it looks at the value in /etc/sysconfig/sound and does the right thing. Maybe something like "setup-pulseaudio --auto" would work. Note for me: this would make it possible to remove some stuff from /usr/bin/gnome. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=707703
https://bugzilla.novell.com/show_bug.cgi?id=707703#c1
Vincent Untz
https://bugzilla.novell.com/show_bug.cgi?id=707703
https://bugzilla.novell.com/show_bug.cgi?id=707703#c2
Takashi Iwai
https://bugzilla.novell.com/show_bug.cgi?id=707703
https://bugzilla.novell.com/show_bug.cgi?id=707703#c3
--- Comment #3 from Vincent Untz
It sounds reasonable. --auto would write profile.d/* files when not exist, right?
It would always update the profile.d/* files, so that they're in sync with the $PULSEAUDIO_DISABLE value.
Also pulseaudio package should do fillup properly in %post for $PULSEAUDIO_DISABLE in /etc/sysconfig/sound.
Ok, I'll look at that too. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=707703
https://bugzilla.novell.com/show_bug.cgi?id=707703#c4
--- Comment #4 from Takashi Iwai
(In reply to comment #2)
It sounds reasonable. --auto would write profile.d/* files when not exist, right?
It would always update the profile.d/* files, so that they're in sync with the $PULSEAUDIO_DISABLE value.
OK, that makes sense. BTW, setup-pulseaudio touches other config files like /etc/libao.conf, etc. I'm not sure whether these also be updated forcibly by each update of pulseaudio.rpm. Also, the default behavior is another question. When $PULSEAUDIO_ENABLE isn't set in /etc/sysconfig, should setup-pulseaudio --auto abort without changing anything? This would be safer, at least, not to break the existing user's setup. Meanwhile, if we add $PULSEAUDIO_ENABLE in %post via %fillup, it'll point either "yes" or "no", thus it'll forcibly enable or disable all setups. So, using %fillup makes one thing easier but one thing uncertain. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=707703
https://bugzilla.novell.com/show_bug.cgi?id=707703#c5
--- Comment #5 from Vincent Untz
(In reply to comment #3)
(In reply to comment #2)
It sounds reasonable. --auto would write profile.d/* files when not exist, right?
It would always update the profile.d/* files, so that they're in sync with the $PULSEAUDIO_DISABLE value.
OK, that makes sense.
BTW, setup-pulseaudio touches other config files like /etc/libao.conf, etc. I'm not sure whether these also be updated forcibly by each update of pulseaudio.rpm.
Looking at the script, it looks to me like they would be updated only if they don't contain the necessary config for PA. I see your point, though. I would think it's relatively sane to only deal with the "use PA for everything"/"use PA for nothing" cases, and ignore the others where a user might enable/disable PA only for a few components. It could still be annoying to some, but I don't see how to best deal with that. Actually, we could have three values for $PULSEAUDIO_ENABLE: yes, no, custom. And if it's custom, --auto would do nothing at all.
Also, the default behavior is another question. When $PULSEAUDIO_ENABLE isn't set in /etc/sysconfig, should setup-pulseaudio --auto abort without changing anything? This would be safer, at least, not to break the existing user's setup.
Meanwhile, if we add $PULSEAUDIO_ENABLE in %post via %fillup, it'll point either "yes" or "no", thus it'll forcibly enable or disable all setups. So, using %fillup makes one thing easier but one thing uncertain.
I think we should just add $PULSEAUDIO_ENABLE in %post via %fillup anyway. I'm setting it to "yes", as PA is the default in the distro anyway. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=707703
https://bugzilla.novell.com/show_bug.cgi?id=707703#c6
--- Comment #6 from Takashi Iwai
(In reply to comment #4)
(In reply to comment #3)
(In reply to comment #2)
It sounds reasonable. --auto would write profile.d/* files when not exist, right?
It would always update the profile.d/* files, so that they're in sync with the $PULSEAUDIO_DISABLE value.
OK, that makes sense.
BTW, setup-pulseaudio touches other config files like /etc/libao.conf, etc. I'm not sure whether these also be updated forcibly by each update of pulseaudio.rpm.
Looking at the script, it looks to me like they would be updated only if they don't contain the necessary config for PA. I see your point, though. I would think it's relatively sane to only deal with the "use PA for everything"/"use PA for nothing" cases, and ignore the others where a user might enable/disable PA only for a few components. It could still be annoying to some, but I don't see how to best deal with that.
Actually, we could have three values for $PULSEAUDIO_ENABLE: yes, no, custom. And if it's custom, --auto would do nothing at all.
Sounds good.
Also, the default behavior is another question. When $PULSEAUDIO_ENABLE isn't set in /etc/sysconfig, should setup-pulseaudio --auto abort without changing anything? This would be safer, at least, not to break the existing user's setup.
Meanwhile, if we add $PULSEAUDIO_ENABLE in %post via %fillup, it'll point either "yes" or "no", thus it'll forcibly enable or disable all setups. So, using %fillup makes one thing easier but one thing uncertain.
I think we should just add $PULSEAUDIO_ENABLE in %post via %fillup anyway. I'm setting it to "yes", as PA is the default in the distro anyway.
Hm, OK. Maybe it'll screw up some users, but it's just one time setup, thus nothing too serious, I think. Anyway this should be mentioned in the release-note or such. BTW, I haven't begun the work yet, so if you already started on this, just go ahead :) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=707703
https://bugzilla.novell.com/show_bug.cgi?id=707703#c7
--- Comment #7 from Vincent Untz
https://bugzilla.novell.com/show_bug.cgi?id=707703
https://bugzilla.novell.com/show_bug.cgi?id=707703#c8
--- Comment #8 from Bernhard Wiedemann
https://bugzilla.novell.com/show_bug.cgi?id=707703
https://bugzilla.novell.com/show_bug.cgi?id=707703#c9
Vincent Untz
https://bugzilla.novell.com/show_bug.cgi?id=707703
https://bugzilla.novell.com/show_bug.cgi?id=707703#c
Karl Eichwalder
participants (1)
-
bugzilla_noreply＠novell.com