http://bugzilla.opensuse.org/show_bug.cgi?id=1204587 Dominique Leuenberger <dimstar@opensuse.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dmair@suse.com Assignee|kernel-bugs@opensuse.org |ptesarik@suse.com -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=1204587 http://bugzilla.opensuse.org/show_bug.cgi?id=1204587#c2 David Mair <dmair@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |IN_PROGRESS Assignee|ptesarik@suse.com |dmair@suse.com --- Comment #2 from David Mair <dmair@suse.com> --- I will fix this and make a submit by the close of the US work-day on October 28th 2022. Or explain here what's preventing me. -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=1204587 http://bugzilla.opensuse.org/show_bug.cgi?id=1204587#c4 --- Comment #4 from David Mair <dmair@suse.com> --- I modified the extensions Makefile to look at the cwd and for the presence of defs.h after the link_defs rule shown in comment #3. It indicates the extensions are built with a cwd of /home/abuild/rpmbuild/BUILD/<crash base>/extensions/ and the defs.h hardlink is created with permissions usable to the compiler and from the correct file in <crash base>, the parent directory of extensions/. It's the dependency that's failing in the make rule, not the compiler reporting file not found during compilation. Or to put it another way, attacking something like the compiler include path won't matter, the compiler was never started. make finds the source file in extensions, uses a rule to create a hardlink of defs.h file and at the next rule make reports the defs.h file not found in the current directory. Two illustrations: 1. In the crash extensions Makefile at the rule for <extension>.so dependent on <extension>.c and defs.h I removed defs.h from the dependencies and the package builds 2. Restored <extension>.so dependent on <extension>.c and defs.h BUT added a rule for defs.h that uses the rule to hardlink defs.h and the package builds Item 2 is better since it doesn't reduce dependencies, the whole Makefile with patch line looks like this (see +defs.h). It will be Tuesday US time when I can submit this: # # Makefile for building crash shared object extensions #... CONTRIB_SO := $(patsubst %.c,%.so,$(wildcard *.c)) all: link_defs $(CONTRIB_SO) link_defs: @rm -f defs.h @ln ../defs.h +defs.h: link_defs $(CONTRIB_SO): %.so: %.c defs.h @if [ -f $*.mk ]; then \ make -f $*.mk; \ else \ grep '((constructor))' $*.c > .constructor; \ if [ -s .constructor ]; then \ echo "gcc -Wall -g -shared -rdynamic -o $@ $*.c -fPIC -D$(TARGET) $(TARGET_CFLAGS) $(GDB_FLAGS)"; \ gcc -Wall -g -shared -rdynamic -o $@ $*.c -fPIC -D$(TARGET) $(TARGET_CFLAGS) $(GDB_FLAGS); \ fi; \ if [ ! -s .constructor ]; then \ echo "gcc -Wall -g -nostartfiles -shared -rdynamic -o $@ $*.c -fPIC -D$(TARGET) $(TARGET_CFLAGS) $(GDB_FLAGS)"; \ gcc -Wall -g -nostartfiles -shared -rdynamic -o $@ $*.c -fPIC -D$(TARGET) $(TARGET_CFLAGS) $(GDB_FLAGS); \ fi; \ rm -f .constructor; \ fi clean: rm -f $(CONTRIB_SO) @for MAKEFILE in `grep -sl "^clean:" *.mk`; \ do make --no-print-directory -f $$MAKEFILE clean; \ done -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=1204587 http://bugzilla.opensuse.org/show_bug.cgi?id=1204587#c6 --- Comment #6 from David Mair <dmair@suse.com> --- (In reply to David Mair from comment #5)

...The modified crash source results in successful build of openSUSE:Factory crash for all architectures except s390

NB: Only one product/s390 build fails, openSUSE_Factory_zSystems fails as shown at comment #5 which is not the manner of any other build failure when this bug was reported. IOW, build for the 12 s390 builds for other products succeed and build for every enabled product/architecture combination except openSUSE_Factory_zSystems succeeds using the change in comment #4. I believe openSUSE_Factory_zSystems build failure in the crash kernel modules is a different bug from this report (probably related to changes in the changed kernel version's object interface).

...

-- You are receiving this mail because: You are on the CC list for the bug.