[Bug 735320] New: go: %{go_make_install} breaks Make.cmd builds
https://bugzilla.novell.com/show_bug.cgi?id=735320 https://bugzilla.novell.com/show_bug.cgi?id=735320#c0 Summary: go: %{go_make_install} breaks Make.cmd builds Classification: openSUSE Product: openSUSE 12.1 Version: Final Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: P5 - None Component: Development AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dmacvicar@suse.com QAContact: qa@suse.de CC: graham@andtech.eu, speilicke@suse.com Found By: --- Blocker: --- If you build a go binary (not a package) you include Make.cmd instead of Make.pkg. Make.pkg installs in TARGDIR, which is set by the macro: %{go_make_install} to TARGDIR=%{buildroot}%{go_sitearch} This is right, as Make.pkg sets it as default to $(GOROOT)/pkg/$(GOOS)_$(GOARCH) But if you build a command, Make.cmd uses $GOBIN (/usr/bin), but it gets overriden by %{go_make_install} resulting in the binary to be installed in the package directory. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=735320 https://bugzilla.novell.com/show_bug.cgi?id=735320#c1 Sascha Peilicke <speilicke@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED AssignedTo|bnc-team-screening@forge.pr |speilicke@suse.com |ovo.novell.com | --- Comment #1 from Sascha Peilicke <speilicke@suse.com> 2011-12-13 14:57:28 UTC --- As an initial 'fix', I added GOBIN to %go_make_install, as some Go packages (that include $(GOROOT)/src/Make.pkg) like to add Makefile targets similar to: tools: ... install -m 0755 redis-load $(GOBIN) Unfortunately, the whole gomake situation isn't yet thought out very well, especially for Go projects that create both binaries and (statis) libraries. Some use individual Makefile targets, some use separate Makefiles (may be the best solution ATM for upstream developers). However, in order to fix this, I changed src/Make.cmd to always use $GOBIN (set correctly as above), regardless of TARGDIR, this allows to retain %go_make_install in it's current form. Please note that I updated the spec file of 'go-gb' accordingly, please have a look (and similarly, go-redis.go). Maybe worth another update of Go in 12.1 ... -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=735320 SMASH SMASH <smash_bz@suse.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Whiteboard|maint:planned:update | -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com