[Bug 531673] New: wodim-1.1.9-1.15: missing call to fclose
http://bugzilla.novell.com/show_bug.cgi?id=531673 Summary: wodim-1.1.9-1.15: missing call to fclose Classification: openSUSE Product: openSUSE 11.2 Version: Factory Platform: All OS/Version: openSUSE 11.1 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Found By: --- I just had a look at factory package wodim-1.1.9-1.15 For source code file cdrkit-1.1.9/genisoimage/apple.c around line 2460 is the source code for the function hfs_init. I notice the following line of code if ((fp = fopen(name, "r")) == NULL) but I fail to notice a matching call to fclose. This looks like a resource leak to me. Suggest add a call to fclose. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=531673 shuang qiu <sqiu@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sqiu@novell.com AssignedTo|bnc-team-screening@forge.pr |nadvornik@novell.com |ovo.novell.com | -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=531673 User rguenther@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=531673#c1 --- Comment #1 from Richard Guenther <rguenther@novell.com> 2009-10-17 08:55:03 MDT --- David, in case the issues are not introduced by a patch local to openSUSE please report the issues upstream. Packagers, please do not add openSUSE-local patches to fix this kind of errors but forward the bugs upstream and close the bugs as RESOLVED UPSTREAM. Note that it is perfectly fine to have "resource leaks" at the end of a program as the kernel will clean up for you. Manually freeing them only increases binary size and runtime. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=531673 https://bugzilla.novell.com/show_bug.cgi?id=531673#c2 Jörg Schiling <joerg.schilling@fokus.fraunhofer.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joerg.schilling@fokus.fraun | |hofer.de --- Comment #2 from Jörg Schiling <joerg.schilling@fokus.fraunhofer.de> 2011-04-01 19:38:23 UTC --- reporting problems again genisoimage is ignored by it's upstream Debian. The problem you are reffering to has however been fixes in 2008 in the original mkisofs alread. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com