[Bug 234342] New: abiword-2.4.5-38: pointless computation
https://bugzilla.novell.com/show_bug.cgi?id=234342 Summary: abiword-2.4.5-38: pointless computation Product: openSUSE 10.3 Version: unspecified Platform: All OS/Version: SuSE Other Status: NEW Severity: Normal Priority: P5 - None Component: Basesystem AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de I just tried to compile package abiword-2.4.5-38 with the Intel C compiler. The compiler said xap_Draw_Symbol.cpp(260): remark #593: variable "sheight" was set but never used xap_Draw_Symbol.cpp(260): remark #593: variable "swidth" was set but never used xap_Draw_Symbol.cpp(138): remark #593: variable "xoff" was set but never used xap_Draw_Symbol.cpp(138): remark #593: variable "yoff" was set but never used I've checked all four and I agree. There seems to be some pointless computation. Suggest delete these local variables. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=234342 stbinner@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team- |bnc-team-gnome@forge.provo.novell.com |screening@forge.provo.novell| |.com | Component|Basesystem |GNOME ------- Comment #1 from stbinner@novell.com 2007-01-13 12:54 MST ------- Please try to be more clever about the component. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=234342 ------- Comment #2 from dcb314@hotmail.com 2007-01-13 14:29 MST ------- (In reply to comment #1)
Please try to be more clever about the component.
Point taken. But I am not sure how I am going to do any better. There are thousands of packages and only a few components. Is there a list somewhere which maps package name onto component ? Certain other linux distributions offer a popup list of all package names in their versions of bugzilla. Would it save time if Novell were to do something similar ? I couldn't get it wrong then. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=234342 ------- Comment #3 from maw@novell.com 2007-02-21 13:18 MST ------- In practice, won't these be optimized out? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=234342 ------- Comment #4 from dcb314@hotmail.com 2007-02-21 14:05 MST ------- (In reply to comment #3)
In practice, won't these be optimized out?
I don't think so. Is the optimiser used on this code ? In any event, simplifying the source code to avoid pointless computation I think helps future developers. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=234342 jpr@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |should_go_upstream ------- Comment #5 from jpr@novell.com 2007-02-22 20:46 MST ------- This causes no memory corruption or anything, it should really go upstream. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=234342 Rodrigo Moya <rodrigo@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rodrigo@novell.com Status Whiteboard| |gnome-wrong-out-of-the-box -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=234342 User jpr@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=234342#c6 JP Rosevear <jpr@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO Info Provider| |hfiguiere@novell.com --- Comment #6 from JP Rosevear <jpr@novell.com> 2008-03-29 10:58:13 MST --- Close if fixed in 2.6 hub. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=234342 User hfiguiere@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=234342#c7 Hubert Figuiere <hfiguiere@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hfiguiere@novell.com --- Comment #7 from Hubert Figuiere <hfiguiere@novell.com> 2008-03-29 11:04:24 MST --- I have no idea. I don't use intel compiler. But I know lot of warnings got fixed. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=234342 User hfiguiere@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=234342#c8 Hubert Figuiere <hfiguiere@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |RESOLVED Info Provider|hfiguiere@novell.com | Resolution| |FIXED --- Comment #8 from Hubert Figuiere <hfiguiere@novell.com> 2008-04-02 18:30:52 MST --- fixed by bug 374240. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=234342 JP Rosevear <jpr@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|should_go_upstream | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com