[Bug 834854] New: Install kernel parameters are lost in the installed system
https://bugzilla.novell.com/show_bug.cgi?id=834854 https://bugzilla.novell.com/show_bug.cgi?id=834854#c0 Summary: Install kernel parameters are lost in the installed system Classification: openSUSE Product: openSUSE Factory Version: 13.1 Milestone 4 Platform: x86-64 OS/Version: SUSE Other Status: NEW Severity: Major Priority: P5 - None Component: Installation AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: rsalevsky@suse.com QAContact: jsrain@suse.com CC: trenn@suse.com Found By: --- Blocker: --- Created an attachment (id=552614) --> (http://bugzilla.novell.com/attachment.cgi?id=552614) Yast2 Logs When I start the installation with some special kernel parameters then these are lost on the installed system. pxe boot parameters: label factory-install-auto-ssh kernel dist/factory/FACTORY/inst-source/boot/x86_64/loader/linux append vga=normal console=tty0 console=ttyS0,57600 install=ftp://10.121.0.100/dist/factory/FACTORY/inst-source autoyast=ftp://10.121.0.100/autoinst/pxe/factory.xml usessh=1 sshpassword=hammer23 kexec_reboot=1 initrd=dist/factory/FACTORY/inst-source/boot/x86_64/loader/initrd sysrq_always_enabled linemode=1 panic=100 ignore_loglevel unknown_nmi_panic insecure=1 dud=ftp://10.121.0.100/dud/perl-Bootloader.dud linuxrc.debug=1 grub2 boot parameters (after installation): menuentry 'openSUSE' --class 'opensuse' --class gnu-linux --class gnu --class os $menuentry_id_option 'gnulinux-simple-e1ea4b21-e6af-4f75-a76d-40414b244b9a' { load_video set gfxpayload=keep insmod gzio insmod part_gpt insmod ext2 set root='hd0,gpt1' if [ x$feature_platform_search_hint = xy ]; then search --no-floppy --fs-uuid --set=root --hint-bios=hd0,gpt1 --hint-efi=hd0,gpt1 --hint-baremetal=ahci0,gpt1 c5498087-7896-4eb7-bc08-def98aecb281 else search --no-floppy --fs-uuid --set=root c5498087-7896-4eb7-bc08-def98aecb281 fi echo 'Loading Linux 3.10.1-3.g0cd5432-default ...' linux /vmlinuz-3.10.1-3.g0cd5432-default root=UUID=e1ea4b21-e6af-4f75-a76d-40414b244b9a quiet splash=silent crashkernel=2G-:128M echo 'Loading initial ramdisk ...' initrd /initrd-3.10.1-3.g0cd5432-default } After installation boot parameters like sysrq_always_enabled or console=ttyS0,57600 are missing. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=834854 https://bugzilla.novell.com/show_bug.cgi?id=834854#c Ye Yuan <yyuan@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |yyuan@suse.com AssignedTo|bnc-team-screening@forge.pr |kernel-maintainers@forge.pr |ovo.novell.com |ovo.novell.com -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=834854 https://bugzilla.novell.com/show_bug.cgi?id=834854#c4 --- Comment #4 from Michael Chang <mchang@suse.com> 2013-08-22 06:28:42 UTC --- It seems like was_proposed is *always* true for autoyast installation thus the proposed value is never processed .. 2013-08-14 14:08:46 <1> kimball.arch.suse.de(3689) [Ruby] modules/BootGRUB2.rb:159 calling Propose with was_proposed set is really bogus, clear it to force a re-propose The proposed value here is the imported autoyast settings. I don't know, as that was_proposed check is needed for DVD installation to protect custom settings from being overwritten by default proposed settings erroneously. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=834854 https://bugzilla.novell.com/show_bug.cgi?id=834854#c5 --- Comment #5 from Michael Chang <mchang@suse.com> 2013-08-22 06:35:48 UTC --- In BootPOWERLILO.rb, I found the interesting comment in it's propose function. if BootCommon.was_proposed # FIXME: autoyast settings are simply Import()ed and was_proposed is # set to true. The settings for the current board still need to be # initialized though. We do this every time the bootloader proposal is # called, because it also does not harm (results for the board # detection are cached both in Arch.ycp and in our variable # board_type.) To fix: make the "where does the information come # from", when, more clear and obvious (in the code and/or in docs). currentBoardInit if Mode.autoinst initial_propose = false else currentBoardInit end I can add similar tricks in GRUB2 module and let's see what will happen. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=834854 https://bugzilla.novell.com/show_bug.cgi?id=834854#c6 --- Comment #6 from Michael Chang <mchang@suse.com> 2013-08-22 06:39:10 UTC --- Created an attachment (id=553628) --> (http://bugzilla.novell.com/attachment.cgi?id=553628) DUD with yast2 and perl bootloader to test Rick, please help to test this DUD to see if the problem persists. Thanks a lot. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=834854 https://bugzilla.novell.com/show_bug.cgi?id=834854#c7 --- Comment #7 from Michael Chang <mchang@suse.com> 2013-08-22 06:41:05 UTC --- Created an attachment (id=553629) --> (http://bugzilla.novell.com/attachment.cgi?id=553629) debug patch The debug patch for narrowing down the problem. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=834854 https://bugzilla.novell.com/show_bug.cgi?id=834854#c8 --- Comment #8 from Thomas Renninger <trenn@suse.com> 2013-08-22 11:26:27 UTC --- Unfortunately this did not work. The DUD was taken, serial output from first boot: IPv6: ADDRCONF(NETDEV_CHANGE): enp0s25: link becomes ready Loading ftp://10.121.0.100/dud/bug-834854_ybl-pbl-bnc834854.dud - 100% Driver Update: perl-Bootloader-0.708-98.1.x86_64.rpm Driver Update: yast2-bootloader-3.0.2-4.1.x86_64.rpm Driver Updates added: perl-Bootloader-0.708-98.1.x86_64.rpm yast2-bootloader-3.0.2-4.1.x86_64.rpm ----------- But in 2nd stage the boot parameters were gone again. I double checked for the messages in the patch. I had to: cd /var/log/YaST2/ gunzip y2log-1.gz and there found that the + if Mode.autoinst code path has not been taken: grep "calling Propose with was_proposed" /var/log/YaST2/* /var/log/YaST2/y2log-1:2013-08-22 12:33:21 <1> haldus.arch.suse.de(6963) [Ruby] modules/BootGRUB2EFI.rb:128 calling Propose with was_proposed set is really bogus, clear it to force a re-propose The expected message: "autoinst mode we ignore meaningless was_proposed as it always set" did not show up. So either the patch was not in the rpm, for some reason the dud rpms were not taken or the patch does not work as expected. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=834854 https://bugzilla.novell.com/show_bug.cgi?id=834854#c9 Thomas Renninger <trenn@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO InfoProvider| |mchang@suse.com --- Comment #9 from Thomas Renninger <trenn@suse.com> 2013-08-22 11:28:59 UTC --- BTW: Is the perl-Bootloader rpm with the fixes from bnc#835691? This would significantly increase the platforms that can be used to test autoinstallation. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=834854 https://bugzilla.novell.com/show_bug.cgi?id=834854#c10 Thomas Renninger <trenn@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jreidinger@suse.com InfoProvider|mchang@suse.com |jreidinger@suse.com --- Comment #10 from Thomas Renninger <trenn@suse.com> 2013-08-22 14:31:36 UTC --- Ok, I got it...: There is: BootGRUB2.rb and BootGRUB2EFI.rb both have nearly the same code. At least these code parts are identical. I did an EFI installation... I adopted above patch to BootGRUB2EFI.rb and the boot parameters are saved and used in second stage as well. Josef: Would it be doable to merge BootGRUB2.rb and BootGRUB2EFI.rb files? That would avoid such issues in the future. I could imagine there were already other changes/fixes put into the one file, but were forgotten to be put into the other one as well. I will attach a diff between the files. Most is grub2 vs grub2efi strings, some comments and some code which looks like it should be double checked whether it should show up in the other file as well... -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=834854 https://bugzilla.novell.com/show_bug.cgi?id=834854#c11 --- Comment #11 from Thomas Renninger <trenn@suse.com> 2013-08-22 14:48:18 UTC --- Created an attachment (id=553743) --> (http://bugzilla.novell.com/attachment.cgi?id=553743) Diff between BootGRUB2EFI.rb and BootGRUB2.rb -> most is identical -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=834854 https://bugzilla.novell.com/show_bug.cgi?id=834854#c12 Josef Reidinger <jreidinger@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- InfoProvider|jreidinger@suse.com |snwint@suse.com --- Comment #12 from Josef Reidinger <jreidinger@suse.com> 2013-08-22 14:53:45 UTC --- Thomas - It can be possible to merge it, but maintainer of such code is Stephen Winterfeld, that should decide if it is better to split it or keep separated. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=834854 https://bugzilla.novell.com/show_bug.cgi?id=834854#c13 --- Comment #13 from Thomas Renninger <trenn@suse.com> 2013-08-22 18:30:27 UTC --- Puhh.., I sent a github pull request with Michael's patch, but adjusting both BootGRUB2.rb and BootGRUB2EFI.rb files: https://github.com/yast/yast-bootloader https://github.com/yast/yast-bootloader/pull/24 Would be great if this ends up in factory asap. I wonder what is the best way to track when it's worth to give factory a try again: /mounts/dist/factory/FACTORY/inst-source/ a try again. Doing: rpm -qp --changelog /mounts/dist/factory/FACTORY/inst-source/suse/x86_64/yast2-bootloader-3.0.1-1.2.x86_64.rpm |less from time to time is not perfect... -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=834854 https://bugzilla.novell.com/show_bug.cgi?id=834854#c14 --- Comment #14 from Michael Chang <mchang@suse.com> 2013-08-23 05:32:53 UTC --- Hi Thomas, Thanks a lot for heading this up. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=834854 https://bugzilla.novell.com/show_bug.cgi?id=834854#c15 --- Comment #15 from Michael Chang <mchang@suse.com> 2013-08-23 05:40:03 UTC --- I agree we should merge the code, because we might have to add power pc (open firmware) and s390 support, having separated source for each of them makes no sense for the idea of a unified loader. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=834854 https://bugzilla.novell.com/show_bug.cgi?id=834854#c16 --- Comment #16 from Josef Reidinger <jreidinger@suse.com> 2013-08-23 08:16:53 UTC --- (In reply to comment #15)
I agree we should merge the code, because we might have to add power pc (open firmware) and s390 support, having separated source for each of them makes no sense for the idea of a unified loader.
I agree. Original idea is to have split for each bootloader type ( elili, zipl, grub, plilo etc.) because it have different features, different options and need different setup. But if we have one unified loader with unified config, then it doesn't make sense to have it separately. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=834854 https://bugzilla.novell.com/show_bug.cgi?id=834854#c17 Steffen Winterfeldt <snwint@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED InfoProvider|snwint@suse.com | --- Comment #17 from Steffen Winterfeldt <snwint@suse.com> 2013-08-26 14:10:30 CEST --- Yes, the modules should definitely be merged. I've submitted Thomas' patch for now. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=834854 https://bugzilla.novell.com/show_bug.cgi?id=834854#c23 Julian Wolf <juwolf@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #23 from Julian Wolf <juwolf@suse.com> 2013-09-02 09:22:19 UTC --- Tested with factory on ain and tyne and seems to work now. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com