[Bug 531705] New: WindowMaker-applets-1.0-880.9: missing call to closedir
http://bugzilla.novell.com/show_bug.cgi?id=531705 Summary: WindowMaker-applets-1.0-880.9: missing call to closedir Classification: openSUSE Product: openSUSE 11.2 Version: Factory Platform: All OS/Version: openSUSE 11.1 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Found By: --- I just had a look at factory package WindowMaker-applets-1.0-880.9 For source code file wmmp3-0.12/mpg123ctl.c around line 100 is the source code for the function set_playlist. I notice the following line of code dp = opendir(directory); but I fail to notice any matching call to closedir. This looks like a resource leak to me. Suggest add a call to closedir. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=531705 shuang qiu <sqiu@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sqiu@novell.com AssignedTo|bnc-team-screening@forge.pr |mhrusecky@novell.com |ovo.novell.com | -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=531705 Michal Hrusecky <mhrusecky@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - None |P4 - Low Status|NEW |ASSIGNED Summary|WindowMaker-applets-1.0-880 |JJ: |.9: missing call to |WindowMaker-applets-1.0-880 |closedir |.9: missing call to | |closedir -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=531705 User rguenther@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=531705#c1 --- Comment #1 from Richard Guenther <rguenther@novell.com> 2009-10-17 08:55:05 MDT --- David, in case the issues are not introduced by a patch local to openSUSE please report the issues upstream. Packagers, please do not add openSUSE-local patches to fix this kind of errors but forward the bugs upstream and close the bugs as RESOLVED UPSTREAM. Note that it is perfectly fine to have "resource leaks" at the end of a program as the kernel will clean up for you. Manually freeing them only increases binary size and runtime. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com