[Bug 212936] New: asus_acpi is being loaded on all systems
https://bugzilla.novell.com/show_bug.cgi?id=212936 Summary: asus_acpi is being loaded on all systems Product: openSUSE 10.2 Version: Alpha 5 Platform: i386 OS/Version: Other Status: NEW Severity: Major Priority: P5 - None Component: Kernel AssignedTo: fseidel@novell.com ReportedBy: thoenig@novell.com QAContact: qa@suse.de CC: trenn@novell.com asus_acpi is being loaded on all systems. It seems that the module's init function does not work properly as modprobing it loads the module succuessfully on all systems even if the parameter "force" is not used. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=212936 ------- Comment #1 from fseidel@novell.com 2006-10-18 11:30 MST ------- Created an attachment (id=101952) --> (https://bugzilla.novell.com/attachment.cgi?id=101952&action=view) patch for asus_acpi module -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=212936 fseidel@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO Info Provider| |trenn@novell.com ------- Comment #2 from fseidel@novell.com 2006-10-18 11:32 MST ------- In my (current) opinion the trivial patch above should fix this. I tested this on a Thinkpad (where it now doesnt load anymore - as it would be expected) and on a Asus M6NE (where it still loads). Thomas, would do you think about this? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=212936 trenn@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED Info Provider|trenn@novell.com | ------- Comment #3 from trenn@novell.com 2006-10-19 04:17 MST ------- As discussed. It is a workaround. Frank tries to fix up the root cause. acpi_bus_driver_register should return -ENODEV if no device with has been found. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=212936 fseidel@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101952|0 |1 is obsolete| | ------- Comment #4 from fseidel@novell.com 2006-10-19 08:13 MST ------- Created an attachment (id=102036) --> (https://bugzilla.novell.com/attachment.cgi?id=102036&action=view) General fix for acpi_bus_register_driver Ok, i think this fix/patch is far better as it adresses the problems root. Thomas, i checked every single usage of acpi_bus_register_driver in the kernel for possible (negative) sideeffects and i think this patch should work just fine (but is currently mostly untested, besides a quick compile test). The patch also doesn't introduce a kabi break (i did _not_ change the signature of acpi_driver_attach back to return the count as int). -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=212936 fseidel@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO Info Provider| |trenn@novell.com ------- Comment #5 from fseidel@novell.com 2006-10-19 08:14 MST ------- Thomas, what do you think of this approach? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=212936 ------- Comment #6 from trenn@novell.com 2006-10-19 09:12 MST ------- +++ linux-2.6.18/drivers/acpi/processor_core.c @@ -909,7 +909,7 @@ static int __init acpi_processor_init(vo result = acpi_bus_register_driver(&acpi_processor_driver); if (result < 0) { remove_proc_entry(ACPI_PROCESSOR_CLASS, acpi_root_dir); - return 0; + return result; That's wrong. processor module is the only ACPI module that must also be loadable on acpi=off booted systems. Just revert this hunk. Not sure about the drv->register check. I'd prefer to revert the old code and let driver_attach return the amount of found devices. KAbi shouldn't be a problem as we want to have this in mainline anyway. Hmm as said I am not sure, just let it, it should be ok. Can you mail the next patch per mail pls. If you like to post this to linux-acpi list, CC Len Brown and me, pls. Check carefully which tags you should add (there is a howto somewhere how to commit patches to lkml). Some things: Add a [PATCH] tag at the beginning of subject. If you have several patches you should post like [PATCH 0/2] -> descriptive mail [PATCH 1/2] -> first of 2 patches . Best is you also add something like: Len can this be applied, pls. Ahh yes. lkml people want to have patches inlined at the end of mail. Len likes to have them as attachment. I normally inline and attach them. Then there should come something like this: Subject: 1 line description of patch description signed-off-by's (that is you and you can also put me in ..) diffstat patch -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=212936 ------- Comment #7 from fseidel@novell.com 2006-10-24 05:02 MST ------- Ok, since we recently agreed the "better" fix isn't doable in a short time and the patch from comment #1 is the way to go (for now at least).. i asked Thomas to commit it. Thomas, can you set this bug to resolved when your done with this? Thanks, Frank -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=212936 fseidel@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |RESOLVED Info Provider|trenn@novell.com | Resolution| |FIXED ------- Comment #8 from fseidel@novell.com 2006-10-25 04:18 MST ------- Ok, fix is submitted. Thank you, Thomas. Frank -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=212936 behlert@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
participants (1)
-
bugzilla_noreply＠novell.com