[Bug 213249] New: rcnetwork {stop,restart} fails
https://bugzilla.novell.com/show_bug.cgi?id=213249 Summary: rcnetwork {stop,restart} fails Product: openSUSE 10.2 Version: Alpha 5 plus Platform: Other OS/Version: Other Status: NEW Severity: Blocker Priority: P5 - None Component: Basesystem AssignedTo: werner@novell.com ReportedBy: thoenig@novell.com QAContact: qa@suse.de rcnetwork {stop,restart} fails. When running 'rcnetwork stop' on a system using NetworkManager the pid files are not being removed from /var/run/. This prevents 'rcnetwork start' to succeed afterwards. The script /etc/init.d/network did not change recently, the same applies to NetworkManager. Probably a bug in sysvinit (killproc). Adding Andreas and Seife to CC as they ran into the same issue. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=213249 ------- Comment #1 from thoenig@novell.com 2006-10-18 03:12 MST ------- Created an attachment (id=101839) --> (https://bugzilla.novell.com/attachment.cgi?id=101839&action=view) rcnetwork logs -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=213249 ------- Comment #3 from thoenig@novell.com 2006-10-21 16:32 MST ------- Now that was fun. Not. sysconfig recently introduced replacements for {check,kill}proc. Both are bash functions (part of sysconfig/network/scripts/functions). The checkproc function is broken as it returns 0 for a dead program with a stale PID file. cf. checkproc(8) "The exit codes without the option -k have the following LSB conform conditions:" 0 Program is running 1 No process but pid file found (...) Both NetworkManagerDispatcher and dhcdbd are not cleaning up their PID files on SIGTERM properly; however, NetworkManager itself does. I'm really having a hard time finding the one to blame for all the mess as the changelog for sysconfig does not even mention the introduction of those replacements for {check,kill}proc. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=213249 ------- Comment #4 from thoenig@novell.com 2006-10-21 16:33 MST ------- Created an attachment (id=102219) --> (https://bugzilla.novell.com/attachment.cgi?id=102219&action=view) The fix. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=213249 thoenig@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED ------- Comment #6 from thoenig@novell.com 2006-10-21 16:36 MST ------- Submitted to STABLE. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=213249 ------- Comment #7 from poeml@novell.com 2006-10-23 00:11 MST ------- The package changelog is indeed missing this change from the svn changelog. (There is a convention that committers to the sysconfig update the file "package/sysconfig.changes" in svn as well, which is used when rolling the next tarball/rpm. So normally the change would have ended up in the package changelog.) I hadn't worked on sysconfig for one year, and didn't think of this. Sorry about that. The change and its rationale can be found here: http://svn.suse.de/viewcvs/sysconfig?rev=1500&view=rev Thank you for the fix, and please forgive the aggravated debugging. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=213249 werner@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102219|text/x-patch |text/plain mime type| | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=213249 werner@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED | ------- Comment #8 from werner@novell.com 2006-11-02 03:16 MST ------- What is the reason of those ``replacements'' for pidof(8), checkproc(8), and killproc(8)??? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=213249 ------- Comment #9 from thoenig@novell.com 2006-11-02 03:20 MST ------- As far as I know the bug which was leading to this change was bug #55370. At least for systems using NetworkManager I am strongly for reverting this change. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=213249 thoenig@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|thoenig@novell.com |zoz@novell.com Status|REOPENED |NEW ------- Comment #10 from thoenig@novell.com 2006-11-02 03:30 MST ------- -> maintainer sysconfig -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=213249 zoz@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED ------- Comment #11 from zoz@novell.com 2006-11-02 04:24 MST ------- This bug is definitively fixed! What you guys want to discuss is bug 55370. Werner, if you have a better solution for the nfs-pidof-problem, then let me know. In bug 55370. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=213249 thoenig@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED | Version|Alpha 5 plus |Beta 2 plus ------- Comment #12 from thoenig@novell.com 2006-11-14 09:55 MST ------- The bash replacements are incomplete; at least they are not man enough to ensure that 'rcnetwork restart' work as before. By guess, 'rcnetwork restart' fails in 4 out of 10 runs. Please revert that change. The reporter of bug 55370 agrees on that. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=213249 thoenig@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|zoz@novell.com |poeml@novell.com Status|REOPENED |NEW ------- Comment #13 from thoenig@novell.com 2006-11-14 09:55 MST ------- -> Peter -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=213249 ------- Comment #14 from thoenig@novell.com 2006-11-14 09:56 MST ------- Comment #12 refers to systems running with NetworkManager. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=213249 poeml@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |poeml@novell.com AssignedTo|poeml@novell.com |zoz@novell.com Status|ASSIGNED |NEW ------- Comment #18 from poeml@novell.com 2006-11-17 05:07 MST ------- I am on vacation now. Can someone else please take care of the bug? Thanks. I suggest to 1) test if the /usr issue is fixed at all. As I wrote in the other bug, even though checkproc and killproc should work with it there may well be other parts of sysconfig which still would cause a hang. So far, I didn't see any test feedback. 2) unless we don't know that the /usr issue is fixed, the checkproc/killproc replacements are not worth much and we don't need to put up with other bugs that result from them. So I suggest again to simply revert the change, and be done with it. No need to have this blocker bug. If 1) works and we want handle disappeared nfs gracefully, it may be worth to debug the issue. rcnetwork restart worked reliably for me, I didn't saw any problems. But I didn't use NetworkManager, and I have no idea how it would depend on the way rcnetwork restart works internally. I don't know how it is integrated. BTW, I have talked to Werner about possible modifications in sysvinit's checkproc and killproc to handle the situation more gracefully. There may be a possibility because a stat() on file on a hanging nfs mount turns out to be interruptible at least. But we didn't come to a final conclusion about it yet. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=213249 zoz@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED ------- Comment #19 from zoz@novell.com 2006-11-17 09:14 MST ------- I'll revert all except of pidof in ifup-dhcp. Is that reasonable, Peter? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=213249 ------- Comment #20 from varkoly@novell.com 2006-11-17 11:32 MST ------- The problem of dhcdbd is fixed. Have a look at Bug 222267 - "dhcdbd do not remove pid file" Now dhcdbd removes the pid file and rcnetwork stop works fine. I've made some expirements with rcnetwork restart. After inserting "sleep 2" between stop and start it works fine too. But I do not know if it is a/the solution? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=213249 ------- Comment #21 from poeml@novell.com 2006-11-18 02:51 MST ------- Christian, it is fine to revert the change, with or without pidof replacement. Peter, if the dhcpbd fix resolves only a part of this bug, as you say, I'm not sure what remains. I'm not sure what to suggest here. Thanks for taking care! -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=213249 ------- Comment #22 from zoz@novell.com 2006-11-20 04:43 MST ------- Removed replacements for checkproc, klillproc, pidof. We now use a improved my_pidof only in ifup-dhcp. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=213249 zoz@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jg@novell.com Status|ASSIGNED |RESOLVED Resolution| |FIXED ------- Comment #23 from zoz@novell.com 2006-11-20 05:27 MST ------- Package for RC1 will be submitted by jg soon. You may test it if you like: /work/built/mbuild/hall-zoz-2 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=213249 tambet@ximian.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jharmon@novell.com ------- Comment #24 from tambet@ximian.com 2006-11-20 07:42 MST ------- *** Bug 220499 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=213249 behlert@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
participants (1)
-
bugzilla_noreply@novell.com