[Bug 1160729] New: Fix shadow 4.8 openQA fail
http://bugzilla.suse.com/show_bug.cgi?id=1160729 Bug ID: 1160729 Summary: Fix shadow 4.8 openQA fail Classification: openSUSE Product: openSUSE Tumbleweed Version: Current Hardware: Other OS: Other Status: NEW Severity: Normal Priority: P5 - None Component: Basesystem Assignee: bnc-team-screening@forge.provo.novell.com Reporter: mvetter@suse.com QA Contact: qa-bugs@suse.de Found By: --- Blocker: --- https://build.opensuse.org/request/show/757530 intended to update shadow from 4.7 to 4.8. DimStar notified that it creates the follwoing openQA failure: 2019-12-30 11:28:11 <5> install(3531) [zypp] Exception.cc(log):166 RpmDb.cc(doInstallPackage):2123 THROW: Subprocess failed. Error: RPM failed: groupadd -r -g 65533 nogroup 2019-12-30 11:28:11 <5> install(3531) [zypp] Exception.cc(log):166 groupadd -r -g 65534 nobody 2019-12-30 11:28:11 <5> install(3531) [zypp] Exception.cc(log):166 useradd -r -s /sbin/nologin -c "nobody" -g nobody -d /var/lib/nobody -u 65534 nobody 2019-12-30 11:28:11 <5> install(3531) [zypp] Exception.cc(log):166 useradd: invalid shell '/sbin/nologin' 2019-12-30 11:28:11 <5> install(3531) [zypp] Exception.cc(log):166 error: %prein(system-user-nobody-20170617-9.55.noarch) scriptlet failed, exit status 3 2019-12-30 11:28:11 <5> install(3531) [zypp] Exception.cc(log):166 error: system-user-nobody-20170617-9.55.noarch: install failed It is happening due to https://github.com/shadow-maint/shadow/pull/187 which makes `useradd -s` (setting the users shell) check whether the binary exists before setting it. The openQA test sets this to `/sbin/nologin` which seems to be provided by util-linux and not shadow on our distro. And in this test util-linux seems not to be installed. Serge noted on https://github.com/shadow-maint/shadow/issues/207 that shadow can provide nologin too. Possible solutions: 1. Install util-linux in the test scenario Maybe has other drawbacks like dependency loops during initial system setup/minimal systems? 2. Use shadows nologin (I didn't see a compile switch in our spec file that disables it..). 3. Add a patch that always allows nologin even if it's not there. Either always or when creating a system user (-r) Any feedback/ideas are welcome. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1160729
Michael Vetter
http://bugzilla.suse.com/show_bug.cgi?id=1160729
Michael Vetter
http://bugzilla.suse.com/show_bug.cgi?id=1160729
http://bugzilla.suse.com/show_bug.cgi?id=1160729#c1
--- Comment #1 from Michael Vetter
2. Use shadows nologin (I didn't see a compile switch in our spec file that disables it..).
Actually it is built. In the shadow.spec we remove shadows version of nologin by hand. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1160729
http://bugzilla.suse.com/show_bug.cgi?id=1160729#c2
--- Comment #2 from Ludwig Nussel
http://bugzilla.suse.com/show_bug.cgi?id=1160729
http://bugzilla.suse.com/show_bug.cgi?id=1160729#c3
--- Comment #3 from Michael Vetter
http://bugzilla.suse.com/show_bug.cgi?id=1160729
Michael Vetter
http://bugzilla.suse.com/show_bug.cgi?id=1160729
http://bugzilla.suse.com/show_bug.cgi?id=1160729#c4
--- Comment #4 from Michael Vetter
http://bugzilla.suse.com/show_bug.cgi?id=1160729
http://bugzilla.suse.com/show_bug.cgi?id=1160729#c5
--- Comment #5 from Dominique Leuenberger
On the other hand it might be possible that someone wants just shadow and no util-linux. I have no idea about all the minimal system and container patterns.
So I'm still thinking if the openQA test should not just pull in util-linux since they use it with the -s option.
Any consideration to change anything on openQA to address this is wrong. openQA does nothing else but actually load the DVD and run the installer from it - like any user would. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1160729
http://bugzilla.suse.com/show_bug.cgi?id=1160729#c6
--- Comment #6 from Dominique Leuenberger
http://bugzilla.suse.com/show_bug.cgi?id=1160729
http://bugzilla.suse.com/show_bug.cgi?id=1160729#c7
Michael Vetter
What WOULD work (and probably would not even be wrong)
Adjust system-user-nobody to have Requires(pre): /sbin/nologin
Adam suggested the same thing. I let Thorsten decide if he wants this for his package. In the meantime https://github.com/shadow-maint/shadow/pull/210 was created, to make the shell check not an error but only a warning. SR#764969 -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1160729
http://bugzilla.suse.com/show_bug.cgi?id=1160729#c8
--- Comment #8 from Swamp Workflow Management
http://bugzilla.suse.com/show_bug.cgi?id=1160729
http://bugzilla.suse.com/show_bug.cgi?id=1160729#c9
--- Comment #9 from Swamp Workflow Management
participants (1)
-
bugzilla_noreply@novell.com