[Bug 214278] New: rpm/beecrypt uses -fsigned-char
https://bugzilla.novell.com/show_bug.cgi?id=214278 Summary: rpm/beecrypt uses -fsigned-char Product: openSUSE 10.2 Version: Alpha 5 plus Platform: PowerPC OS/Version: Linux Status: NEW Severity: Normal Priority: P5 - None Component: Basesystem AssignedTo: mls@novell.com ReportedBy: olh@novell.com QAContact: qa@suse.de CC: power-bugs@forge.provo.novell.com beecrypt in rpm sources forces -fsigned-char. It probably shouldnt do that, better force 'signed char var' where needed. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=214278 mls@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO Info Provider| |olh@novell.com ------- Comment #1 from mls@novell.com 2006-10-23 04:54 MST ------- Well, I won't go through the code and fix all bad instances of char. Feel free to send me a well tested patch if you have enough spare time. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=214278 olh@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED ------- Comment #2 from olh@novell.com 2006-10-23 05:00 MST ------- Created an attachment (id=102259) --> (https://bugzilla.novell.com/attachment.cgi?id=102259&action=view) rpm.beecrypt-fsigned-char.patch -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=214278 ------- Comment #3 from mls@novell.com 2006-11-16 04:55 MST ------- so ppc uses signed char as default nowadays? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=214278 ------- Comment #4 from olh@novell.com 2006-11-16 05:38 MST ------- no it doesnt, thats why it is removed. -fsigned-char was nothing but a band aid to work around broken code. look for new 'comparison is always true/false due to limited range of data type' warnings with this patch applied. char x; if (x < 0); this has to be 'signed char x' -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=214278 mls@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |WONTFIX ------- Comment #5 from mls@novell.com 2006-11-16 07:58 MST ------- Forget it, I don't have time for that. Either you go through all the code, fix every issue, and do all the tests to ensure that it still works or I won't remove the -fsigned-char. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=214278 olh@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|WONTFIX | ------- Comment #6 from olh@novell.com 2006-11-16 08:34 MST ------- that doesnt fix the bugs, obviously... -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=214278 olh@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|mls@novell.com |olh@novell.com Status|REOPENED |ASSIGNED -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=214278 olh@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|olh@novell.com |mls@novell.com Status|ASSIGNED |NEW ------- Comment #7 from olh@novell.com 2006-11-17 14:52 MST ------- there are no bugs, and s390x has also no -fsigned-char the only bug is in lib/query.c on 64bit, u32 cant hold ULONG_MAX query.c:579: warning: comparison is always false due to limited range of data type query.c:673: warning: comparison is always false due to limited range of data type -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=214278 ------- Comment #8 from mls@novell.com 2006-11-17 15:04 MST ------- (query.c is not in beecrypt, but rpm) If beecrypt works without -fsigned-char, why was it added to the Makefile in the first place? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=214278 ------- Comment #9 from olh@novell.com 2006-11-19 03:23 MST ------- no idea why it was added, we wre all a bit clueless back in 2000. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=214278 Olaf Hering <olh@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Found By|Other |Development -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com