[Bug 843123] New: aaa_base: commit 4459f20 unexpected behavior
https://bugzilla.novell.com/show_bug.cgi?id=843123 https://bugzilla.novell.com/show_bug.cgi?id=843123#c0 Summary: aaa_base: commit 4459f20 unexpected behavior Classification: openSUSE Product: openSUSE Factory Version: 13.1 Beta 1 Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: P5 - None Component: Basesystem AssignedTo: werner@suse.com ReportedBy: lnussel@suse.com QAContact: qa-bugs@suse.de CC: fcrozat@suse.com Found By: --- Blocker: --- Commit 4459f20 apparently was intended to make systemd know about freshly installed initscripts by transparently re-loading the daemon. The code however seems to actually enable the script when just calling e.g. "status". + systemctl daemon-reload + systemctl --no-reload enable "${_rc_base}.service" 2> /dev/null -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=843123 https://bugzilla.novell.com/show_bug.cgi?id=843123#c1 Dr. Werner Fink <werner@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO InfoProvider| |lnussel@suse.com --- Comment #1 from Dr. Werner Fink <werner@suse.com> 2013-09-30 08:39:57 UTC --- Why are calling a status of a not enabled boot script? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=843123 https://bugzilla.novell.com/show_bug.cgi?id=843123#c2 Ludwig Nussel <lnussel@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW InfoProvider|lnussel@suse.com | --- Comment #2 from Ludwig Nussel <lnussel@suse.com> 2013-09-30 11:10:32 CEST --- maybe the script was only meant to be started manually? start/stop/status etc are not expected to cause the script to be run at next boot. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=843123 https://bugzilla.novell.com/show_bug.cgi?id=843123#c3 --- Comment #3 from Dr. Werner Fink <werner@suse.com> 2013-09-30 12:17:38 UTC --- Created an attachment (id=560839) --> (http://bugzilla.novell.com/attachment.cgi?id=560839) patch this one should resolve this bug as well as FATE #313323 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=843123 https://bugzilla.novell.com/show_bug.cgi?id=843123#c4 Dr. Werner Fink <werner@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |coolo@suse.com Resolution| |FIXED --- Comment #4 from Dr. Werner Fink <werner@suse.com> 2013-09-30 12:19:47 UTC --- As systemd uses inotify to detect fresh boot scripts it is not required to reload systemd for this case. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=843123 https://bugzilla.novell.com/show_bug.cgi?id=843123#c5 --- Comment #5 from Frederic Crozat <fcrozat@suse.com> 2013-09-30 12:27:34 UTC --- (In reply to comment #4)
As systemd uses inotify to detect fresh boot scripts it is not required to reload systemd for this case.
where did you saw that ? systemd doesn't parse modified or new files when they appears, either services in /usr/lib/systemd/system nor initscripts in /etc/init.d/ -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=843123 https://bugzilla.novell.com/show_bug.cgi?id=843123#c6 --- Comment #6 from Frederic Crozat <fcrozat@suse.com> 2013-09-30 12:29:22 UTC --- (In reply to comment #5)
(In reply to comment #4)
As systemd uses inotify to detect fresh boot scripts it is not required to reload systemd for this case.
where did you saw that ? systemd doesn't parse modified or new files when they appears, either services in /usr/lib/systemd/system nor initscripts in /etc/init.d/
Ah, my mistake, after reading your patch, I see what you mean. inotify is used to detect the directory has been modified, not each file. This patch will cause "daemon-reload" even if the specific initscript hasn't been updated. I guess we can live with it.. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=843123 https://bugzilla.novell.com/show_bug.cgi?id=843123#c7 --- Comment #7 from Dr. Werner Fink <werner@suse.com> 2013-09-30 12:34:42 UTC --- (In reply to comment #6) .. yep, I hope so. I've just done vi /etc/init.d/testt chmod 755 /etc/init.d/testt and detected that "NeedDaemonReload" was "no" .. but if I've modified the file further then I saw "yes" -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=843123 https://bugzilla.novell.com/show_bug.cgi?id=843123#c8 --- Comment #8 from Bernhard Wiedemann <bwiedemann@suse.com> 2013-09-30 15:00:24 CEST --- This is an autogenerated message for OBS integration: This bug (843123) was mentioned in https://build.opensuse.org/request/show/201465 Factory / aaa_base -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=843123 https://bugzilla.novell.com/show_bug.cgi?id=843123#c9 --- Comment #9 from Ludwig Nussel <lnussel@suse.com> 2013-09-30 15:10:36 CEST --- instead of the fragile shell script magic, would it be possible for systemd to automatically reload if needed? something like systemctl --auto-reload $1 "${_rc_base}.service"? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=843123 https://bugzilla.novell.com/show_bug.cgi?id=843123#c10 --- Comment #10 from Dr. Werner Fink <werner@suse.com> 2013-09-30 13:17:39 UTC --- (In reply to comment #9) Talk to upstream :) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=843123 https://bugzilla.novell.com/show_bug.cgi?id=843123#c11 --- Comment #11 from Bernhard Wiedemann <bwiedemann@suse.com> 2013-10-01 17:01:52 CEST --- This is an autogenerated message for OBS integration: This bug (843123) was mentioned in https://build.opensuse.org/request/show/201616 Factory / aaa_base -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=843123 https://bugzilla.novell.com/show_bug.cgi?id=843123#c12 Tomáš Chvátal <tchvatal@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tchvatal@suse.com --- Comment #12 from Tomáš Chvátal <tchvatal@suse.com> 2013-10-10 08:37:14 UTC --- If you guys got it running just fine it would be nice to create Update for 13.1 containing just this fix, the factory version contain some more changes we should not put there... -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=843123 https://bugzilla.novell.com/show_bug.cgi?id=843123#c13 --- Comment #13 from Dr. Werner Fink <werner@suse.com> 2013-10-10 08:43:26 UTC --- I agree but Ludwig does not. IMHO both the mksh as well as my fix are perfect. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com