[Bug 605085] New: Drop vmware-guest-kmp packages and use them from the upstream kernel
http://bugzilla.novell.com/show_bug.cgi?id=605085 http://bugzilla.novell.com/show_bug.cgi?id=605085#c0 Summary: Drop vmware-guest-kmp packages and use them from the upstream kernel Classification: openSUSE Product: openSUSE 11.3 Version: Factory Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: P5 - None Component: Live Medium AssignedTo: dominique.leuenberger@tmf-group.com ReportedBy: aj@novell.com QAContact: qa@suse.de CC: mkurc@novell.com, jeffm@novell.com, dominique.leuenberger@tmf-group.com, mseben@novell.com, jsavanyo@vmware.com, dtor@vmware.com, pmarchand@novell.com Depends on: 591085 Found By: Product Management Blocker: --- As John said in bug #591085: "You should also be aware that we are in the process of upstreaming our kernel drivers and expect them to be included in the base kernel. This will eliminate the need for users to hassle with building and installing drivers. The vmxnet3 virtual NIC was in 2.6.32, the vmw_pvscsi virtual HBA was in 2.6.33 and the balloon driver (vmmemctl) has been accepted recently into 2.6.34. The vmxnet3 and vmw_pvscsi should already be in 11.3 and hopefully vmmemctl will be in milestone7." Currently, the vmware-guest-kmp package contains: /lib/modules/2.6.34-rc5-6-default/updates/pvscsi.ko /lib/modules/2.6.34-rc5-6-default/updates/vmblock.ko /lib/modules/2.6.34-rc5-6-default/updates/vmci.ko /lib/modules/2.6.34-rc5-6-default/updates/vmhgfs.ko /lib/modules/2.6.34-rc5-6-default/updates/vmmemctl.ko /lib/modules/2.6.34-rc5-6-default/updates/vmsync.ko /lib/modules/2.6.34-rc5-6-default/updates/vmxnet.ko /lib/modules/2.6.34-rc5-6-default/updates/vsock.ko Let's check what's in our kernel. Jeff, is everything enabled there? Which ones should be removed from the guest-kmp package? -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=605085 http://bugzilla.novell.com/show_bug.cgi?id=605085#c1 Andreas Jaeger <aj@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO InfoProvider| |jeffm@novell.com --- Comment #1 from Andreas Jaeger <aj@novell.com> 2010-05-12 08:56:57 UTC --- Setting needinfo for Jeff. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=605085 http://bugzilla.novell.com/show_bug.cgi?id=605085#c2 --- Comment #2 from Dominique Leuenberger <dominique.leuenberger@tmf-group.com> 2010-05-31 08:42:22 UTC --- I got this diff in my local branch of open-vm-tools, which makes it very easy to enable / disable modules based on the openSUSE release (assuming that newer releases will always require less than older releases): Index: open-vm-tools.changes =================================================================== --- open-vm-tools.changes (revision 77cd29d3aceb5fac85e76ceae29edd44) +++ open-vm-tools.changes (working copy) @@ -1,3 +1,9 @@ +------------------------------------------------------------------- +Mon May 31 08:37:32 UTC 2010 - dimstar@opensuse.org + +- Better logic to easily disable modules that got inlcluded in the + Linux Kernel. + ------------------------------------------------------------------- Thu Apr 22 11:25:39 CEST 2010 - dimstar@opensuse.org Index: open-vm-tools.spec =================================================================== --- open-vm-tools.spec (revision 77cd29d3aceb5fac85e76ceae29edd44) +++ open-vm-tools.spec (working copy) @@ -20,7 +20,16 @@ # exclude AMD PCnet32 LANCE pci.id from Supplements list [bnc#397554] %define __find_supplements sh -c '/usr/lib/rpm/find-supplements %{name} | grep -v pci:v00001022d00002000' -%define build_vmxnet3 0%{suse_version} <= 1120 + +# Modules that have to be build up to version 11.3 +%if 0%{suse_version} <= 1130 +%define mod1130 vmblock vmhgfs vmsync vmxnet vmci vsock +%endif +# Modules that are needed up to openSUSE 11.2 (kernel in 11.3 includes them) +%if 0%{suse_version} <= 1120 +%define mod1120 pvscsi vmemctl vmxnet3 +%endif + Name: open-vm-tools Group: System/Emulators/PC @@ -68,11 +77,7 @@ Requires: vmware-guest-kmp Supplements: modalias(pci:v000015ADd*sv*sd*bc*sc*i*) -%if %build_vmxnet3 -%define vm_modules vmblock vmhgfs vmmemctl vmsync vmxnet vmci vsock pvscsi vmxnet3 -%else -%define vm_modules vmblock vmhgfs vmmemctl vmsync vmxnet vmci vsock pvscsi -%endif +%define vm_modules %{mod1130} %{mod1120} %suse_kernel_module_package -n vmware-guest -p %{SOURCE98} xen um @jeff: Of course this is only true if the modules are really enabled in the kernel, in which case I would forward this diff and the bug would be solved :) -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=605085 http://bugzilla.novell.com/show_bug.cgi?id=605085#c3 Jeff Mahoney <jeffm@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW InfoProvider|jeffm@novell.com | --- Comment #3 from Jeff Mahoney <jeffm@novell.com> 2010-06-04 20:42:59 UTC --- Assuming vmmemctl is vmware_balloon, it looks ok except that vmxnet3 was included in 11.3 as well. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=605085 http://bugzilla.novell.com/show_bug.cgi?id=605085#c4 --- Comment #4 from Dmitry Torokhov <dtor@vmware.com> 2010-06-04 20:50:00 UTC --- Yes, vmware_balloon is version of vmmemctl submitted and accepted into mainline. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=605085 http://bugzilla.novell.com/show_bug.cgi?id=605085#c5 Andreas Jaeger <aj@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO InfoProvider| |jeffm@novell.com --- Comment #5 from Andreas Jaeger <aj@novell.com> 2010-06-07 07:40:28 UTC --- Jeff, what needs to be done based on your comment "except that vmxnet3 was included in 11.3 as well?" for 11.3? -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=605085 http://bugzilla.novell.com/show_bug.cgi?id=605085#c6 --- Comment #6 from Dominique Leuenberger <dominique.leuenberger@tmf-group.com> 2010-06-09 21:57:22 UTC --- The current open-vm-tools package in Factory has those modules disabled already: pvscsi vmmemctl vmxnet3 Thus only leaving in what is not available in the kernel by default. Checkin rpm -ql kernel-desktop shows that those three kernel modules are enabled on our kernel package and distributed. @AJ: I guess this is about what we can drop from the package for now? -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=605085 http://bugzilla.novell.com/show_bug.cgi?id=605085#c7 Andreas Jaeger <aj@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW InfoProvider|jeffm@novell.com | --- Comment #7 from Andreas Jaeger <aj@novell.com> 2010-06-10 21:46:22 UTC --- Hope this is it. So, I assume we can close this for 11.3 - and should reevaluate with each new kernel version that we import -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=605085 http://bugzilla.novell.com/show_bug.cgi?id=605085#c8 --- Comment #8 from John Savanyo <jsavanyo@vmware.com> 2010-06-10 23:03:09 UTC --- It appears that you are packaging the unstable version of open-vm-tools and we have found that this is not working with our latest Workstation and Fusion releases. So we have released a new "stable" version of open-vm-tools that should be more compatible with our latest releases. Can you switch to using the "stable" version? The release is available from sourceforge.net's project page (in the stable-8.4.x folder) and also from git (branch stable-8.4.x, tag stable-8.4.2-261024). -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=605085 http://bugzilla.novell.com/show_bug.cgi?id=605085#c9 --- Comment #9 from John Savanyo <jsavanyo@vmware.com> 2010-06-11 00:14:28 UTC --- By the way, if it's too difficult to upgrade to the stable release, then we prefer that you disable/remove the tools since we believe the unstable release does not work well with our new releases. If users leave the unstable tools in place they will not know the problem comes from those unstable tools. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=605085 http://bugzilla.novell.com/show_bug.cgi?id=605085#c11 --- Comment #11 from Andreas Jaeger <aj@novell.com> 2010-06-25 09:01:21 UTC --- Dominique, have you been able to update the tools? -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=605085 http://bugzilla.novell.com/show_bug.cgi?id=605085#c12 --- Comment #12 from Dominique Leuenberger <dominique.leuenberger@tmf-group.com> 2010-06-25 09:03:44 UTC --- The building of version 8.4.x did not succeed a single time yet. Seems I especially run into the same issues I resolved with upstream almost a year ago on the 'unstable' series. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=605085 http://bugzilla.novell.com/show_bug.cgi?id=605085#c13 --- Comment #13 from Andreas Jaeger <aj@novell.com> 2010-06-25 09:19:09 UTC --- That's really sad :-( Then let's get 8.4.x building first and release it later via an online update. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=605085 https://bugzilla.novell.com/show_bug.cgi?id=605085#c14 Dominique Leuenberger <dimstar@opensuse.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #14 from Dominique Leuenberger <dimstar@opensuse.org> 2011-11-20 18:37:10 UTC --- We switched to the stable tree (version 8.8) on 12.1... I consider this 'fixed' We'll keep track of more and more modules to be removable, as they are being upstreamed. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=605085 http://bugzilla.novell.com/show_bug.cgi?id=605085#c15 --- Comment #15 from Bernhard Wiedemann <bwiedemann@suse.com> --- This is an autogenerated message for OBS integration: This bug (605085) was mentioned in https://build.opensuse.org/request/show/41214 Factory / open-vm-tools -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com