[Bug 1200251] New: dracut 055+suse.252.g4988b0bf: convertfs.sh: ignore commented lines in fstab
https://bugzilla.suse.com/show_bug.cgi?id=1200251 Bug ID: 1200251 Summary: dracut 055+suse.252.g4988b0bf: convertfs.sh: ignore commented lines in fstab Classification: openSUSE Product: openSUSE Distribution Version: Leap 15.4 Hardware: 64bit OS: openSUSE Leap 15.4 Status: NEW Severity: Normal Priority: P5 - None Component: Basesystem Assignee: screening-team-bugs@suse.de Reporter: andihartmann@freenet.de QA Contact: qa-bugs@suse.de Found By: --- Blocker: --- Created attachment 859439 --> https://bugzilla.suse.com/attachment.cgi?id=859439&action=edit convertfs.sh: Patch: ignore commented lines in fstab If there are commented lines in fstab, convertfs.sh creates an error. The attached diff resolves the problem. e.g.: #/dev/raid0/var /var ext4 acl,user_xattr 1 2 /dev/nvme/var /var xfs noatime,nodiratime 1 2 Goal: ignore the commented line! -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1200251 Antonio Feijoo <antonio.feijoo@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |antonio.feijoo@suse.com Assignee|screening-team-bugs@suse.de |dracut-maintainers@suse.de -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1200251 https://bugzilla.suse.com/show_bug.cgi?id=1200251#c1 Thomas Blume <thomas.blume@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |thomas.blume@suse.com --- Comment #1 from Thomas Blume <thomas.blume@suse.com> --- Thanks for the patch, just a little nitpick. Not sure whether the hash character can occur in any mount name or parameter, but just to be on the safe side, I would only consider it at the beginning of the line. So, I will use: --> -VARDEV=$(sed -n '/ \/var /s/\([[:graph:]]* \).*/\1/p' /sysroot/etc/fstab) -VARFS=$(sed -n '/ \/var /s/[[:graph:]]* * [[:graph:]]* *\([[:graph:]]* \).*/\1/p' /sysroot/etc/fstab) +VARDEV=$(sed -n -e 's/^\#.*//' -e '/ \/var /s/\([[:graph:]]* \).*/\1/p' /sysroot/etc/fstab) +VARFS=$(sed -n -e 's/^\#.*//' -e '/ \/var /s/[[:graph:]]* * [[:graph:]]* *\([[:graph:]]* \).*/\1/p' /sysroot/etc/fstab) --< -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1200251 https://bugzilla.suse.com/show_bug.cgi?id=1200251#c2 --- Comment #2 from Klaus Mueller <andihartmann@freenet.de> --- You're perfectly right - that's what I actually meant - but I forgot the leading '^'. Thanks for your accurate check! -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1200251 https://bugzilla.suse.com/show_bug.cgi?id=1200251#c3 --- Comment #3 from Thomas Blume <thomas.blume@suse.com> --- (In reply to Klaus Mueller from comment #2)
You're perfectly right - that's what I actually meant - but I forgot the leading '^'. Thanks for your accurate check!
Thanks for the confirmation. The patch has been submitted to git and will be part of one of the next dracut updates. -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1200251 https://bugzilla.suse.com/show_bug.cgi?id=1200251#c5 Antonio Feijoo <antonio.feijoo@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #5 from Antonio Feijoo <antonio.feijoo@suse.com> --- Fix included since dracut-055+suse.279.g3b3c36b2 -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1200251 https://bugzilla.suse.com/show_bug.cgi?id=1200251#c6 --- Comment #6 from Swamp Workflow Management <swamp@suse.de> --- SUSE-RU-2022:2625-1: An update that has 12 recommended fixes can now be installed. Category: recommended (important) Bug References: 1177461,1184970,1187654,1195047,1195508,1195604,1196267,1197635,1197967,1200236,1200251,1200360 CVE References: JIRA References: Sources used: openSUSE Leap 15.4 (src): dracut-055+suse.279.g3b3c36b2-150400.3.5.1 SUSE Linux Enterprise Module for Basesystem 15-SP4 (src): dracut-055+suse.279.g3b3c36b2-150400.3.5.1 NOTE: This line indicates an update has been released for the listed product(s). At times this might be only a partial fix. If you have questions please reach out to maintenance coordination. -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠suse.com