[Bug 222948] New: New UI builtin: TextMode
https://bugzilla.novell.com/show_bug.cgi?id=222948 Summary: New UI builtin: TextMode Product: openSUSE 10.3 Version: unspecified Platform: Other OS/Version: Other Status: NEW Severity: Enhancement Priority: P5 - None Component: YaST2 AssignedTo: sh@novell.com ReportedBy: locilka@novell.com QAContact: jsrain@novell.com Time to time, we need to design the UI with different layout for Qt and ncurses. Currently we use this way: map display_info = UI::GetDisplayInfo(); boolean textmode = display_info["TextMode"]:false; For this case, we get all pieces of information about the UI but we need only the "TextMode" key. I'd suggest adding new UI:: builtin boolean UI::TextMode. It should be faster and easier to deal with. I'll attach proposed patch (just guessing how it could look like). -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=222948 ------- Comment #1 from locilka@novell.com 2006-11-21 07:53 MST ------- Created an attachment (id=106400) --> (https://bugzilla.novell.com/attachment.cgi?id=106400&action=view) Proposed patch -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=222948 sh@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED ------- Comment #2 from sh@novell.com 2006-11-21 08:04 MST ------- It's easy enough to do that. We should take care, however, to use that only if it is absolutely necessary: It breaks the UI abstraction - the abstraction we went through so much pain for and paid so many tradeoffs for. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=222948 ------- Comment #3 from locilka@novell.com 2006-11-21 08:09 MST ------- Yes, you are absolutely right about the broken abstraction, nevertheless there are still many cases where it would be helpful. For instance, the very last case in SVN (example): integer space = 5; if (UI::TextMode) space = 2; Sometimes we have to deal with it, despite it goes against the idea of one UI definition and different approach in different UI types. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=222948 ------- Comment #4 from sh@novell.com 2006-11-21 08:49 MST ------- Hm - those spacings are designed to look very much the same in Qt and NCurses. The basic size (of a default size dialog) corresponds to 80x25 in both Qt and NCurses. For spacings that kind of thing should definitely NOT be used. This is a sure recipe for disaster. There are cases where dialogs are simply too cramped to make them fit on the screen properly in NCurses. That's where I see legitimate use of this feature. The preferable way, of course, would be to have the dialog less cramped in the first place; this is also a sign of too much complexity. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=222948 User sh@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=222948#c5 Stefan Hundhammer <sh@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #5 from Stefan Hundhammer <sh@novell.com> 2008-03-26 10:16:26 MST --- Added UI::TextMode(). Available with yast2-ycp-ui-bindings-2.16.40. The concerns about using this still remain the same. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=222948 User locilka@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=222948#c6 --- Comment #6 from Lukas Ocilka <locilka@novell.com> 2008-03-26 11:00:15 MST --- Thanks :) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com