[Bug 348980] New: [patch] ogmmerge crashes on x86-64 because of typo
https://bugzilla.novell.com/show_bug.cgi?id=348980 Summary: [patch] ogmmerge crashes on x86-64 because of typo Product: openSUSE 10.3 Version: Final Platform: x86-64 OS/Version: openSUSE 10.3 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: tony@daylessday.org QAContact: qa@suse.de Found By: --- ogmmerge (from ogmtools package) crashes when trying to merge two files on openSUSE 10.3 64bit. The backtrace looked like this: #0 vorbis_comment_dup (vc=0x631b40) at vorbis_header_utils.c:163 #1 0x0000000000410636 in video_packetizer_c::produce_header_packets (this=0x631c50) at p_video.cpp:129 #2 0x0000000000410026 in video_packetizer_c::process (this=0x631c50, buf=0x6715b0 "", size=3286, num_frames=1, key=1, last_frame=0) at p_video.cpp:174 #3 0x0000000000405d8d in avi_reader_c::read (this=0x6312e0) at r_avi.cpp:401 #4 0x0000000000405029 in main (argc=5, argv=0x7fff55714448) at ogmmerge.cpp:956 vorbis_header_utils.c, line 163: memcpy(new_vc->comment_lengths, vc->comment_lengths, (vc->comments + 1) * sizeof(char *)); Apparently, lengths are not (char *), they are ints, so the line should look like this: memcpy(new_vc->comment_lengths, vc->comment_lengths, (vc->comments + 1) * sizeof(int)); This change fixed the crash. See the patch attached. The bug's been reported to the original author. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=348980
User tony@daylessday.org added comment
https://bugzilla.novell.com/show_bug.cgi?id=348980#c1
--- Comment #1 from Antony Dovgal
https://bugzilla.novell.com/show_bug.cgi?id=348980
Mark Gordon
https://bugzilla.novell.com/show_bug.cgi?id=348980
Andreas Schwab
https://bugzilla.novell.com/show_bug.cgi?id=348980
User schwab@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=348980#c2
Andreas Schwab
https://bugzilla.novell.com/show_bug.cgi?id=348980
User tony@daylessday.org added comment
https://bugzilla.novell.com/show_bug.cgi?id=348980#c3
--- Comment #3 from Antony Dovgal
participants (1)
-
bugzilla_noreply@novell.com