[Bug 543440] New: firebird-2.1.3.18185.0-1.7: missing call to fclose
http://bugzilla.novell.com/show_bug.cgi?id=543440 Summary: firebird-2.1.3.18185.0-1.7: missing call to fclose Classification: openSUSE Product: openSUSE 11.2 Version: Factory Platform: All OS/Version: openSUSE 11.1 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Found By: --- I just had a look at factory package firebird-2.1.3.18185.0-1.7 source code file Firebird-2.1.3.18185-0/extern/btyacc/readskel.c function read_skel local variable fp. I notice the following code if (!(fp = fopen(name, "r"))) but I fail to notice any matching call to fclose. This looks like a resource leak to me. Suggest add a call to fclose near the end of the block to plug the leak. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=543440 Marcus Meissner <meissner@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |meissner@novell.com AssignedTo|bnc-team-screening@forge.pr |makowski.opensuse@gmail.com |ovo.novell.com | -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=543440 User makowski.opensuse@gmail.com added comment http://bugzilla.novell.com/show_bug.cgi?id=543440#c1 Philippe Makowski <makowski.opensuse@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution| |UPSTREAM --- Comment #1 from Philippe Makowski <makowski.opensuse@gmail.com> 2009-10-05 08:01:52 MDT --- Reported upstream but there is no actual resource leak here - at least how we understand it in DB server. btyacc is command line utility, which starts, reads skeleton file, parses grammar and exits. I.e. function that reads skeleton may be called only once, and keeping file opened has no bad results -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply@novell.com