[Bug 529028] New: OpenIPMI-2.0.14-2.27: missing call to fclose
http://bugzilla.novell.com/show_bug.cgi?id=529028 Summary: OpenIPMI-2.0.14-2.27: missing call to fclose Classification: openSUSE Product: openSUSE 11.2 Version: Factory Platform: All OS/Version: openSUSE 11.1 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Found By: --- I just had a look at factory package OpenIPMI-2.0.14-2.27 For source code file OpenIPMI-2.0.14/lanserv/lanserv_config.c around line 350 is the source code for the function lanserv_read_config. I notice the following line of code FILE *f = fopen(config_file, "r"); but I fail to find a matching call to fclose. This seems to be a resource leak. Suggest code rework, possibly by adding call to fclose. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=529028 Marcus Meissner <meissner@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team-screening@forge.pr |duwe@novell.com |ovo.novell.com | -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=529028 User rguenther@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=529028#c1 --- Comment #1 from Richard Guenther <rguenther@novell.com> 2009-10-17 08:54:54 MDT --- David, in case the issues are not introduced by a patch local to openSUSE please report the issues upstream. Packagers, please do not add openSUSE-local patches to fix this kind of errors but forward the bugs upstream and close the bugs as RESOLVED UPSTREAM. Note that it is perfectly fine to have "resource leaks" at the end of a program as the kernel will clean up for you. Manually freeing them only increases binary size and runtime. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=529028 http://bugzilla.novell.com/show_bug.cgi?id=529028#c Torsten Duwe <duwe@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=529028 http://bugzilla.novell.com/show_bug.cgi?id=529028#c2 Torsten Duwe <duwe@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #2 from Torsten Duwe <duwe@novell.com> 2010-03-11 16:13:15 UTC --- fix submitted to project systemmanagement -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com