[Bug 327318] New: pure-ftpd does not apply umask setting correctly due to auth mods overwriting umask (0)
https://bugzilla.novell.com/show_bug.cgi?id=327318 Summary: pure-ftpd does not apply umask setting correctly due to auth mods overwriting umask(0) Product: openSUSE 10.3 Version: RC 1 Platform: Other OS/Version: Other Status: NEW Severity: Major Priority: P5 - None Component: Network AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: pieter.hollants@novell.com QAContact: qa@suse.de Found By: --- Created an attachment (id=173969) --> (https://bugzilla.novell.com/attachment.cgi?id=173969) Fix for described bug Confirmed for pure-ftpd 1.0.20-1.0.22pre: In theory, configuring pure-ftpd to something like Umask xxx:000 should result in created directories to have mode 777. This require a umask(0) call in pure-ftpd. While this is done at startup, a call to the authentication module, such as the PAM one, will overwrite this later, so umask will become e.g. 022 again, causing the configured umask to be applied against 755 instead of the expected 777. Thus, only umasks that take away more permissions than the default umask will work. A permissive umask such as 002 will not. Applied patch fixes this by calling umask(0) a second time after pw_check() has returned. One-liner, safe to apply IMO. Patch will be submitted upstream, but won't make it in time for 10.3, so I strongly propose to apply to the 1.0.21 used for 10.3 (and 10.2, update package there possible, too?). -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=327318 Andreas Jaeger <aj@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team-screening@forge.provo.novell.com |mskibbe@novell.com -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=327318#c1 Michael Skibbe <mskibbe@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO Info Provider| |ast@novell.com --- Comment #1 from Michael Skibbe <mskibbe@novell.com> 2007-09-24 04:30:34 MST --- i tested your patch and it work. afaik it's to late for 10.3 and i'm not sure if this is important enough to make an update for 10.2 anja: what do you say to make an update from this patch (for 10.2 and 10.3)? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=327318#c3 Michael Skibbe <mskibbe@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |LATER --- Comment #3 from Michael Skibbe <mskibbe@novell.com> 2007-09-28 00:57:05 MST --- ok i mark this for later -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply@novell.com