[Bug 227455] New: libapr1-1.2.7-23: comparison with string literal
![](https://seccdn.libravatar.org/avatar/3035b38ff33cf86f480bb169b8500b80.jpg?s=120&d=mm&r=g)
https://bugzilla.novell.com/show_bug.cgi?id=227455 Summary: libapr1-1.2.7-23: comparison with string literal Product: openSUSE 10.2 Version: RC 5 Platform: All OS/Version: SuSE Other Status: NEW Severity: Normal Priority: P5 - None Component: Basesystem AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de I just tried to compile package libapr1-1.2.7-23 The compiler said strings/apr_snprintf.c:1261: warning: comparison with string literal The source code is if (prefix_char != NUL && s != S_NULL && s != char_buf) { but #define S_NULL "(null)" Suggest new code if (prefix_char != NUL && (strcmp( s, S_NULL) != 0) && s != char_buf) { -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
![](https://seccdn.libravatar.org/avatar/3035b38ff33cf86f480bb169b8500b80.jpg?s=120&d=mm&r=g)
https://bugzilla.novell.com/show_bug.cgi?id=227455 mhorvath@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team- |poeml@novell.com |screening@forge.provo.novell| |.com | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
![](https://seccdn.libravatar.org/avatar/3035b38ff33cf86f480bb169b8500b80.jpg?s=120&d=mm&r=g)
https://bugzilla.novell.com/show_bug.cgi?id=227455 ------- Comment #1 from sndirsch@novell.com 2007-01-16 15:30 MST ------- Feel free to close as duplicate of Bug #233655. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
![](https://seccdn.libravatar.org/avatar/3035b38ff33cf86f480bb169b8500b80.jpg?s=120&d=mm&r=g)
https://bugzilla.novell.com/show_bug.cgi?id=227455 ------- Comment #2 from mskibbe@novell.com 2007-01-17 03:29 MST ------- Created an attachment (id=113313) --> (https://bugzilla.novell.com/attachment.cgi?id=113313&action=view) proposed patch i reported this issue upstream (http://issues.apache.org/bugzilla/ - #41388) and add this patch -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
![](https://seccdn.libravatar.org/avatar/3035b38ff33cf86f480bb169b8500b80.jpg?s=120&d=mm&r=g)
https://bugzilla.novell.com/show_bug.cgi?id=227455 mskibbe@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |INVALID ------- Comment #3 from mskibbe@novell.com 2007-01-19 00:39 MST ------- Lucian Adrian Grijincu means this isn't a bug. the patch do not the same as the current code. the current code is correct => bug is invalid -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
participants (1)
-
bugzilla_noreply@novell.com