[Bug 1157921] New: Firewall-applet icon is barely visible with KDE dark themes
http://bugzilla.opensuse.org/show_bug.cgi?id=1157921 Bug ID: 1157921 Summary: Firewall-applet icon is barely visible with KDE dark themes Classification: openSUSE Product: openSUSE Tumbleweed Version: Current Hardware: x86-64 OS: Other Status: NEW Severity: Normal Priority: P5 - None Component: KDE Workspace (Plasma) Assignee: opensuse-kde-bugs@opensuse.org Reporter: fkrueger@mailbox.org QA Contact: qa-bugs@suse.de Found By: --- Blocker: --- Created attachment 825076 --> http://bugzilla.opensuse.org/attachment.cgi?id=825076&action=edit KDE control panel with missing firewall-applet icon (between bell and battery) After today's update to TW20191126 with KDE Plasma 5.17.3 the firewall-applet icon in the control panel is almost invisible for the dark themes breeze dark, oxygen, and openSUSEdark (see attachment). It works fine for the light ones. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1157921
http://bugzilla.opensuse.org/show_bug.cgi?id=1157921#c1
--- Comment #1 from Frank Kruger
http://bugzilla.opensuse.org/show_bug.cgi?id=1157921
http://bugzilla.opensuse.org/show_bug.cgi?id=1157921#c2
Wolfgang Bauer
http://bugzilla.opensuse.org/show_bug.cgi?id=1157921
http://bugzilla.opensuse.org/show_bug.cgi?id=1157921#c3
--- Comment #3 from Frank Kruger
What *icon theme* are you using? Try switching to breeze-dark.
I am using "breeze-dark" as icon theme. By the way, choosing "breeze-dark" as global design, all plasma themes are working fine. However, choosing "breeze" or "openSUSE" globally and one of the dark themes for the plasma design leads to the above-mentiond issue. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1157921
http://bugzilla.opensuse.org/show_bug.cgi?id=1157921#c4
--- Comment #4 from Wolfgang Bauer
I am using "breeze-dark" as icon theme. To be sure, I mean systemsettings5->Icons.
grep -A1 "\[Icons\]" ~/.config/kdeglobals
By the way, choosing "breeze-dark" as global design, all plasma themes are working fine. However, choosing "breeze" or "openSUSE" globally and one of the dark themes for the plasma design leads to the above-mentiond issue. AFAICS there is no systemtray icon for firewall-applet in the Plasma themes, so it should be taken from the icon theme instead. And the "breeze"/"openSUSE" look-and-feel packages use "breeze" (not "breeze-dark"). Changing just the plasma theme doesn't change the icon theme, and the "breeze" variant probably looks "bad" on a dark background.
-- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1157921
http://bugzilla.opensuse.org/show_bug.cgi?id=1157921#c5
--- Comment #5 from Frank Kruger
(In reply to Frank Kruger from comment #3)
I am using "breeze-dark" as icon theme. To be sure, I mean systemsettings5->Icons.
grep -A1 "\[Icons\]" ~/.config/kdeglobals [Icons] Theme=breeze-dark
By the way, choosing "breeze-dark" as global design, all plasma themes are working fine. However, choosing "breeze" or "openSUSE" globally and one of the dark themes for the plasma design leads to the above-mentiond issue. AFAICS there is no systemtray icon for firewall-applet in the Plasma themes, so it should be taken from the icon theme instead. And the "breeze"/"openSUSE" look-and-feel packages use "breeze" (not "breeze-dark"). Changing just the plasma theme doesn't change the icon theme, and the "breeze" variant probably looks "bad" on a dark background.
Makes sense, but it worked before TW20191126. Given the list of changed packages at https://lists.opensuse.org/opensuse-factory/2019-11/msg00351.html, the issue might be due to the update of firewall-applet 0.6.3 -> 0.7.2. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1157921
http://bugzilla.opensuse.org/show_bug.cgi?id=1157921#c6
--- Comment #6 from Wolfgang Bauer
http://bugzilla.opensuse.org/show_bug.cgi?id=1157921
http://bugzilla.opensuse.org/show_bug.cgi?id=1157921#c7
--- Comment #7 from Wolfgang Bauer
Makes sense, but it worked before TW20191126. Given the list of changed packages at https://lists.opensuse.org/opensuse-factory/2019-11/msg00351.html, the issue might be due to the update of firewall-applet 0.6.3 -> 0.7.2.
Maybe. I don't see any recent upstream change to breeze-icons: https://cgit.kde.org/breeze-icons.git/log/?qt=grep&q=firewall -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1157921
http://bugzilla.opensuse.org/show_bug.cgi?id=1157921#c8
Wolfgang Bauer
http://bugzilla.opensuse.org/show_bug.cgi?id=1157921
http://bugzilla.opensuse.org/show_bug.cgi?id=1157921#c9
Frank Kruger
Maybe it would help to delete the icon cache? (~/.cache/icon-cache.kcache) and logout/login?
I always do that. Anyway, changing the icon theme from "breeze" to "breeze-dark" does not have any effect, while using Oxygen/HighContrast/Adwaita brings back a visible firewall-applet icon (the hicolor one I guess). -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1157921
http://bugzilla.opensuse.org/show_bug.cgi?id=1157921#c10
--- Comment #10 from Wolfgang Bauer
So it's certainly caused by some change in that package... Ok, it does seem to be a KDE problem after all.
The updated firewall-applet uses two new icons, firewall-applet-shields_up and firewall-applet-shields_down. The _up one is missing in breeze (and breeze-dark), and somehow the fallback (to firewall-applet) triggers the problem (so it actually may be a "bug" in KDE's icon loader I suppose). Copying the standard breeze icon to firewall-applet-shields_up fixes it here: sudo cp /usr/share/icons/breeze/status/22/firewall-applet.svg /usr/share/icons/breeze/status/22/firewall-applet-shields_down.svg (might also be necessary to do it for other sizes, and breeze-dark) -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1157921
http://bugzilla.opensuse.org/show_bug.cgi?id=1157921#c11
Wolfgang Bauer
Copying the standard breeze icon to firewall-applet-shields_up fixes it here: sudo cp /usr/share/icons/breeze/status/22/firewall-applet.svg /usr/share/icons/breeze/status/22/firewall-applet-shields_down.svg (might also be necessary to do it for other sizes, and breeze-dark) I created a breeze5-icons package with that "hack": https://download.opensuse.org/repositories/home:/wolfi323:/test/openSUSE_Tum...
Please try it and report back. I'll file an upstream bug report later, they should add a proper firewall-applet-shields_down icon to breeze/breeze-dark (and maybe the icon loader should be investigated regarding this problem as well). -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1157921
http://bugzilla.opensuse.org/show_bug.cgi?id=1157921#c12
Frank Kruger
(In reply to Wolfgang Bauer from comment #10)
Copying the standard breeze icon to firewall-applet-shields_up fixes it here: sudo cp /usr/share/icons/breeze/status/22/firewall-applet.svg /usr/share/icons/breeze/status/22/firewall-applet-shields_down.svg (might also be necessary to do it for other sizes, and breeze-dark) I created a breeze5-icons package with that "hack": https://download.opensuse.org/repositories/home:/wolfi323:/test/ openSUSE_Tumbleweed/
Please try it and report back.
I'll file an upstream bug report later, they should add a proper firewall-applet-shields_down icon to breeze/breeze-dark (and maybe the icon loader should be investigated regarding this problem as well).
Your "breeze-icon5" package solves the issue. Thank you! -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1157921
http://bugzilla.opensuse.org/show_bug.cgi?id=1157921#c13
--- Comment #13 from Frank Kruger
http://bugzilla.opensuse.org/show_bug.cgi?id=1157921
http://bugzilla.opensuse.org/show_bug.cgi?id=1157921#c14
--- Comment #14 from Wolfgang Bauer
Is the fix supposed to be part of KDE Frameworks 5.66.0? Thx. No.
-- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1157921
http://bugzilla.opensuse.org/show_bug.cgi?id=1157921#c15
--- Comment #15 from Frank Kruger
http://bugzilla.opensuse.org/show_bug.cgi?id=1157921
http://bugzilla.opensuse.org/show_bug.cgi?id=1157921#c16
--- Comment #16 from Wolfgang Bauer
So we need more icons, then?
Preferably yes, but both would fall back to firewall-applet otherwise.
I'm down to add a shields-up state icon. shields-down can just be the normal icon.
But, this fallback apparently has the problem that the icons are not recolored then with dark themes, that seems to be a bug in the icon loader. And I noticed just now that this problem actually was mentioned already in https://phabricator.kde.org/D11880, but ignored (or supposed to be a bug in cuttlefish...).
However, there seems to be a problem for the breeze dark versions: > Shouldn't the wall be light-colored? Does it work for you when actually deployed and in use with breeze dark? I added a comment there as a first step.
-- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1157921
http://bugzilla.opensuse.org/show_bug.cgi?id=1157921#c17
Wolfgang Bauer
http://bugzilla.opensuse.org/show_bug.cgi?id=1157921
http://bugzilla.opensuse.org/show_bug.cgi?id=1157921#c18
--- Comment #18 from Wolfgang Bauer
And I noticed just now that this problem actually was mentioned already in https://phabricator.kde.org/D11880, but ignored (or supposed to be a bug in cuttlefish...).
However, there seems to be a problem for the breeze dark versions: > Shouldn't the wall be light-colored? Does it work for you when actually deployed and in use with breeze dark? Hm, seems that was actually not the same problem though, as it was about firewall-applet, not firewall-applet-shields_down...
-- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1157921
http://bugzilla.opensuse.org/show_bug.cgi?id=1157921#c19
--- Comment #19 from Frank Kruger
http://bugzilla.opensuse.org/show_bug.cgi?id=1157921
http://bugzilla.opensuse.org/show_bug.cgi?id=1157921#c20
Wolfgang Bauer
participants (1)
-
bugzilla_noreply@novell.com