[Bug 531536] New: vorbis-tools-1.1.1-229.6: missing call to fclose
http://bugzilla.novell.com/show_bug.cgi?id=531536 Summary: vorbis-tools-1.1.1-229.6: missing call to fclose Classification: openSUSE Product: openSUSE 11.2 Version: Factory Platform: All OS/Version: openSUSE 11.1 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Found By: --- I just had a look at factory package vorbis-tools-1.1.1-229.6 For source code file vorbis-tools-1.1.1/ogg123/playlist.c around line 190 is the source code for the function playlist_append_from_file. I notice the following line of code fp = fopen(playlist_filename, "r"); but I fail to notice a matching call to fclose. This looks like a resource leak to me. Suggest add a call to fclose. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=531536
Stephan Binner
http://bugzilla.novell.com/show_bug.cgi?id=531536
User tiwai@novell.com added comment
http://bugzilla.novell.com/show_bug.cgi?id=531536#c1
Takashi Iwai
http://bugzilla.novell.com/show_bug.cgi?id=531536
User dcb314@hotmail.com added comment
http://bugzilla.novell.com/show_bug.cgi?id=531536#c2
David Binderman
There is no fork from this application, thus there is no serious leak.
It is not clear to me that fork is relevant. A better question might be "How often is the function playlist_append_from_file called in normal operation ?" Every time the function is called, it leaks resource. In an ideal world, this would be fixed, but I can imagine that, in practice, it might be less important to fix it if the function is rarely called. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=531536
User tiwai@novell.com added comment
http://bugzilla.novell.com/show_bug.cgi?id=531536#c3
Takashi Iwai
participants (1)
-
bugzilla_noreply@novell.com