[Bug 849082] New: midnight commander unrar plugin broken with filenames with spaces
https://bugzilla.novell.com/show_bug.cgi?id=849082 https://bugzilla.novell.com/show_bug.cgi?id=849082#c0 Summary: midnight commander unrar plugin broken with filenames with spaces Classification: openSUSE Product: openSUSE 13.1 Version: RC 2 Platform: All OS/Version: SUSE Other Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: cus@fazekas.hu QAContact: qa-bugs@suse.de Found By: --- Blocker: --- User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Firefox/24.0 When I enter a packed rar file with in midnight commander, if the RAR file contains file or directory names with spaces, the file or directory names are only displayed until the first space character. Reproducible: Always Steps to Reproduce: Browse a .rar file in midnight commander where the rar file contains filenames with spaces. Actual Results: The file names which are shown in midnight commander are trimmed at the first space character. Expected Results: File names with spaces are shown correctly. This used to work in openSuSE 12.3. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=849082 https://bugzilla.novell.com/show_bug.cgi?id=849082#c1 Dirk Weber <d_werner@gmx.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |d_werner@gmx.net --- Comment #1 from Dirk Weber <d_werner@gmx.net> 2013-11-08 18:43:19 UTC --- The reason is that openSUSE 13.1 uses unrar 5 (currently unrar-5.0.11-2.1.6) while openSUSE 12.3 used unrar 4 (unrar-4.2.4-2.1.1). The output of unrar l looks completely different between these 2 versions. The mc extfs for rar files /usr/lib/mc/extfs.d/urar got a new function to handle this output: mcrar5fs_list() This function does not handle file names which contain spaces correctly, i.e. truncates the file name at the first space. This could be solved by a patch like: 52c52,53 < printf "%s 1 %s %s %d %02d/%02d/%02d %s ./%s\n", $1, uid, gid, $2, a[2], a[1], a[3], $6, $8 ---
name_offs = index($0, $8) printf "%s 1 %s %s %d %02d/%02d/%02d %s ./%s\n", $1, uid, gid, $2, a[2], a[1], a[3], $6, substr($0, name_offs)
I have used the same approach in an extfs script for tar files for bnc#836558 and use it without problems for months (untar extfs attached there). -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=849082 https://bugzilla.novell.com/show_bug.cgi?id=849082#c2 --- Comment #2 from Dirk Weber <d_werner@gmx.net> 2013-11-08 18:48:53 UTC --- Created an attachment (id=566726) --> (http://bugzilla.novell.com/attachment.cgi?id=566726) modified urar extfs which can handle blanks with unrar 5 The attached file can be copied to $HOME/.local/share/mc/extfs.d/ . Then after restarting mc it will use this version to handle rar archives. This file is the same as applying the patch from comment 2 to the urar file packaged in mc-4.8.10-2.2.1. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=849082 https://bugzilla.novell.com/show_bug.cgi?id=849082#c Dirk Weber <d_werner@gmx.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #566726|application/octet-stream |text/text mime type| | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=849082 https://bugzilla.novell.com/show_bug.cgi?id=849082#c Dirk Weber <d_werner@gmx.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #566726|modified urar extfs which |modified urar extfs which description|can handle blanks with |can handle blanks with |unrar 5 |unrar 5. | |Copy to | |$HOME/.local/share/mc/extfs | |.d/urar -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=849082 https://bugzilla.novell.com/show_bug.cgi?id=849082#c Xiyuan Liu <xyliu@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |xyliu@suse.com AssignedTo|bnc-team-screening@forge.pr |lazy.kent@opensuse.org |ovo.novell.com | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=849082 https://bugzilla.novell.com/show_bug.cgi?id=849082#c Kyrill Detinov <lazy.kent@opensuse.org> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|lazy.kent@opensuse.org |david@dhaller.de -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=849082 https://bugzilla.novell.com/show_bug.cgi?id=849082#c3 David Haller <david@dhaller.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |david@dhaller.de Resolution| |FIXED --- Comment #3 from David Haller <david@dhaller.de> 2013-11-12 16:40:29 CET --- Patched version is "under way". Please test. Thanks a lot for the patch, Dirk. BTW: the bug does _not_ appear if you uninstall unrar and install 'rar' ;) I noticed as I could not reproduce. Until I noticed, I had rar but not unrar installed. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=849082 https://bugzilla.novell.com/show_bug.cgi?id=849082#c4 Dirk Weber <d_werner@gmx.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED | --- Comment #4 from Dirk Weber <d_werner@gmx.net> 2013-11-12 16:01:45 UTC --- (In reply to comment #3)
Patched version is "under way". Please test.
Thanks a lot for the patch, Dirk. BTW: the bug does _not_ appear if you uninstall unrar and install 'rar' ;) I noticed as I could not reproduce. Until I noticed, I had rar but not unrar installed.
Sorry, I just found a bug in it. It uses $8 (the beginning of a filename until a separating blank - if one is included) to find this in the complete output line of unrar and then uses the rest of the line as "file name". It can be that this string already appears in the line before the actual file name. E.g. a file has the name "0" then it will be found in the date or time or file size and the output is wrong. I am working on an update. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=849082 https://bugzilla.novell.com/show_bug.cgi?id=849082#c5 Dirk Weber <d_werner@gmx.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #566726|0 |1 is obsolete| | --- Comment #5 from Dirk Weber <d_werner@gmx.net> 2013-11-12 16:25:29 UTC --- Created an attachment (id=567132) --> (http://bugzilla.novell.com/attachment.cgi?id=567132) updated urar: uses the checksum $7 as hook and trims padding blanks of short file names In an archive I observed that unrar 5 adds some padding blanks to short file names or directory names in its file list. This urar script removes blank characters at the end of short file names. if an original short file name already contained blanks at the end these would also be removed. The checksum column "$7" should be unique before the filename and work as reliable hook. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=849082 https://bugzilla.novell.com/show_bug.cgi?id=849082#c6 David Haller <david@dhaller.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution| |FIXED --- Comment #6 from David Haller <david@dhaller.de> 2013-11-12 20:18:57 CET --- Ok, your new patch was too fragile for my taste. Rewrote the whole awk-script(let) ;) Please test and DO reopen the bug if anything more is wrong (it's building in Base:System as release 70.1). -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=849082 https://bugzilla.novell.com/show_bug.cgi?id=849082#c7 Marton Balint <cus@fazekas.hu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED | --- Comment #7 from Marton Balint <cus@fazekas.hu> 2013-11-12 20:21:41 UTC --- I have installed the package, but it did not fix the problem. I will upload the problematic rar file. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=849082 https://bugzilla.novell.com/show_bug.cgi?id=849082#c8 --- Comment #8 from Marton Balint <cus@fazekas.hu> 2013-11-12 20:23:24 UTC --- Created an attachment (id=567164) --> (http://bugzilla.novell.com/attachment.cgi?id=567164) rar file where mc-4.8.10-70.1 still does not work properly -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=849082 https://bugzilla.novell.com/show_bug.cgi?id=849082#c9 --- Comment #9 from David Haller <david@dhaller.de> 2013-11-12 22:02:10 CET --- Thanks Marton, Dirk mentioned in a PM an issue with my loop over the name-parts, editing my /usr/lib/mc/extfs.d/urar fixed it for your and his test .rar files. Update coming. Leaving the bug open this time. Please test and report! Keep up finding bugs! -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=849082 https://bugzilla.novell.com/show_bug.cgi?id=849082#c10 --- Comment #10 from David Haller <david@dhaller.de> 2013-11-12 22:23:23 CET --- release 71.1 building now should (finally) be ok ... Please test and tell if everything is ok so I can close this bug. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=849082 https://bugzilla.novell.com/show_bug.cgi?id=849082#c11 Marton Balint <cus@fazekas.hu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution| |FIXED --- Comment #11 from Marton Balint <cus@fazekas.hu> 2013-11-12 22:41:09 UTC --- It works now, thanks. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=849082 https://bugzilla.novell.com/show_bug.cgi?id=849082#c12 --- Comment #12 from Bernhard Wiedemann <bwiedemann@suse.com> 2013-11-13 10:00:12 CET --- This is an autogenerated message for OBS integration: This bug (849082) was mentioned in https://build.opensuse.org/request/show/206681 Factory / mc -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=849082 https://bugzilla.novell.com/show_bug.cgi?id=849082#c13 --- Comment #13 from Bernhard Wiedemann <bwiedemann@suse.com> 2013-11-14 19:00:11 CET --- This is an autogenerated message for OBS integration: This bug (849082) was mentioned in https://build.opensuse.org/request/show/206928 Factory / mc -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=849082 https://bugzilla.novell.com/show_bug.cgi?id=849082#c14 --- Comment #14 from Bernhard Wiedemann <bwiedemann@suse.com> 2013-11-14 22:00:23 CET --- This is an autogenerated message for OBS integration: This bug (849082) was mentioned in https://build.opensuse.org/request/show/206949 Factory / mc -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=849082 https://bugzilla.novell.com/show_bug.cgi?id=849082#c15 --- Comment #15 from Bernhard Wiedemann <bwiedemann@suse.com> 2013-11-29 15:00:12 CET --- This is an autogenerated message for OBS integration: This bug (849082) was mentioned in https://build.opensuse.org/request/show/208909 Factory / mc -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=849082 https://bugzilla.novell.com/show_bug.cgi?id=849082#c16 --- Comment #16 from Bernhard Wiedemann <bwiedemann@suse.com> 2013-12-12 21:00:18 CET --- This is an autogenerated message for OBS integration: This bug (849082) was mentioned in https://build.opensuse.org/request/show/210733 13.1 / mc -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=849082 Swamp Workflow Management <swamp@suse.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Whiteboard| |obs:running:3308:low -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=849082 --- Comment #17 from Swamp Workflow Management <swamp@suse.de> --- openSUSE-RU-2014:1661-1: An update that has three recommended fixes can now be installed. Category: recommended (low) Bug References: 824729,849082,856501 CVE References: Sources used: openSUSE 13.2 (src): mc-4.8.13-4.1 openSUSE 13.1 (src): mc-4.8.13-2.9.1 openSUSE 12.3 (src): mc-4.8.13-2.4.1 -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=849082 Swamp Workflow Management <swamp@suse.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Whiteboard|obs:running:3308:low | -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com