https://bugzilla.novell.com/show_bug.cgi?id=749031 https://bugzilla.novell.com/show_bug.cgi?id=749031#c1 Li Bin changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bili@suse.com --- Comment #1 from Li Bin 2012-02-27 09:28:31 UTC --- Guy, (In reply to comment #0)

User-Agent: Mozilla/5.0 (X11; Linux i686; rv:10.0.1) Gecko/20100101 Firefox/10.0.1

1. functions dhcp_clients, save_state and restore_state are missing from the package or the 11.4 distribution so this script cannot work as supposed to. Looks the save_state/restore_state change to savestate/restorestate. dhcp_clients change to dhcp_interfaces? Not sure.

2.command_exists dhcp_clients || exit $NA Early in the script this test will make you exit. So nothing will be processes for Networkmanager or ifup/ifdown setups. Yes, it doesn't work anymore.

3. [ x"${NETWORKMANAGER}" -eq x"yes" ] && exit $NA If you compare strings you need to use "=", not "-eq". Yes, we should change it.

-- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=749031 https://bugzilla.novell.com/show_bug.cgi?id=749031#c3 Marius Tomaschewski changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mt@suse.com --- Comment #3 from Marius Tomaschewski 2012-02-27 10:40:27 UTC --- I've no idea. I'll look into pm-utils. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=749031 https://bugzilla.novell.com/show_bug.cgi?id=749031#c5 Marius Tomaschewski changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW InfoProvider|mt@suse.com | AssignedTo|bnc-team-screening@forge.pr |mvyskocil@suse.com |ovo.novell.com | --- Comment #5 from Marius Tomaschewski 2012-02-27 12:34:37 UTC --- I've no idea where the dhcp_clients should be from -- I've extracted pm-utils (and sysconfig from 11.2 [-> bnc#603291]), but I were unable to find it too. I think, Michal wanted to check / call the dhcp_interfaces() function from /etc/sysconfig/network/scripts/functions to get a list of all interfaces where a dhcp client is currently running... -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=749031 https://bugzilla.novell.com/show_bug.cgi?id=749031#c7 --- Comment #7 from Guy Zelck 2012-02-27 21:41:54 UTC --- The attachment is not quite correct. I followed Bin Li's leads, adapted the script and did a suspend/resume test => OK. The body of the script should have this in it : ============================================================================ "${PM_FUNCTIONS}" # Sanity checks [ -x /etc/init.d/network ] || exit $NA [ -r /etc/sysconfig/network/config ] && . /etc/sysconfig/network/config [ -r /etc/sysconfig/network/scripts/functions ] && . /etc/sysconfig/network/scripts/functions command_exists dhcp_interfaces || exit $NA # NetworkManager is handled by 55NetworkManager, so skip this script if # nm is enabled in sysconfig ... [ x"${NETWORKMANAGER}" = x"yes" ] && exit $NA # ... or if it is running command_exists nm_running && nm_running && exit $NA case "$1" in hibernate|suspend) savestate "dhcp_interfaces" "`dhcp_interfaces`" service network stop-all-dhcp-clients ;; thaw|resume) for interface in `restorestate "dhcp_interfaces"`; do service network restart ${interface} done ;; *) exit $NA ;; esac ============================================================================ Thanks for the quick reaction. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=749031 https://bugzilla.novell.com/show_bug.cgi?id=749031#c9 --- Comment #9 from Li Bin 2012-02-28 03:10:47 UTC --- (In reply to comment #7)

The attachment is not quite correct.

I followed Bin Li's leads, adapted the script and did a suspend/resume test => OK.

The body of the script should have this in it :

============================================================================ . "${PM_FUNCTIONS}"

# Sanity checks [ -x /etc/init.d/network ] || exit $NA [ -r /etc/sysconfig/network/config ] && . /etc/sysconfig/network/config [ -r /etc/sysconfig/network/scripts/functions ] && . /etc/sysconfig/network/scripts/functions

command_exists dhcp_interfaces || exit $NA

# NetworkManager is handled by 55NetworkManager, so skip this script if # nm is enabled in sysconfig ... [ x"${NETWORKMANAGER}" = x"yes" ] && exit $NA # ... or if it is running command_exists nm_running && nm_running && exit $NA

case "$1" in hibernate|suspend) savestate "dhcp_interfaces" "`dhcp_interfaces`" service network stop-all-dhcp-clients ;; thaw|resume) for interface in `restorestate "dhcp_interfaces"`; do service network restart ${interface} done ;; *) exit $NA ;; esac

============================================================================

Thanks for the quick reaction.

Thanks for your feedback. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=749031 https://bugzilla.novell.com/show_bug.cgi?id=749031#c11 Li Bin changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - None |P3 - Medium --- Comment #11 from Li Bin 2012-02-28 03:16:13 UTC --- BTW, it also affect the 12.1, the same issue. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=749031 https://bugzilla.novell.com/show_bug.cgi?id=749031#c13 --- Comment #13 from Li Bin 2012-02-28 04:46:20 UTC --- Anyway I just update it to 12.1. Request: #107316 submit: home:BinLi:branches:openSUSE:12.1:Update/pm-utils -> openSUSE:12.1:Update:Test Message: fix script 50rcnetwork error and update savestate/restorestate functions(bnc#749031). State: review 2012-02-28T05:45:30 BinLi -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=749031 https://bugzilla.novell.com/show_bug.cgi?id=749031#c15 Li Bin changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO InfoProvider| |maintenance@opensuse.org --- Comment #15 from Li Bin 2012-02-28 06:12:26 UTC --- Maintenance, Could we let it in updates? Thanks! -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=749031 https://bugzilla.novell.com/show_bug.cgi?id=749031#c17 --- Comment #17 from Bernhard Wiedemann 2012-02-28 16:00:08 CET --- This is an autogenerated message for OBS integration: This bug (749031) was mentioned in https://build.opensuse.org/request/show/107429 Factory / pm-utils -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=749031 https://bugzilla.novell.com/show_bug.cgi?id=749031#c19 Swamp Workflow Management changed: What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard| |maint:running:45819:low --- Comment #19 from Swamp Workflow Management 2012-02-29 08:49:40 UTC --- The SWAMPID for this issue is 45819. This issue was rated as low. Please submit fixed packages until 2012-03-28. Also create a patchinfo file using this link: https://swamp.suse.de/webswamp/wf/45819 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=749031 https://bugzilla.novell.com/show_bug.cgi?id=749031#c21 --- Comment #21 from Bernhard Wiedemann 2012-02-29 11:00:09 CET --- This is an autogenerated message for OBS integration: This bug (749031) was mentioned in https://build.opensuse.org/request/show/107518 12.1 / pm-utils https://build.opensuse.org/request/show/107519 Factory / pm-utils -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=749031 https://bugzilla.novell.com/show_bug.cgi?id=749031#c23 --- Comment #23 from Bernhard Wiedemann 2012-02-29 12:00:28 CET --- This is an autogenerated message for OBS integration: This bug (749031) was mentioned in https://build.opensuse.org/request/show/107532 11.4 / pm-utils -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=749031 https://bugzilla.novell.com/show_bug.cgi?id=749031#c25 Benjamin Brunner changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW InfoProvider|bbrunner@suse.com | --- Comment #25 from Benjamin Brunner 2012-03-05 14:05:44 CET --- Update for 11.4 and 12.1 already started. Thanks for the submission again and I will remove the needinfo. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=749031 https://bugzilla.novell.com/show_bug.cgi?id=749031#c Swamp Workflow Management changed: What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard|maint:running:45819:low |. |maint:released:11.4:45820 | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=749031 https://bugzilla.novell.com/show_bug.cgi?id=749031#c28 Li Bin changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #28 from Li Bin 2012-03-28 03:33:19 UTC --- Anyway, it should be closed now. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=749031 https://bugzilla.novell.com/show_bug.cgi?id=749031#c29 --- Comment #29 from Bernhard Wiedemann 2012-05-11 14:00:19 CEST --- This is an autogenerated message for OBS integration: This bug (749031) was mentioned in https://build.opensuse.org/request/show/120703 Factory / pm-utils -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.