[Bug 638736] New: nasm-2.07-3.3.i586.rpm breaks createrepo (bad packaging)
https://bugzilla.novell.com/show_bug.cgi?id=638736 https://bugzilla.novell.com/show_bug.cgi?id=638736#c0 Summary: nasm-2.07-3.3.i586.rpm breaks createrepo (bad packaging) Classification: openSUSE Product: openSUSE 11.3 Version: Final Platform: x86-64 OS/Version: openSUSE 11.3 Status: NEW Severity: Normal Priority: P5 - None Component: Basesystem AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: drankinatty@suddenlinkmail.com QAContact: qa@suse.de Found By: --- Blocker: --- Guys, The nasm package causes createrepo to fail with the following error: Saving Primary metadata Saving file lists metadata Saving other metadata Traceback (most recent call last): File "/usr/share/createrepo/genpkgmetadata.py", line 713, in <module> main(sys.argv[1:]) File "/usr/share/createrepo/genpkgmetadata.py", line 637, in main mdgen.doRepoMetadata() File "/usr/share/createrepo/genpkgmetadata.py", line 316, in doRepoMetadata dumpMetadata.repoXML(reporoot, self.cmds) File "/usr/share/createrepo/dumpMetadata.py", line 813, in repoXML rp.getOtherdata(complete_path, csum) File "/usr/lib/python2.6/site-packages/sqlitecachec.py", line 61, in getOtherdata self.repoid)) TypeError: Parsing other.xml error: PCDATA invalid Char value 1 I have seen this before with bad rpms in 11.0 (enlightenment exchange). I don't know what is wrong with the nasm packaging because I can read the info (shown below), but running 'sudo createrepo --update -d openSUSE_11.3/' on my local repo with nasm included fails. Here are the package details: [03:12 zephyr/home/backup/rpms] # rpm -qi nasm Name : nasm Relocations: (not relocatable) Version : 2.07 Vendor: openSUSE Release : 3.3 Build Date: Mon 05 Jul 2010 08:41:37 AM CDT Install Date: Thu 22 Jul 2010 11:33:29 AM CDT Build Host: build34 Group : Development/Languages/Other Source RPM: nasm-2.07-3.3.src.rpm Size : 1002541 License: BSD 2-clause Signature : RSA/8, Mon 05 Jul 2010 08:41:53 AM CDT, Key ID b88b2fd43dbdc284 Packager : http://bugs.opensuse.org URL : http://nasm.sourceforge.net/ Summary : Netwide Assembler (An x86 Assembler) Description : NASM is a prototype general-purpose x86 assembler. It can currently output several binary formats, including ELF, a.out, Win32, and OS/2. Read the licence agreement in /usr/share/doc/packages/nasm/Licence. Authors: -------- Julian Hall <Jules@acris.co.uk> Simon Tatham <anakin@pobox.com> Nelson Rush <palisade@users.sourceforge.net> Frank Kotler <fbkotler@users.sf.net> Stephen Silver <nasm@argentum.freeserve.co.uk> John Coffman <johninsd@users.sourceforge.net> Yuri Zaporogets <yuriz@users.sourceforge.net> H. Peter Anvin <hpa@zytor.com> John Fine <johnfine@earthlink.net> Kendall Bennet <KendallB@scitechsoft.com> Gary Clark Andrew Crabtree Rafael R. Sevilla <dido@pacific.net.ph> Jaime Tejedor GXmez, aka Metalbrain <metalbrain_coder@gmx.net> James Seter <pharos@zsnes.com> Edward J. Beroset <beroset@mindspring.com> Stanislav Karchebny, aka berkus, madfire, daemonhunter <madfire@users.sourceforge.net> Debbie Wiles, aka debs <debs@dwiles.demon.co.uk> Trevor Woerner Michael K. Ter Louw <mterlo1@uic.edu> Martin Wawro Alexei Frounze <alexfru@users.sourceforge.net> Keith Kanios, aka SpooK <keith@kanios.net> Chuck Crayne <ccrayne@users.sourceforge.net> Distribution: openSUSE 11.3 The package probably just needs rebuilding. Cheers. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=638736 https://bugzilla.novell.com/show_bug.cgi?id=638736#c1 --- Comment #1 from David Rankin <drankinatty@suddenlinkmail.com> 2010-09-12 08:21:39 UTC --- Oops -- This is the i586 package NOT the x86_64 package. Sorry for the confusion. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=638736 https://bugzilla.novell.com/show_bug.cgi?id=638736#c wei wang <wewang@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wewang@novell.com AssignedTo|bnc-team-screening@forge.pr |pth@novell.com |ovo.novell.com | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=638736 https://bugzilla.novell.com/show_bug.cgi?id=638736#c Philipp Thomas <pth@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pth@novell.com AssignedTo|pth@novell.com |ro@novell.com -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=638736 https://bugzilla.novell.com/show_bug.cgi?id=638736#c2 Ruediger Oertel <ro@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO InfoProvider| |cthiel@novell.com --- Comment #2 from Ruediger Oertel <ro@novell.com> 2010-09-13 16:49:38 UTC --- it's "otherdata", so probably the changelog is strange ... still createrepo should not just break on questionable input ... Christoph, can you have a look ? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=638736 https://bugzilla.novell.com/show_bug.cgi?id=638736#c3 Christoph Thiel <cthiel@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cthiel@novell.com, | |mbarringer@novell.com InfoProvider|cthiel@novell.com |drankinatty@suddenlinkmail. | |com Severity|Normal |Critical --- Comment #3 from Christoph Thiel <cthiel@novell.com> 2010-09-13 20:27:14 UTC --- Which version of createrepo is this? I'll set NEEDINFO to the report and CC Matt, who is maintaining createrepo these days. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=638736 https://bugzilla.novell.com/show_bug.cgi?id=638736#c4 David Rankin <drankinatty@suddenlinkmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW InfoProvider|drankinatty@suddenlinkmail. | |com | --- Comment #4 from David Rankin <drankinatty@suddenlinkmail.com> 2010-09-13 23:02:12 UTC --- (In reply to comment #3)
Which version of createrepo is this? I'll set NEEDINFO to the report and CC Matt, who is maintaining createrepo these days.
Christoph, this is 0.4.9: createrepo --version 0.4.9 I have tried working with the new 0.9.8 version, but I haven't been successful with openSuSE repositories and version 0.9x. Currently I have ~15,110 rpms in 4 repos: http://www.3111skyline.com/update/openSUSE_11.0/ http://www.3111skyline.com/update/factory_11.0/ http://www.3111skyline.com/update/openSUSE_11.3/ http://www.3111skyline.com/update/factory_11.3/ I think you can get to them publicly if you want to see what's there. The titles are fairly self-explanatory. I have run the 11.0 local repos since 2008 w/o any issues except for the 11.0 enlightenment exchange package (Dmitry fixed this package) and now the nasm package in 11.3. I was caught completely off-guard by the fact that 1 package can cause the whole createrepo process to fail. Strange, but I guess there is some logic and checks each package and tanks if it finds something wrong. Regardless, the issue this time is the nasm package. I'm not worried about fixing createrepo, I'll fight 0.9x later, right now I just wanted to make sure the nasm package got repackaged so that others who maintain local repos or mirrors don't get screwed by the same issue. There are very few folks who will step through 1200+ packages to try and figure out which needle-in-the-haystack is the problem. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=638736 https://bugzilla.novell.com/show_bug.cgi?id=638736#c5 --- Comment #5 from David Rankin <drankinatty@suddenlinkmail.com> 2010-09-14 19:00:01 UTC --- Guys, FYI, I updated to rpm-5.1.9 and createrepo 0.9.8. There appear to be additional sensitivities in 0.9.8. In my case, all my repos built fine with 0.4.4 (except for the nasm package). Now my 11.3 repo still builds fine with 0.9.8, but my 11.0 repo craters with: [13:55 nirvana:/home/backup/rpms] # createrepo --update -d openSUSE_11.0/ 1149/6790 - i586/libopencore-amrwb0-0.1.2-0.pm.1.1.i586.rpm Traceback (most recent call last): File "/usr/share/createrepo/genpkgmetadata.py", line 249, in <module> main(sys.argv[1:]) File "/usr/share/createrepo/genpkgmetadata.py", line 223, in main mdgen.doPkgMetadata() File "/usr/lib/python2.6/site-packages/createrepo/__init__.py", line 367, in doPkgMetadata self.writeMetadataDocs(packages) File "/usr/lib/python2.6/site-packages/createrepo/__init__.py", line 531, in writeMetadataDocs self.primaryfile.write(po.xml_dump_primary_metadata()) File "/usr/lib/python2.6/site-packages/yum/packages.py", line 1168, in xml_dump_primary_metadata msg += misc.to_unicode(self._dump_format_items()) File "/usr/lib/python2.6/site-packages/yum/packages.py", line 1039, in _dump_format_items msg += self._dump_requires() File "/usr/lib/python2.6/site-packages/yum/packages.py", line 1097, in _dump_requires mylist = self._requires_with_pre() File "/usr/lib/python2.6/site-packages/yum/packages.py", line 1369, in _requires_with_pre pre = map(self._is_pre_req, lst) File "/usr/lib/python2.6/site-packages/yum/packages.py", line 1359, in _is_pre_req rpm.RPMSENSE_SCRIPT_PRE | AttributeError: 'module' object has no attribute 'RPMSENSE_PREREQ' What is this AttributeError: 'module' object has no attribute 'RPMSENSE_PREREQ'? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=638736 https://bugzilla.novell.com/show_bug.cgi?id=638736#c6 --- Comment #6 from David Rankin <drankinatty@suddenlinkmail.com> 2010-09-14 22:19:35 UTC --- Here is what the upstream guys have to say about the issue: err... only suse uses PreReq nowadays. that might be your problem. See openSUSETools on build.o.o for the package createrepo and see what patches they used. Can suse fix this. What is PreReq anyway? Here is the patch suggestion. I haven't tried it yet, but I'll report back after I do. Put this in your hip-pocket for now: patch-yum-packages.py --- yum/packages.py.orig +++ yum/packages.py @@ -1353,11 +1353,14 @@ is a pre-requires or a not""" # FIXME this should probably be put in rpmUtils.miscutils since # - that's what it is + RPMSENSE_PREREQ = (1 << 6) + RPMSENSE_SCRIPT_PRE = (1 << 9) + RPMSENSE_SCRIPT_POST = (1 << 10) if flag is not None: # Note: RPMSENSE_PREREQ == 0 since rpm-4.4'ish - if flag & (rpm.RPMSENSE_PREREQ | - rpm.RPMSENSE_SCRIPT_PRE | - rpm.RPMSENSE_SCRIPT_POST): + if flag & (RPMSENSE_PREREQ | + RPMSENSE_SCRIPT_PRE | + RPMSENSE_SCRIPT_POST): return 1 return 0 -- 1.6.0.2 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=638736 https://bugzilla.novell.com/show_bug.cgi?id=638736#c7 --- Comment #7 from David Rankin <drankinatty@suddenlinkmail.com> 2010-09-14 22:41:25 UTC --- patch confirmed good and it works like a champ: [17:28 nirvana:/home/backup/rpms] # createrepo --update -d openSUSE_11.0/ 6790/6790 - src/fraqtive-0.4.4-3.22.src.rpm Saving Primary metadata Saving file lists metadata Saving other metadata Generating sqlite DBs Sqlite DBs complete So now if somebody can, please confirm that suse is incorporating this patch or something similr to handle the PreReq issue. Thanks. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=638736 https://bugzilla.novell.com/show_bug.cgi?id=638736#c8 Matt Barringer <mbarringer@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO InfoProvider| |drankinatty@suddenlinkmail. | |com --- Comment #8 from Matt Barringer <mbarringer@novell.com> 2010-09-15 09:37:47 UTC --- Can you attach the specific RPM that causes this problem? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=638736 https://bugzilla.novell.com/show_bug.cgi?id=638736#c9 David Rankin <drankinatty@suddenlinkmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW InfoProvider|drankinatty@suddenlinkmail. | |com | --- Comment #9 from David Rankin <drankinatty@suddenlinkmail.com> 2010-09-15 17:37:30 UTC --- Created an attachment (id=389797) --> (http://bugzilla.novell.com/attachment.cgi?id=389797) This is the nasm rpm that caused createrepo to fail originally Sure, attached is the nasm rpm that started this adventure :p -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=638736 https://bugzilla.novell.com/show_bug.cgi?id=638736#c10 --- Comment #10 from David Rankin <drankinatty@suddenlinkmail.com> 2010-09-15 19:59:10 UTC --- Here is the bottom line with the nasm package. Running createrepo 0.4X will fail when it hits the nasm package. However, after updating to rpm-5.1.9 and createrepo-0.9.8 and patching yum for RPMSENSE_PREREQ, I can update the repository metadata *with* the nasm package included without any problems. So it looks like the nasm packaging issue is just going to bite those who are still running createrepo 0.4X (unfortunately 0.4X is still the STABLE createrepo release, so something needs to be fixed) So for purposes of this bug, the issue still focuses on fixing nasm so it plays well with createrepo 0.4x. With the patch above and using rpm-5.1.9 and createrepo-0.9.8, the problem takes care of itself, because createrepo no longer chokes on the "otherdata" anomaly in the package. HTH -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=638736 https://bugzilla.novell.com/show_bug.cgi?id=638736#c11 --- Comment #11 from David Rankin <drankinatty@suddenlinkmail.com> 2010-09-16 23:44:15 UTC --- A few more problem packages: Here createrepo doesn't fail, but throws the following errors: 219/1280 - i586/libffi-devel-4.5-4.2.i586.rpm iso-8859-1 encoding on A French dictionary for the ASpell spell checker. Authors: -------- R�mi Vanicat <vanicat@labri.u-bordeaux.fr> Christophe Pythoud <Christophe.Pythoud@ling.unil.ch> 1193/1280 - i586/libopencore-amrwb0-0.1.2-1.1.i586.rpm iso-8859-1 encoding on A Spanish dictionary for the ASpell spell checker. Authors: -------- Santiago Rodr�guez <srodri@fi.upm.es> Jes�s Carretero <jcarrete@fi.upm.es> There needs to be either a clear standard that says (1) ASCII only in rpm metadata (no cute fancy tildes) or (2) createrepo needs to be internationalized to handle the funky extended character set... -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=638736 https://bugzilla.novell.com/show_bug.cgi?id=638736#c12 Ruediger Oertel <ro@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|ro@novell.com |mbarringer@novell.com --- Comment #12 from Ruediger Oertel <ro@novell.com> 2010-11-10 11:08:07 UTC --- reassigning to createrepo maintainer -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=638736 https://bugzilla.novell.com/show_bug.cgi?id=638736#c13 --- Comment #13 from Philipp Thomas <pth@novell.com> 2010-11-10 12:38:46 CET --- Looks like the culprit in all cases are characters that aren't encoded in UTF8. This is a leftover from the autobuild days when the tools involved couldn't correctly deal with differing encodings and had no way to enforce utf8. I don't know if createrepo can be modified to deal with that. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=638736 https://bugzilla.novell.com/show_bug.cgi?id=638736#c Matt Barringer <mbarringer@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - None |P3 - Medium Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply@novell.com