[Bug 527501] New: linuxrc-3.4.3-1.7: missing call to fclose
http://bugzilla.novell.com/show_bug.cgi?id=527501 Summary: linuxrc-3.4.3-1.7: missing call to fclose Classification: openSUSE Product: openSUSE 11.2 Version: Factory Platform: All OS/Version: openSUSE 11.1 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Found By: --- I just had a look at factory package linuxrc-3.4.3-1.7 For source code file linuxrc-3.4.3/util.c around line 2120 is the source code for the function util_hex_main. I notice the following lines of code f = fopen(argv[1], "r"); but I fail to find a matching call to fclose. This seems to be a resource leak. Suggest code rework, possibly by adding call to fclose. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=527501
Marcus Meissner
http://bugzilla.novell.com/show_bug.cgi?id=527501
User snwint@novell.com added comment
http://bugzilla.novell.com/show_bug.cgi?id=527501#c1
Steffen Winterfeldt
http://bugzilla.novell.com/show_bug.cgi?id=527501
User dcb314@hotmail.com added comment
http://bugzilla.novell.com/show_bug.cgi?id=527501#c2
David Binderman
The next thing it does is an exit() anyway.
I am not familiar with the package, but I had a quick look in source code file linuxrc.c and it isn't clear to me that you are correct. My advice would be that if you are sure that it always calls exit on every execution path, then close the report. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=527501
User snwint@novell.com added comment
http://bugzilla.novell.com/show_bug.cgi?id=527501#c3
Steffen Winterfeldt
participants (1)
-
bugzilla_noreply@novell.com